From: Su Hui <suhui@nfschina.com>
To: NeilBrown <neil@brown.name>
Cc: chuck.lever@oracle.com, jlayton@kernel.org, okorniev@redhat.com,
Dai.Ngo@oracle.com, tom@talpey.com, linux-nfs@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Su Hui <suhui@nfschina.com>
Subject: Re: [PATCH] nfsd: Replace simple_strtoul with kstrtoint in expkey_parse
Date: Thu, 29 May 2025 10:15:06 +0800 [thread overview]
Message-ID: <9d99618a-28a9-4ada-aba7-907f814bca76@nfschina.com> (raw)
In-Reply-To: <174839190520.608730.15461813542926388395@noble.neil.brown.name>
On 2025/5/28 08:25, NeilBrown wrote:
> On Tue, 27 May 2025, Su Hui wrote:
>> kstrtoint() is better because simple_strtoul() ignores overflow and the
>> type of 'fsidtype' is 'int' rather than 'unsigned long'.
> Thanks for the patch.
>
> Reviewed-by: NeilBrown <neil@brown.name>
>
> The valid values for fsidtype are actually 0-7 so it might be nice to
> change the type to u8 everywhere and make this kstrtou8() but that isn't
> really needed and shouldn't stop this patch landing.
Thanks for your suggestion.
I can try this next week in a new patch because this has been merged
into nfsd-testing and I need some time to view code.
Su Hui
next prev parent reply other threads:[~2025-05-29 2:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-27 9:25 Su Hui
2025-05-28 0:25 ` NeilBrown
2025-05-29 2:15 ` Su Hui [this message]
2025-05-28 11:11 ` Jeff Layton
2025-05-28 14:10 ` cel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d99618a-28a9-4ada-aba7-907f814bca76@nfschina.com \
--to=suhui@nfschina.com \
--cc=Dai.Ngo@oracle.com \
--cc=chuck.lever@oracle.com \
--cc=jlayton@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®