From: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Taniya Das <taniya.das@oss.qualcomm.com>,
Vikash Garodia <vikash.garodia@oss.qualcomm.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Stephan Gerhold <stephan.gerhold@linaro.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] arm64: dts: qcom: sm8650: correct Iris corners for the MXC rail
Date: Wed, 18 Mar 2026 14:46:15 +0530 [thread overview]
Message-ID: <9d9a8381-e174-72ef-6e69-1b26de07da67@oss.qualcomm.com> (raw)
In-Reply-To: <scsvyc7vb3lnk6mktwltdac5bkynvrzd4jrx7dwceeesbqnhrh@clz7d5e3igkk>
On 3/18/2026 12:32 PM, Dmitry Baryshkov wrote:
> On Wed, Mar 18, 2026 at 10:54:07AM +0530, Dikshita Agarwal wrote:
>>
>>
>> On 3/13/2026 8:57 PM, Dmitry Baryshkov wrote:
>>> The corners of the MVS0 / MVS0C clocks on the MMCX rail don't always
>>> match the PLL corners on the MXC rail. Correct the performance corners
>>> for the MXC rail following the PLL documentation.
>>>
>>> Fixes: 56cf5ad39a55 ("arm64: dts: qcom: sm8650: add iris DT node")
>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>>> ---
>>> arch/arm64/boot/dts/qcom/sm8650.dtsi | 8 ++++----
>>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi
>>> index 357e43b90740..9437360ea215 100644
>>> --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi
>>> @@ -5236,13 +5236,13 @@ opp-196000000 {
>>>
>>> opp-300000000 {
>>> opp-hz = /bits/ 64 <300000000>;
>>
>> I see in the document that this level value should be 280000000, could you
>> pls check and update accordingly.
>
> I cross-checked, the table for SM8650 lists 300 MHz here.
Ack.
Thanks,
Dikshita
>
>>
>>> - required-opps = <&rpmhpd_opp_low_svs>,
>>> + required-opps = <&rpmhpd_opp_svs>,
>>> <&rpmhpd_opp_low_svs>;
>>> };
>>>
>>> opp-380000000 {
>>> opp-hz = /bits/ 64 <380000000>;
>>> - required-opps = <&rpmhpd_opp_svs>,
>>> + required-opps = <&rpmhpd_opp_svs_l1>,
>>> <&rpmhpd_opp_svs>;
>>> };
>>>
>>> @@ -5254,13 +5254,13 @@ opp-435000000 {
>>>
>>> opp-480000000 {
>>> opp-hz = /bits/ 64 <480000000>;
>>> - required-opps = <&rpmhpd_opp_nom>,
>>> + required-opps = <&rpmhpd_opp_svs_l1>,
>>> <&rpmhpd_opp_nom>;
>>> };
>>>
>>> opp-533333334 {
>>> opp-hz = /bits/ 64 <533333334>;
>>> - required-opps = <&rpmhpd_opp_turbo>,
>>> + required-opps = <&rpmhpd_opp_svs_l1>,
>>> <&rpmhpd_opp_turbo>;
>>> };
>>> };
>>>
>>
>> with above comment addressed.
>>
>> Reviewed-by: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
>>
>> Thanks,
>> Dikshita
>
next prev parent reply other threads:[~2026-03-18 9:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 15:27 [PATCH 0/6] arm64: dts: qcom: " Dmitry Baryshkov
2026-03-13 15:27 ` [PATCH 1/6] arm64: dts: qcom: hamoa: " Dmitry Baryshkov
2026-03-17 7:55 ` Dikshita Agarwal
2026-03-13 15:27 ` [PATCH 2/6] arm64: dts: qcom: lemans: " Dmitry Baryshkov
2026-03-18 5:31 ` Dikshita Agarwal
2026-03-13 15:27 ` [PATCH 3/6] arm64: dts: qcom: monaco: " Dmitry Baryshkov
2026-03-13 15:27 ` [PATCH 4/6] arm64: dts: qcom: sm8550: " Dmitry Baryshkov
2026-03-17 7:48 ` Dikshita Agarwal
2026-03-17 7:49 ` Dikshita Agarwal
2026-03-13 15:27 ` [PATCH 5/6] arm64: dts: qcom: sm8650: " Dmitry Baryshkov
2026-03-18 5:24 ` Dikshita Agarwal
2026-03-18 7:02 ` Dmitry Baryshkov
2026-03-18 9:16 ` Dikshita Agarwal [this message]
2026-03-13 15:27 ` [PATCH 6/6] arm64: dts: qcom: sm8750: " Dmitry Baryshkov
2026-03-18 5:17 ` Dikshita Agarwal
2026-03-19 2:46 ` [PATCH 0/6] arm64: dts: qcom: " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d9a8381-e174-72ef-6e69-1b26de07da67@oss.qualcomm.com \
--to=dikshita.agarwal@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=stephan.gerhold@linaro.org \
--cc=taniya.das@oss.qualcomm.com \
--cc=vikash.garodia@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®