From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1084403E88 for ; Thu, 30 Jul 2026 11:02:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785409336; cv=none; b=qL4mYPmdokp6FJfWa35Nz+lo2e4Zvf8mOT+zfCQ1XU5dczMPLBB4NkUN9bF+opOgRBRmUOdksBEPPJ4/S3uZa97RteUWwozgwQdfHx0qAdCT7pRgZ6opcOx1PqjAJGgirHyEW7wSxu9gUGfbe7SPxIPb9D1njDLDrkg7PdFoIUI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785409336; c=relaxed/simple; bh=4dNV8PH0CaE40xpTad7DkyOXVNy048PvQhAPvDCkzwI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PJbSMrsj/JG0ttkLBU0v7BY3ZkdC5HpEf532WNi/i6QiiOVyXaeZ56O6oqNSWVYEDMZskob1hapg2YfUFN5AueAlQmSBSZbw9Z1WB8lkcttgvCPKwR72nd712yZ4uIv/E9LQFVH5lLDLRuXMw8bevzDvhOOtfm2lDnBerucrgCE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=UqXoLe4o; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=juxbA9z6; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UqXoLe4o"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="juxbA9z6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785409334; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xGF4bBEyPT9GA0aGVwzyimStY//dkrh0h2Ht9VGZr7c=; b=UqXoLe4o0pV8vH9tHJ5gH33EIizWCO5d84JXeQZuiSXGLpocoZTWuANNNzkoONMvuFrMB8 FdYI1e/Knj/qtmE/65a4dNV7YKWIYu7wWZ3/mJNTHOYtEoflKNv+0eqVA3aw9paQ7+9FxW mCutB81zrNyPVI597xLT6rU1kcYq+NY= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-120-CJxMF1rOMdeMyf7v9Qnx2Q-1; Thu, 30 Jul 2026 07:02:12 -0400 X-MC-Unique: CJxMF1rOMdeMyf7v9Qnx2Q-1 X-Mimecast-MFC-AGG-ID: CJxMF1rOMdeMyf7v9Qnx2Q_1785409331 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-47faa02f707so589982f8f.1 for ; Thu, 30 Jul 2026 04:02:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1785409331; x=1786014131; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=xGF4bBEyPT9GA0aGVwzyimStY//dkrh0h2Ht9VGZr7c=; b=juxbA9z6XqwaJNCKcoJ9uv4M1IVgCjDc0YXm8yxZ2l3vGHwftQxeCCkM0uoX6pxUbV k5Dhn73wHJGdoRAmhvE5azNSLPVbqAhTWTaLPU9QDdQpxSYIejUPO/jf7O3tn/R+27F9 1MM0EB9QMF9ljk7hqOYrPMtwTItpVJXfST9Mo7oEhjHnPXtU4FrtKhgYK0labPnXMISq 9U94puQo7Bgay8+6Tr789dTymCrSXxBF/OIsvIcoex2ugL5a5NstkGLVgv0LVMKcju2C HDRpRAP1JAE/pvJysv4ihxXUmGWgtvmH4KF8P/KCy08U/NH32Y5jv6c+DbHvmfq8Eswi TSQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785409331; x=1786014131; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=xGF4bBEyPT9GA0aGVwzyimStY//dkrh0h2Ht9VGZr7c=; b=RivNo4PEtUlNxvvH5DpvZJR80CaZi6FTT35LbFQbKAHTzMHRatrqY3K14Z0yDipWI0 p1I70vpD39cajRyuD5PS7NTIyvGgKtoaP9g4a/f2h1ukZ5FQZGTTegciVKBWL+izy1ic zCYtBp3CdDfgQhyQt9Gv6L7MEr/QfN3UsxrEVzSqB1o5Sfe9OIqSYHEXJDIgM1RBWS9E 9IjizA6St+8yvd8bmPUi1okfJieU9XQ2TlBk0YIwnqr1/gRKlyrGauUAAluuB/Zcpqkx 7NPih5Tztg8r4s6hxTst0EFnrMiqta93hmwv9uxDrSpKUaG53dXdArXTW17u9/uZQS56 oLag== X-Forwarded-Encrypted: i=1; AHgh+RrEHOrzPWe7XcgDOg3cGtBffNl4fAM39vBjcCbP3V4HPMmCctFHsAqTB6Qq8MMZSFpHC+7lQzb9WVJrK0s=@vger.kernel.org X-Gm-Message-State: AOJu0YzmUW0EiHPdBoQwvLZq4Qr2VBdGRu1Mm+brKbysLg6+TxMYzuvD C8rdLSmYqG+DkOtyf7uzPspJIvYoRNL4IfUKGDkU0/bHs80krYFc6g/dvWTZdVvYiaEjNxHPcS9 nXYU4HAP2jTWYL3no6Smh5ElmEMrGvFIZGkCnH0LkLpKPbygPF/t8cdv9c8WF851hGQ== X-Gm-Gg: AR+sD13bd9JCkuKNyFeVLXO1NzTqiW1IWSaK3U3YNbsN6e1F5KdT8phxudDLYodGxfx dDn5iokADhlMgyGgE5j8Mp9lZxXYV8xKREEwsPeM4UBCYotsa4AP5v8sHGh5gEEqILYxZgmpGju RW8J09rlzhUkFbqRnpuRQLzM5PWkejgJg7ESoi9t+V3q1JMIvtY8SJypo01FUTLTLTjxjJh3Eq9 CsVVK/N7YYpqjR1zyX/jG/K9EtV9zjXjdCXb0JHZQni1N+lvtE5Mv3eN8MIZmwjlEqADbiABSCQ ZPNOaeLciwZr8XmOe1dG+ihVQcvylwd076iqekiDQDDQx5Q5aeIrKBBT5Y3jySnr0M3NqIxiAtN 66T/5jRQ/t6ePH92gPtAQZsmb2OXRiptnKPgDEwx1SKPFlyh3gaJIEyXeG7Be8cmj7/GoaQuEeM xKwA== X-Received: by 2002:a05:6000:469c:b0:47f:70f2:ccf6 with SMTP id ffacd0b85a97d-47fc8bcfa1dmr1198739f8f.6.1785409331079; Thu, 30 Jul 2026 04:02:11 -0700 (PDT) X-Received: by 2002:a05:6000:469c:b0:47f:70f2:ccf6 with SMTP id ffacd0b85a97d-47fc8bcfa1dmr1198714f8f.6.1785409330584; Thu, 30 Jul 2026 04:02:10 -0700 (PDT) Received: from ?IPV6:2a0d:3344:5521:6b10:58fd:68f:7756:389d? ([2a0d:3344:5521:6b10:58fd:68f:7756:389d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fc8934ba3sm4817223f8f.27.2026.07.30.04.02.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jul 2026 04:02:10 -0700 (PDT) Message-ID: <9da84225-3d4c-4dd2-ac77-192ab0f3c03b@redhat.com> Date: Thu, 30 Jul 2026 13:02:08 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] liquidio: Fix possible memory leak in lio_reset_queues() To: Jacob Keller , Abdun Nihaal , andrew+netdev@lunn.ch Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260727080258.86279-1-nihaal@cse.iitm.ac.in> <54804d01-9254-4482-a0be-c38c3c6177b8@intel.com> From: Paolo Abeni Content-Language: en-US In-Reply-To: <54804d01-9254-4482-a0be-c38c3c6177b8@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/28/26 12:55 AM, Jacob Keller wrote: > On 7/27/2026 1:02 AM, Abdun Nihaal wrote: >> The memory allocated in lio_setup_glists() and setup_rx_oom_poll_fn() is >> not freed in some of the error paths in lio_reset_queues(). >> Fix that by adding the corresponding free functions to the error paths. >> >> Fixes: 4b6e326b2d34 ("liquidio: Per queue oom work queue") >> Cc: stable@vger.kernel.org >> Signed-off-by: Abdun Nihaal >> --- >> Compile tested only. Issue found using static analysis. >> > > Would be nice if we had a reproduction but I suspect this is tricky to > do without some kind of fault injection. We are actually requesting such info, especially for patch touching less active device drivers. Also sashiko has a bit to say: https://sashiko.dev/#/patchset/20260727080258.86279-1-nihaal%40cse.iitm.ac.in /P