mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Christian König" <christian.koenig@amd.com>
To: xinhui pan <xinhui.pan@amd.com>, linux-kernel@vger.kernel.org
Cc: nicholas.johnson-opensource@outlook.com.au,
	Felix.Kuehling@amd.com, Alexander.Deucher@amd.com
Subject: Re: [PATCH] drm/amdgpu: Correct the condition of warning while bo release
Date: Mon, 9 Mar 2020 15:45:04 +0100	[thread overview]
Message-ID: <9da8f3a9-5d28-37b9-cda6-8be336068e7b@amd.com> (raw)
In-Reply-To: <20200309143458.18411-1-xinhui.pan@amd.com>

Am 09.03.20 um 15:34 schrieb xinhui pan:
> Only kernel bo has kfd eviction fence.
> This warning is to give a notice that kfd only remove eviction fence on
> individual bos.
>
> Signed-off-by: xinhui pan <xinhui.pan@amd.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> index 5766d20f29d8..e99f68af2bf7 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> @@ -1308,7 +1308,8 @@ void amdgpu_bo_release_notify(struct ttm_buffer_object *bo)
>   		amdgpu_amdkfd_unreserve_memory_limit(abo);
>   
>   	/* We only remove the fence if the resv has individualized. */
> -	WARN_ON_ONCE(bo->base.resv != &bo->base._resv);
> +	WARN_ON_ONCE(bo->type == ttm_bo_type_kernel
> +			&& bo->base.resv != &bo->base._resv);
>   	if (bo->base.resv == &bo->base._resv)
>   		amdgpu_amdkfd_remove_fence_on_pt_pd_bos(abo);
>   


  reply	other threads:[~2020-03-09 14:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-09 14:34 xinhui pan
2020-03-09 14:45 ` Christian König [this message]
2020-03-09 16:03   ` Nicholas Johnson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9da8f3a9-5d28-37b9-cda6-8be336068e7b@amd.com \
    --to=christian.koenig@amd.com \
    --cc=Alexander.Deucher@amd.com \
    --cc=Felix.Kuehling@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicholas.johnson-opensource@outlook.com.au \
    --cc=xinhui.pan@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®