From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Tylor Yang <tylor_yang@himax.corp-partner.google.com>,
dmitry.torokhov@gmail.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
jikos@kernel.org, benjamin.tissoires@redhat.com,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: poyuan_chang@himax.corp-partner.google.com,
jingyliang@chromium.org, hbarnor@chromium.org, wuxy23@lenovo.com,
luolm1@lenovo.com, poyu_hung@himax.corp-partner.google.com
Subject: Re: [PATCH v3 4/4] HID: touchscreen: Add initial support for Himax HID-over-SPI
Date: Tue, 17 Oct 2023 19:03:22 +0200 [thread overview]
Message-ID: <9da94b23-cfcb-4086-a080-7e6e59866d25@linaro.org> (raw)
In-Reply-To: <20231017091900.801989-5-tylor_yang@himax.corp-partner.google.com>
On 17/10/2023 11:19, Tylor Yang wrote:
...
> +
> +#if defined(CONFIG_FB)
> +int fb_notifier_callback(struct notifier_block *self,
> + unsigned long event, void *data)
> +{
> + const struct fb_event *evdata = data;
> + int *blank;
> + struct himax_ts_data *ts =
> + container_of(self, struct himax_ts_data, fb_notif);
> +
> + I("entered");
> +
> + if (!ts) {
> + E("ts is NULL");
> + return -ECANCELED;
> + }
There are so many wrong things with this.... First, tell me, how
container of valid pointer can be NULL?
Second, this is not Linux coding style.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-10-17 17:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 9:18 [PATCH v3 0/4] HID: touchscreen: add himax hid-over-spi driver Tylor Yang
2023-10-17 9:18 ` [PATCH v3 1/4] dt-bindings: input: Introduce Himax HID-over-SPI device Tylor Yang
2023-10-17 13:59 ` Conor Dooley
2023-10-17 16:58 ` Krzysztof Kozlowski
2023-10-17 9:18 ` [PATCH v3 2/4] HID: touchscreen: Add initial support for Himax HID-over-SPI Tylor Yang
2023-10-17 17:01 ` Krzysztof Kozlowski
2023-10-18 7:15 ` Benjamin Tissoires
2023-10-18 10:14 ` kernel test robot
2023-10-17 9:18 ` [PATCH v3 3/4] " Tylor Yang
2023-10-18 7:23 ` Benjamin Tissoires
2023-10-17 9:19 ` [PATCH v3 4/4] " Tylor Yang
2023-10-17 17:03 ` Krzysztof Kozlowski [this message]
2023-10-19 3:51 ` kernel test robot
2023-10-19 6:47 ` kernel test robot
2023-10-17 17:08 ` [PATCH v3 0/4] HID: touchscreen: add himax hid-over-spi driver Krzysztof Kozlowski
2023-10-17 21:41 ` Doug Anderson
2023-10-18 6:07 ` Krzysztof Kozlowski
2023-10-18 6:33 ` Benjamin Tissoires
2024-01-18 23:06 ` Dmitry Torokhov
2024-01-22 4:57 ` Tomasz Figa
2024-01-22 8:08 ` Krzysztof Kozlowski
2024-01-22 13:57 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9da94b23-cfcb-4086-a080-7e6e59866d25@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=benjamin.tissoires@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=hbarnor@chromium.org \
--cc=jikos@kernel.org \
--cc=jingyliang@chromium.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luolm1@lenovo.com \
--cc=poyu_hung@himax.corp-partner.google.com \
--cc=poyuan_chang@himax.corp-partner.google.com \
--cc=robh+dt@kernel.org \
--cc=tylor_yang@himax.corp-partner.google.com \
--cc=wuxy23@lenovo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®