From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752147AbdBZIE0 (ORCPT ); Sun, 26 Feb 2017 03:04:26 -0500 Received: from smtp-proxy004.phy.lolipop.jp ([157.7.104.45]:55373 "EHLO smtp-proxy004.phy.lolipop.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750971AbdBZIEX (ORCPT ); Sun, 26 Feb 2017 03:04:23 -0500 Subject: Re: [PATCH] ASoC: dwc: remove 'out of memory' message To: Mihai Burduselu , tiwai@suse.com, perex@perex.cz References: <20170225110323.7506-1-michelcatalin@gmail.com> Cc: Jose.Abreu@synopsys.com, alsa-devel@alsa-project.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, broonie@kernel.org, s.nawrocki@samsung.com, colin.king@canonical.com From: Takashi Sakamoto Message-ID: <9da9efc3-cd9b-70a5-a764-e8be32e67d13@sakamocchi.jp> Date: Sun, 26 Feb 2017 17:03:22 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170225110323.7506-1-michelcatalin@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Feb 25 2017 20:03, Mihai Burduselu wrote: > Reported by checkpatch.pl > Signed-off-by: Mihai Burduselu > --- > sound/soc/dwc/designware_i2s.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/sound/soc/dwc/designware_i2s.c b/sound/soc/dwc/designware_i2s.c > index 9c46e4112026..6479768cc6a1 100644 > --- a/sound/soc/dwc/designware_i2s.c > +++ b/sound/soc/dwc/designware_i2s.c > @@ -611,10 +611,8 @@ static int dw_i2s_probe(struct platform_device *pdev) > const char *clk_id; > > dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_KERNEL); > - if (!dev) { > - dev_warn(&pdev->dev, "kzalloc fail\n"); > + if (!dev) The line for 'dev_warn()' should be kept. > return -ENOMEM; > - } > > dw_i2s_dai = devm_kzalloc(&pdev->dev, sizeof(*dw_i2s_dai), GFP_KERNEL); > if (!dw_i2s_dai) Regards Takashi Sakamoto