From: Luca Ceresoli <luca@lucaceresoli.net>
To: Adam Ford <aford173@gmail.com>, linux-clk@vger.kernel.org
Cc: aford@beaconembedded.com,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 1/2] dt-bindings: clk: versaclock5: Add optional load capacitance property
Date: Wed, 20 Jan 2021 17:35:03 +0100 [thread overview]
Message-ID: <9dab169a-e551-7ba1-7fe2-d00e80978388@lucaceresoli.net> (raw)
In-Reply-To: <20210119212109.1064786-1-aford173@gmail.com>
Hi Adam,
On 19/01/21 22:21, Adam Ford wrote:
> There are two registers which can set the load capacitance for
> XTAL1 and XTAL2. These are optional registers when using an
> external crystal. Since XTAL1 and XTAL2 will set to the same value,
> update the binding to support a single property called
> xtal-load-femtofarads.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
> ---
> V2: No Change
>
> diff --git a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
> index 2ac1131fd922..c268debe5b8d 100644
> --- a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
> +++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
> @@ -59,6 +59,12 @@ properties:
> minItems: 1
> maxItems: 2
>
> + idt,xtal-load-femtofarads:
> + $ref: /schemas/types.yaml#/definitions/uint32
"Vendor specific properties having a standard unit suffix don't need a
type." -- Documentation/devicetree/bindings/example-schema.yaml
Overall looks good.
--
Luca
next prev parent reply other threads:[~2021-01-20 16:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 21:21 Adam Ford
2021-01-19 21:21 ` [PATCH V2 2/2] clk: vc5: Add support for optional load capacitance Adam Ford
2021-01-20 16:33 ` Luca Ceresoli
2021-01-20 16:35 ` Luca Ceresoli [this message]
2021-01-20 16:41 ` [PATCH V2 1/2] dt-bindings: clk: versaclock5: Add optional load capacitance property Adam Ford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9dab169a-e551-7ba1-7fe2-d00e80978388@lucaceresoli.net \
--to=luca@lucaceresoli.net \
--cc=aford173@gmail.com \
--cc=aford@beaconembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®