From: Michal Simek <michal.simek@xilinx.com>
To: Greg KH <gregkh@linuxfoundation.org>,
Michal Simek <michal.simek@xilinx.com>
Cc: Zou Wei <zou_wei@huawei.com>, <rajan.vaja@xilinx.com>,
<jolly.shah@xilinx.com>, <tejas.patel@xilinx.com>,
<manish.narani@xilinx.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next v2] firmware: xilinx: Mark pm_api_features_map with static keyword
Date: Wed, 2 Dec 2020 08:31:13 +0100 [thread overview]
Message-ID: <9dbf2dd5-40db-3cbf-4d53-b027435ccbfe@xilinx.com> (raw)
In-Reply-To: <X8a067jdynVt3Lvg@kroah.com>
On 01. 12. 20 22:26, Greg KH wrote:
> On Tue, Dec 01, 2020 at 01:03:59PM +0100, Michal Simek wrote:
>>
>>
>> On 01. 12. 20 12:51, Zou Wei wrote:
>>> Fix the following sparse warning:
>>>
>>> drivers/firmware/xilinx/zynqmp.c:32:1: warning: symbol 'pm_api_features_map' was not declared. Should it be static?
>>>
>>> Signed-off-by: Zou Wei <zou_wei@huawei.com>
>>> ---
>>> drivers/firmware/xilinx/zynqmp.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c
>>> index d08ac82..fd95ede 100644
>>> --- a/drivers/firmware/xilinx/zynqmp.c
>>> +++ b/drivers/firmware/xilinx/zynqmp.c
>>> @@ -29,7 +29,7 @@
>>> #define PM_API_FEATURE_CHECK_MAX_ORDER 7
>>>
>>> static bool feature_check_enabled;
>>> -DEFINE_HASHTABLE(pm_api_features_map, PM_API_FEATURE_CHECK_MAX_ORDER);
>>> +static DEFINE_HASHTABLE(pm_api_features_map, PM_API_FEATURE_CHECK_MAX_ORDER);
>>>
>>> /**
>>> * struct pm_api_feature_data - PM API Feature data
>>>
>>
>> The patch is good but I am missing fixed tag to get it to LTS.
>
> Why is this needed for any stable kernel release? It's a sparse
> warning, no one trips across those in stable kernels...
Ok thanks for explanation.
Applied to zynqmp/soc branch.
Thanks,
Michal
prev parent reply other threads:[~2020-12-02 7:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 11:51 Zou Wei
2020-12-01 12:03 ` Michal Simek
2020-12-01 21:26 ` Greg KH
2020-12-02 7:31 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9dbf2dd5-40db-3cbf-4d53-b027435ccbfe@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=jolly.shah@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manish.narani@xilinx.com \
--cc=rajan.vaja@xilinx.com \
--cc=tejas.patel@xilinx.com \
--cc=zou_wei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome