From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Teddy Engel <engel.teddy@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
oe-kbuild-all@lists.linux.dev, devel@driverdev.osuosl.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v3] staging: rtl8192e: Fix conflicting types error with net_device.
Date: Tue, 25 Jun 2024 22:52:18 +0200 [thread overview]
Message-ID: <9dc47763-1c44-4283-8692-5e7dce14a0e2@gmail.com> (raw)
In-Reply-To: <20240625163334.11117-1-engel.teddy@gmail.com>
On 6/25/24 18:33, Teddy Engel wrote:
> Add a pre-declaration of struct net_device so the compiler is able to
> use rtl_pci.h / rtl_cam.h.
>
> Signed-off-by: Teddy Engel <engel.teddy@gmail.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202406250858.L8rJMHQm-lkp@intel.com/
> Fixes: 7dff0b27d9c8 ("staging: rtl8192e: Remove unnecessary pre-declaration of struct net_device")
> ---
> v3: Replace ad-hoc commit id / subject by expected Fixes tag.
> v2: Add commit id / commit subject under description.
>
> drivers/staging/rtl8192e/rtl8192e/rtl_cam.h | 2 ++
> drivers/staging/rtl8192e/rtl8192e/rtl_pci.h | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_cam.h b/drivers/staging/rtl8192e/rtl8192e/rtl_cam.h
> index 3a5635494385..9deffdf96072 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_cam.h
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_cam.h
> @@ -12,6 +12,8 @@
>
> #include <linux/types.h>
>
> +struct net_device;
> +
> void rtl92e_cam_reset(struct net_device *dev);
> void rtl92e_enable_hw_security_config(struct net_device *dev);
> void rtl92e_set_key(struct net_device *dev, u8 EntryNo, u8 KeyIndex,
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_pci.h b/drivers/staging/rtl8192e/rtl8192e/rtl_pci.h
> index c645775b2150..3e39c4835ac8 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_pci.h
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_pci.h
> @@ -13,6 +13,8 @@
> #include <linux/types.h>
> #include <linux/pci.h>
>
> +struct net_device;
> +
> bool rtl92e_check_adapter(struct pci_dev *pdev, struct net_device *dev);
>
> #endif
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
prev parent reply other threads:[~2024-06-25 20:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 16:33 Teddy Engel
2024-06-25 20:52 ` Philipp Hortmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9dc47763-1c44-4283-8692-5e7dce14a0e2@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=engel.teddy@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®