From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C062DC64EC4 for ; Wed, 8 Mar 2023 11:04:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231406AbjCHLEY (ORCPT ); Wed, 8 Mar 2023 06:04:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231403AbjCHLD2 (ORCPT ); Wed, 8 Mar 2023 06:03:28 -0500 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 121403647E for ; Wed, 8 Mar 2023 03:03:23 -0800 (PST) Received: by mail-lj1-x22d.google.com with SMTP id b10so16223104ljr.0 for ; Wed, 08 Mar 2023 03:03:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678273401; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=c0ktoYXDYataVjP7ajflebW7wQwIQSEUi8W+XgUX6Uc=; b=p0SeZU485J/5Xp6XJ61Iox9/Wcq0Bt5vZZL75ahJLr2WZIeXcG0slSR1NpFgB5zIrr TGtTyvlNjx0U5afGR6Z6p0bt3/opkY4hBK/2yoNNHQ/guwDkh5dXr+8rWcY8dfcUuXo/ tku7mC0+i3SVA9ZlwO4TZ2ZKjlmSYjFOlxs0cOfW2t0Rgdz1+zCbDWBTLVsFa5c1znK2 C2r+hJRu7g2AjLyLMXoHLW7U9zYmpZDI82kWN4TY0UtcvKbUKm+DOclB0W/Efbac60PX o6AerUWByY88lpr6sN9/8WRuTUAIo87YQTfDctYGwzfAY44tjodV7tSFNMc3lU40/m1m GRbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678273401; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=c0ktoYXDYataVjP7ajflebW7wQwIQSEUi8W+XgUX6Uc=; b=uGBNNKcC8+/ksZOoCupi5Ab6r01gLSXSEwLbzY+4px/VfB+ptZ8i50WdKw/zx+bcfH VylcAy57biDp5X7EGwD9RG/7p+PgBSHkjQcuu8PjSvAbk5ujdaYIAfg7Nk1r62+72RaE K0pK2hOSAMsd1PZFAa/eICNJarbVDhW9hm/0vR/Xh04zaoTvc9ZBshXmYpj4+wLoiKcf 2Gm7TITNkOreyrY9LfUIMskWZJyWZ5H86JR4MFzuVJZ1jFnmpGGDcFg0PzJ5bNDkCNmQ PtMs6DbodTdC3m3kRCvKa5NJ+AG3WBwE6/XywpfzLjug+0C7SBZGqFzlUuY/cmZfbV3K ayiQ== X-Gm-Message-State: AO0yUKWEnPlNAX/jrrS9oK56KQQ4oQB14xOZKgFtLFkjDvGP26lOH6Pd elqvxMcrzvCwinaw8LtnG7BVmqRfamWncA1UP9w= X-Google-Smtp-Source: AK7set9Z4ZGOP6Fsh7liszYtVH27S1FUcTMnqPjPIib1BGTpW/anBmkQ+ECe7xGhGTVowgP0g69g1g== X-Received: by 2002:a05:651c:221a:b0:295:b0c6:834c with SMTP id y26-20020a05651c221a00b00295b0c6834cmr6673532ljq.41.1678273401426; Wed, 08 Mar 2023 03:03:21 -0800 (PST) Received: from [192.168.1.101] (abyj16.neoplus.adsl.tpnet.pl. [83.9.29.16]) by smtp.gmail.com with ESMTPSA id r10-20020a2e8e2a000000b002934d555783sm2528022ljk.6.2023.03.08.03.03.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Mar 2023 03:03:21 -0800 (PST) Message-ID: <9dc9814e-22ae-7b89-80cc-dc1d92898a2f@linaro.org> Date: Wed, 8 Mar 2023 12:03:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2 2/2] gpu/drm/panel: Add Lenovo NT36523W BOE panel Content-Language: en-US To: Linus Walleij , Jianhua Lu Cc: Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Neil Armstrong , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, phone-devel@vger.kernel.org References: <20230217-topic-lenovo-panel-v2-0-2e2c64729330@linaro.org> <20230217-topic-lenovo-panel-v2-2-2e2c64729330@linaro.org> From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7.03.2023 23:18, Linus Walleij wrote: > On Tue, Mar 7, 2023 at 2:26 PM Konrad Dybcio wrote: > >> Introduce support for the BOE panel with a NT36523W touch/driver IC >> found on some Lenovo Tab P11 devices. It's a 2000x1200, 24bit RGB >> MIPI DSI panel with integrated DCS-controlled backlight (that expects >> big-endian communication). >> >> Reviewed-by: Neil Armstrong >> Signed-off-by: Konrad Dybcio > > I will think this is some variant of the Novatek NT36523 display > controller packaged up with Lenovo electronics until proven how > wrong I am. > > I will listen to reason if it can be demonstrated that NT36523 and > NT36523W are considerably different and need very different > drivers, but I seriously doubt it. (For reasons see below.) > >> drivers/gpu/drm/panel/panel-lenovo-nt36523w-boe.c | 747 ++++++++++++++++++++++ > > We usually share code with different displays using the > same display controller, so panel-novatek-nt36523.c should > be used as name. > >> +config DRM_PANEL_LENOVO_NT36523W_BOE >> + tristate "Lenovo NT36523W BOE panel" > > Name it after the display controller like the other examples > in the Kconfig, DRM_PANEL_NOVATEK_NT36523 > >> + mipi_dsi_dcs_write_seq(dsi, 0xff, 0x20); >> + mipi_dsi_dcs_write_seq(dsi, 0xfb, 0x01); >> + mipi_dsi_dcs_write_seq(dsi, 0x05, 0xd9); >> + mipi_dsi_dcs_write_seq(dsi, 0x07, 0x78); >> + mipi_dsi_dcs_write_seq(dsi, 0x08, 0x5a); >> + mipi_dsi_dcs_write_seq(dsi, 0x0d, 0x63); >> + mipi_dsi_dcs_write_seq(dsi, 0x0e, 0x91); >> + mipi_dsi_dcs_write_seq(dsi, 0x0f, 0x73); >> + mipi_dsi_dcs_write_seq(dsi, 0x95, 0xeb); >> + mipi_dsi_dcs_write_seq(dsi, 0x96, 0xeb); >> + mipi_dsi_dcs_write_seq(dsi, MIPI_DCS_SET_PARTIAL_ROWS, 0x11); > > I think it looks very similar to Jianhua:s driver: > https://lore.kernel.org/lkml/20230220121258.10727-1-lujianhua000@gmail.com/T/ > > Can't you just add this special magic sequence into > that driver instead? Yeah I'll try doing that. > > Would it help if we merge Jianhua's driver first so you can patch on > top of it? Definitely. Konrad > > Yours, > Linus Walleij