From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F32A2C00A89 for ; Sat, 31 Oct 2020 00:32:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8727D208B6 for ; Sat, 31 Oct 2020 00:32:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725926AbgJaAc5 (ORCPT ); Fri, 30 Oct 2020 20:32:57 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:6672 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725536AbgJaAc4 (ORCPT ); Fri, 30 Oct 2020 20:32:56 -0400 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4CNKs36KJrz15P53; Sat, 31 Oct 2020 08:32:55 +0800 (CST) Received: from [10.136.114.67] (10.136.114.67) by smtp.huawei.com (10.3.19.203) with Microsoft SMTP Server (TLS) id 14.3.487.0; Sat, 31 Oct 2020 08:32:52 +0800 Subject: Re: [f2fs-dev] [PATCH v2] f2fs: move ioctl interface definitions to separated file To: Eric Biggers CC: , , References: <20201030072610.57155-1-yuchao0@huawei.com> <20201030165556.GA1097@sol.localdomain> From: Chao Yu Message-ID: <9dce9d49-fb13-40cd-eb1f-24212a600beb@huawei.com> Date: Sat, 31 Oct 2020 08:32:51 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20201030165556.GA1097@sol.localdomain> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.136.114.67] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/10/31 0:55, Eric Biggers wrote: > On Fri, Oct 30, 2020 at 03:26:10PM +0800, Chao Yu wrote: >> + >> +struct f2fs_gc_range { >> + u32 sync; >> + u64 start; >> + u64 len; >> +}; > > Userspace headers need to use __u32, __u64, etc. instead of u32, u64, etc. Correct. > > Did you try installing this header, and including it in a userspace program? Let me do more test before next version. Thanks, > > - Eric > . >