From: Markus Elfring <Markus.Elfring@web.de>
To: Cindy Lu <lulu@redhat.com>,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, Jason Wang <jasowang@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Mike Christie <michael.christie@oracle.com>,
Nicolas Dichtel <nicolas.dichtel@6wind.com>,
Stefano Garzarella <sgarzare@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v13] vhost: Reintroduces support of kthread API and adds mode selection
Date: Tue, 15 Jul 2025 20:43:45 +0200 [thread overview]
Message-ID: <9dd21a72-9451-4b77-9ab4-d9b31b408e25@web.de> (raw)
In-Reply-To: <20250714071333.59794-2-lulu@redhat.com>
> This patch reintroduces kthread mode for vhost workers and provides
> configuration to select between kthread and task worker.
…
Is there a need to reconsider the relevance once more for the presented
cover letter?
…
> +++ b/drivers/vhost/vhost.c
…
> +static int vhost_attach_task_to_cgroups(struct vhost_worker *worker)
> +{
…
> + vhost_worker_queue(worker, &attach.work);
> +
> + mutex_lock(&worker->mutex);
…
> + worker->attachment_cnt = saved_cnt;
> +
> + mutex_unlock(&worker->mutex);
…
Under which circumstances would you become interested to apply a statement
like “guard(mutex)(&worker->mutex);”?
https://elixir.bootlin.com/linux/v6.16-rc6/source/include/linux/mutex.h#L225
Regards,
Markus
next prev parent reply other threads:[~2025-07-15 18:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 7:12 [PATCH v13 0/1]vhost: Add support of kthread API Cindy Lu
2025-07-14 7:12 ` [PATCH v13 1/1] vhost: Reintroduces support of kthread API and adds mode selection Cindy Lu
2025-07-14 7:54 ` Jason Wang
2025-07-15 18:43 ` Markus Elfring [this message]
2025-07-16 8:50 ` [PATCH v13] " Simon Horman
2025-07-15 15:52 ` [PATCH v13 0/1]vhost: Add support of kthread API Lei Yang
2025-07-16 14:12 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9dd21a72-9451-4b77-9ab4-d9b31b408e25@web.de \
--to=markus.elfring@web.de \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=michael.christie@oracle.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=sgarzare@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®