From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: Dawid Osuchowski <dawid.osuchowski@linux.intel.com>,
Zilin Guan <zilin@seu.edu.cn>
Cc: <andrew+netdev@lunn.ch>, <anthony.l.nguyen@intel.com>,
<davem@davemloft.net>, <edumazet@google.com>,
<intel-wired-lan@lists.osuosl.org>, <jianhao.xu@seu.edu.cn>,
<kuba@kernel.org>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>, <pabeni@redhat.com>
Subject: Re: [PATCH] ixgbe/ipsec: use memzero_explicit() for stack SA structs
Date: Thu, 15 May 2025 11:27:22 +0200 [thread overview]
Message-ID: <9dd26263-54d9-4abb-bb46-d3cb089a9c21@intel.com> (raw)
In-Reply-To: <a5274434-83db-4fa7-b52d-a0ca8dd16a68@linux.intel.com>
On 5/13/25 15:54, Dawid Osuchowski wrote:
> On 2025-05-13 3:31 PM, Zilin Guan wrote:
>> If this change is required, should I submit it as a new standalone patch,
>> or include it in a v2 of the existing patch series?
>
> I think you could include it with the v2, as it touches the same stack
> SA structs (if you decide to reuse memzero_explicit() on them).
>
the general rule is to memzero_explicit() memory that was holding secure
content
--
to have full picture: it is fine to memset() such storage prior to use,
it is also fine to combine related changes in one commit/one series
re stated purpose of the patch:
I see @rsa cleaned in just one exit point of ixgbe_ipsec_add_sa(),
instead of all of them, so v2 seems warranted
next prev parent reply other threads:[~2025-05-15 9:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-12 10:58 Zilin Guan
2025-05-12 12:53 ` Dawid Osuchowski
2025-05-13 12:24 ` Zilin Guan
2025-05-13 13:21 ` Dawid Osuchowski
2025-05-13 13:31 ` Zilin Guan
2025-05-13 13:54 ` Dawid Osuchowski
2025-05-15 9:27 ` Przemek Kitszel [this message]
2025-05-16 15:04 ` Zilin Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9dd26263-54d9-4abb-bb46-d3cb089a9c21@intel.com \
--to=przemyslaw.kitszel@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=dawid.osuchowski@linux.intel.com \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jianhao.xu@seu.edu.cn \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=zilin@seu.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®