From: James Clark <james.clark@arm.com>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
tchen168@asu.edu, Michael Petlan <mpetlan@redhat.com>
Subject: Re: [PATCH v1 2/2] perf parse-events: Improve error location of terms cloned from an event
Date: Wed, 31 Jan 2024 11:49:28 +0000 [thread overview]
Message-ID: <9dd303cb-0455-d8ac-ce0c-f4a8320b787b@arm.com> (raw)
In-Reply-To: <20240131063048.492010-2-irogers@google.com>
On 31/01/2024 06:30, Ian Rogers wrote:
> A PMU event/alias will have a set of format terms that replace it when
> an event is parsed. The location of the terms is their position when
> parsed for the event/alias either from sysfs or json. This location is
> of little use when an event fails to parse as the error will be given
> in terms of the location in the string of events parsed not the json
> or sysfs string. Fix this by making the cloned terms location that of
> the event/alias.
>
> If a cloned term from an event/alias is invalid the bad format is hard
> to determine from the error string. Add the name of the bad format
> into the error string.
>
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> These fixes were inspired by the poor error output in:
> https://lore.kernel.org/linux-perf-users/alpine.LRH.2.20.2401300733310.11354@Diego/
> ---
> tools/perf/util/pmu.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
> index 355f813f960d..437386dedd5c 100644
> --- a/tools/perf/util/pmu.c
> +++ b/tools/perf/util/pmu.c
> @@ -657,7 +657,7 @@ static int pmu_aliases_parse(struct perf_pmu *pmu)
> return 0;
> }
>
> -static int pmu_alias_terms(struct perf_pmu_alias *alias, struct list_head *terms)
> +static int pmu_alias_terms(struct perf_pmu_alias *alias, int err_loc, struct list_head *terms)
> {
> struct parse_events_term *term, *cloned;
> struct parse_events_terms clone_terms;
> @@ -675,6 +675,7 @@ static int pmu_alias_terms(struct perf_pmu_alias *alias, struct list_head *terms
> * which we don't want for implicit terms in aliases.
> */
> cloned->weak = true;
> + cloned->err_term = cloned->err_val = err_loc;
> list_add_tail(&cloned->list, &clone_terms.terms);
> }
> list_splice_init(&clone_terms.terms, terms);
> @@ -1363,8 +1364,8 @@ static int pmu_config_term(const struct perf_pmu *pmu,
>
> parse_events_error__handle(err, term->err_val,
> asprintf(&err_str,
> - "value too big for format, maximum is %llu",
> - (unsigned long long)max_val) < 0
> + "value too big for format (%s), maximum is %llu",
> + format->name, (unsigned long long)max_val) < 0
> ? strdup("value too big for format")
> : err_str,
> NULL);
Hi Ian,
I went to test this, but since b30d4f0b6954 ("perf parse-events:
Additional error reporting") I don't get this size error message
anymore, just a "bad event/PMU not found" type error. I'm not sure if
this is something Arm specific, or you're seeing the same thing?
Before b30d4f0b6954:
$ perf record -e bus_access_rd/long=2
event syntax error: '..ss_rd/long=2/'
\___ value too big for format, maximum
is 1
Initial error:
event syntax error: 'bus_access_rd/long=2/'
\___ Cannot find PMU `bus_access_rd'. Missing
kernel support?
Run 'perf list' for a list of valid events
Usage: perf record [<options>] [<command>]
or: perf record [<options>] -- <command> [<options>]
-e, --event <event> event selector. use 'perf list' to list
available events
After b30d4f0b6954:
$ perf record -e bus_access_rd/long=2
event syntax error: '..ss_rd/long=2/'
\___ Bad event or PMU
Unabled to find PMU or event on a PMU of 'bus_access_rd'
Initial error:
event syntax error: 'bus_access_rd/long=2/'
\___ Cannot find PMU `bus_access_rd'. Missing
kernel support?
Run 'perf list' for a list of valid events
Usage: perf record [<options>] [<command>]
or: perf record [<options>] -- <command> [<options>]
-e, --event <event> event selector. use 'perf list' to list
available events
next prev parent reply other threads:[~2024-01-31 11:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 6:30 [PATCH v1 1/2] perf tsc: Add missing newlines to debug statements Ian Rogers
2024-01-31 6:30 ` [PATCH v1 2/2] perf parse-events: Improve error location of terms cloned from an event Ian Rogers
2024-01-31 11:49 ` James Clark [this message]
2024-01-31 13:35 ` Ian Rogers
2024-01-31 9:42 ` [PATCH v1 1/2] perf tsc: Add missing newlines to debug statements James Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9dd303cb-0455-d8ac-ce0c-f4a8320b787b@arm.com \
--to=james.clark@arm.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=mpetlan@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tchen168@asu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®