From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965180AbcJQLd1 (ORCPT ); Mon, 17 Oct 2016 07:33:27 -0400 Received: from mail-db5eur01on0131.outbound.protection.outlook.com ([104.47.2.131]:22880 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933887AbcJQLdS (ORCPT ); Mon, 17 Oct 2016 07:33:18 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=aryabinin@virtuozzo.com; Subject: Re: [PATCH] kasan: support panic_on_warn To: Dmitry Vyukov , , References: <1476694624-28366-1-git-send-email-dvyukov@google.com> CC: , , From: Andrey Ryabinin Message-ID: <9dd34617-da15-fedf-cdab-03b67aefc8ec@virtuozzo.com> Date: Mon, 17 Oct 2016 11:58:40 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1476694624-28366-1-git-send-email-dvyukov@google.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [195.214.232.10] X-ClientProxiedBy: AM2PR09CA0023.eurprd09.prod.outlook.com (10.161.22.161) To VI1PR0802MB2558.eurprd08.prod.outlook.com (10.172.255.136) X-MS-Office365-Filtering-Correlation-Id: a7d61b7e-de1e-4531-4107-08d3f66bc47b X-Microsoft-Exchange-Diagnostics: 1;VI1PR0802MB2558;2:x5A1gNzT6flytIMo9qjIu2sNlziHrktJscNW/zitIMTYIxRBadSAALWC+EiDbfRlzGrQ1QRyfmdezZ1E55QYAZ86RJWj7diVPjuLxN0XWlrzprGtIspWMQrlasDrZ4MKvjCpjUX350jUqEV14AByLXGivPdxcRKrZ0fVl+WHVLt+uwOmAArwjiaWpDf55y6/YtjUPr/FvygNmawQvm90kw==;3:2miK3p1mH1mbprWOefbDahO+BfZU+MLgdN1FY8lJBRF59q+Yb2jeIp/5kJKj/MfF2Semx+6JgkXCQrdDAXQpRqYdOm/zO931bjkuTLjG8QjAjL6ycdlER4mV9/TjfXlCALFggRxXpj6DFLz2khCAjg==;25:fPnPqbXTUbGdZN79Dn37JJi1KWvlKqZxGeRlqyqnu6LxMm0Tsr+qJSK4yOmPatDcp2kmTBvCBMuyEOta1KMugamFxGEEDHk4lFbu84Us9BbwvYthy1lU1YB3BOa/BHZW95A1NhLbqjR1OUXwgQrUe32r5EYPxk8i6yRA6nb3WN2ZNzMNE4c7yFg9tp29JNmGiRX9nQS6/sIlHsy2BKY6gvJd+AVUfl9JwoFgNHYOcl+vHCYldvLo7G2nOgrGYhH8KT+dDfS9BreUsHs6zRfSULpQLuc0ajyb0lF/JUouPo+7Okf9HMPc1rdeT8dWHU4FDNURaBXMssw3G51zUL1x3ZoFg7KO4SdplILnOTxtq5d+dqzU/tJ7ESEPfM9+gO4+mdnoWewfosa2sqIJ4YZ4/RsGvJZ/rmHwL0ukMpJpf7K2gRFas7oC5yzOLbZY6Xr0 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0802MB2558; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0802MB2558;31:xIfzHWQRcBu+EfGxVXDfYtrbOGWuD2+AXTAURxs7dN0Iboyj7o1ahO1BTgE39YGMgbpbycsEvrhwiRX+WOjZ7BhP+CnjQIToZKf0TOV8ykryvYh3vwR27f2YCGSkjnioEOtv5gxsH+TjaMqZyoQIf2LMooVEpuMNKY+fshgq/JIgWHyVb2XOVlA3SPPlmurJkkj2B68+twZgxGC9EUuF1dOgRXu0V2IgUsmnOFfGHs14cS+1B/lFY5sHDR6MnGMy;4:C1ckXBDwmbE1VAjef2MeaQarXtj+A8WRwuBL8ee/0+ztQol2nKX1rvWI5pmIudOnnjGNWcf4dZ5fQIQ8iiqayLCFMrrS14+LxpdtFxtOWFhBPvip6N5VeuXZ+Xm2cYQKOQhP2/gJOHPgKHQ68vV4hMd7lOJEmpJKvgjKIQ0+sL2HEXzGj72lZoTTZEH+P/04YXAusksLqGp+yu4Tkv+2hqvrdeJvIspATcvo7fvtFf6BDMqg9uibxU7XwnWyvipQ2hCp+iGr2ZYxgG2/98Q8UWeKJt+pC1bPkDyD+0kctZqD86vJ+hVqfT2L/w7/pjvblai91SpZ4pp6UV3DsxJqMFd71q/nCWBh+qHeQmiwjDN/w4AhWb4LBVLwE+QnrxQ30+99bhqXTrNvFzRcYboR2A0H1DULQolHEl4y1UX/mUaFF8om24kffxu1xZpLbbBL7UNBTQTXQGqvozLJNwjloY04FzlquLK/vEzoFEt+xjpBHP0N17C8icu1g/f3sSGkNAq0NMCUTUePbvOK5547ske1jtXjvSUvxJI9IXJ/KFQ= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(215639381216008)(9452136761055)(211936372134217); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6043046)(6042046);SRVR:VI1PR0802MB2558;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0802MB2558; X-Forefront-PRVS: 0098BA6C6C X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(377454003)(199003)(24454002)(189002)(65826007)(33646002)(5660300001)(19580405001)(50466002)(106356001)(86362001)(42186005)(83506001)(23746002)(31686004)(68736007)(230700001)(3846002)(305945005)(586003)(7736002)(7846002)(6116002)(5001770100001)(4326007)(97736004)(81166006)(81156014)(189998001)(8676002)(4001350100001)(2906002)(76176999)(54356999)(50986999)(101416001)(92566002)(66066001)(36756003)(2201001)(31696002)(2950100002)(6666003)(77096005)(65806001)(65956001)(105586002)(47776003)(19580395003)(64126003);DIR:OUT;SFP:1102;SCL:1;SRVR:VI1PR0802MB2558;H:[10.30.19.223];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;VI1PR0802MB2558;23:FnwfOnc3BaGBitJKUUKjYNHgMV36Vda5cny?= =?Windows-1252?Q?rPodDBXhVTW9dufz5kk+ryUk7WCAYXR8VpkF1lMh78CMJaJwWz22MTAM?= =?Windows-1252?Q?wxOsvlnMDxqy5+m5Lsd6J8T87TuOoFPbjIlnZBGQH0nHAy8+XEh/S6Km?= =?Windows-1252?Q?ufevULt9WD8h9kokBp1lC1kD8o3fj0GyvRNkYev4GLNbo8eG4zmkORO9?= =?Windows-1252?Q?0cS6MRwFJq7Srt76UwF0fxjbJEKDlIFoJMyA8UJzb3gWGJJTq3qoosEH?= =?Windows-1252?Q?JgOVTJz5xGszjrqOB3vH1DPJFaD7t6KkvZseA6qhc8pzUjbsmlrAhswe?= =?Windows-1252?Q?YnTHW3YVc2IJGTrjr2jG3ytw9IQQqw3kZLSjSLgdlGJ6PiWDkyeERcwV?= =?Windows-1252?Q?U6z6EPzkK2n9/bd3cIedBtEKHwwFAv97bqFDV83GUqYJAaCceYDJSmDD?= =?Windows-1252?Q?IVwZP96KyjA5WD/QsIhX7qnfRzhhWHTzzVu9UW9WixcRqLcKfMi6tcDP?= =?Windows-1252?Q?6pjksy3tGFm1Md2Uv0ROWPujH7CIMWOzShrOQC2xwrCesoaaTYCoP98A?= =?Windows-1252?Q?ebksltMijXmaI7kl/E8n30OHnaTATULvffi3Vbj4Na0zCxVQIb8cMgfd?= =?Windows-1252?Q?mOilmKFJqKFSCzLI64fRaFAECPws0Bb39iYjduJhIboFFUh8seu4gnTs?= =?Windows-1252?Q?KVVglBZIcaSrf6ZvnVKHvkhWpoZPWCaEPKf82OuqWBkPM6aN9dy8wByd?= =?Windows-1252?Q?5XMk4B0no+R4/8bDghVi8QuClh1SBpC5ZMJRSxq/WfJue9pp/BgNBnsX?= =?Windows-1252?Q?6vYxkZR6G8xyIimHAusB32qyKl0Kx47Zwn8HzlbyHZ+ihkQwFcoNrgY0?= =?Windows-1252?Q?G36WFap4k3yjZ43DiyBxKvDRh/FgZZ9SmnlF+Wwz3r3TRfTIkzSD74PG?= =?Windows-1252?Q?tJm3gxtDdzdTCyXn0meJ+t8eHCvnzKfHUIDTtbytckeuUstLbE8vBx46?= =?Windows-1252?Q?65ezOgJIy7KsbwN+gqkCNYqvaqeSp7cDlFzDyRpil2IrB6Lpp6V7O0ZP?= =?Windows-1252?Q?yri84E7SUvKl+ZBQ2xJXEdpPM5cfgsvKTJV23jsT4VUe8VIC3j3tbHSe?= =?Windows-1252?Q?o+SirpxHTwm6GdnVBz/r10bFI9K0lbPPpkec6zIa6ZwAkP+7w0yT8Fpl?= =?Windows-1252?Q?IrI1V70phBrUCfng/P3OVbe5mb2eZuTAfp2JZAET29mqFDTAyl5OQN2W?= =?Windows-1252?Q?6Woax/UMcDJHtIqzmFkH+dGI9dkdvD71pkxQuOzJhZVTzvDJre3hdKwV?= =?Windows-1252?Q?pT8KIYppvKSWMsnEvRj6unYSx6NiV4IVYnp1/mc6m39yVLMagirfXOCp?= =?Windows-1252?Q?mmQvqz5UhbfbLLBRUjTyptmNUgIoWRewaLBDzIJD9YeyaVTSA6A0xbOY?= =?Windows-1252?Q?nOb5g8XGfsQ3Aw10eJxdw?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR0802MB2558;6:896GTNvuYIq9/wRpEzp1ojQoq58FaqBZxYs1/o7z6cUUrfqkxWpAJayPXpXUSieaZ7sHW5lCjNijxw++/+QCTSK3lTgbexQU5Tn+kFmTfhN1Wkg5Hu+5uGh3J72iepPq4AZgtSZBDJDQ0r3MikgaWADQroKidCC0UyqJpwm5MDX7a0SJcCtLbr8jw7Ty99j+H9zA5C0ee81E8vNup+IloMp1NccCchr2nvv8z/+5ICXhSdtcOkaS30Fk5i5wOjiSMBh/xQX8JwUWJoUyeGs9YNoq9BrA+AemAa/3wcb88VVbZ3/+IcSntV5Dn93YFwXnUXasshFy3wjwPmRIlHOqaQ==;5:32G8jQUFmREdlUDYa55hAlKY9iXA5abc4dhI4E04BqVgFnKORx7LAUVQiafxpLWGgkfno1b9NRDmQ1zgAn4VD+vENxtilXJh+FT2jAVwkzN3WKoSIb+ethZvPv4CdqcmHkkQ4u2y48Mn7sxY88YOwg1DlQHEOr7AN6cSeq+eok4=;24:Krk2V8+/3g2GfZuo/4t8HGw6lNTlwj0vB/KKN2vxQCK9Tmr935rCOdZnzWattmvFfjRe8ZTvIgGejBIZ4AVhq6/TCEJPCg4bmW7CkwE0zUU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;VI1PR0802MB2558;7:osjgte+JgW66UmcP02MxZy8b4CUW3xdbiS7M4u6Cn9qxmbOj7iXtLSL4Wap5Y1duap63pe1lqu6pStWy4VZmJ2E2p9nqMhQQHmzkBnHer1d9W/yjPqV+ufg7ZbciRBeGaWkZKjHucf8xd8ZaHtDXYlX+KI2BwSxYQ0Ai15n2O7ghQKCSVoB2l6ulH+AlGznTP0uI1Bmz4FwVM1jW/rkYFJqn8wbzJT9XDV9+PAcHWCkFdtKuQsuuE77CzUMAualMRT0mvHnURAvOmQDeCfAcpg/ulBCtRm3HP2vYoy6+QY6Z4iqB3ArTk9sdNXkiwRanSH0daZL9YN0F3cFhMccNfijGtahu3Xo0dWzBtpCRzJw=;20:GCmaQPefVk94HNXuy10/M4t5nZ1pWvZ6q8erVXMgCnVuS+E2PvDGe5zWNcwbocRtfMt78LmYGuBreKfPqhFuJ04W8fxHTxfzJM/fWapz8sTUDMS0OKA2poClDbc9nMptdVnPXRoI6aZxgcz0icqeb3WfDts6cXhuYQzXCD8NQe0= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2016 08:58:30.2543 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2558 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/17/2016 11:57 AM, Dmitry Vyukov wrote: > If user sets panic_on_warn, he wants kernel to panic if there is > anything barely wrong with the kernel. KASAN-detected errors > are definitely not less benign than an arbitrary kernel WARNING. > > Panic after KASAN errors if panic_on_warn is set. > > We use this for continuous fuzzing where we want kernel to stop > and reboot on any error. > > Signed-off-by: Dmitry Vyukov > Cc: kasan-dev@googlegroups.com > Cc: Andrey Ryabinin > Cc: Alexander Potapenko > Cc: Andrew Morton > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Acked-by: Andrey Ryabinin > --- > > Changes from v1: > - don't reset panic_on_warn before calling panic() > --- > mm/kasan/report.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mm/kasan/report.c b/mm/kasan/report.c > index 24c1211..0ee8211 100644 > --- a/mm/kasan/report.c > +++ b/mm/kasan/report.c > @@ -133,6 +133,8 @@ static void kasan_end_report(unsigned long *flags) > pr_err("==================================================================\n"); > add_taint(TAINT_BAD_PAGE, LOCKDEP_NOW_UNRELIABLE); > spin_unlock_irqrestore(&report_lock, *flags); > + if (panic_on_warn) > + panic("panic_on_warn set ...\n"); > kasan_enable_current(); > } > >