From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCA6BC77B7A for ; Wed, 24 May 2023 08:20:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240147AbjEXIUh (ORCPT ); Wed, 24 May 2023 04:20:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239978AbjEXIUg (ORCPT ); Wed, 24 May 2023 04:20:36 -0400 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8D77189 for ; Wed, 24 May 2023 01:20:24 -0700 (PDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 1C7A45C02B8; Wed, 24 May 2023 04:20:22 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Wed, 24 May 2023 04:20:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1684916422; x=1685002822; bh=tY Zdd2ag8G3DyUn++y9TtCSdP5cAJ0TR5Ul9fhN2ndw=; b=DQIgslMqP/BQhUqd+t TJ5lyK533g0PXZguW7fgbQbaEZL0TJ6DFtc0ztFW9/a/IPbtrzNHzYuUd8JR+mla 1YAiG8vP20QJnfs3dqAcyoqHPHe4rpqA16INAETgsmF1hmMduNo7rEsBQmWC/gQN o2ok4bed7fLvnqjtX3/8jvusNErESnd6JgLIdbOlYWhjuFOfEQears9rNIm/33fh 8zYdThXmJRmr/e/u5YEVPR2ESWnKuwRMl3JCGYLrCsZMSC4CV7aGDRix3N2a9qGZ DHIHYDNcVwMnW7+oV1XF4xesNa2Fbx451/JOPtk7/sAoKI1hmZn5ssmo8UYZjm1i 8HMQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1684916422; x=1685002822; bh=tYZdd2ag8G3Dy Un++y9TtCSdP5cAJ0TR5Ul9fhN2ndw=; b=MVYQVZPlyWk4dXzXs3bMzLh61TsRG 0zqO/4LPg+/xnt/ZYmpc4dpLa+b0Rq5DF3bNJjro5mF1G9a6wg6mrSPBZuoCgDgC YPgT6qjjKtlzUX0DtvDfH3MG0Sgdg63WknBag7Apfq3JQT4yY/SMIPR6D0db70Wi KElTSVJojg0qSn0Qpf5A6Zn+qLZe2INR41OtsyVaPUEhhfs5nvrNE55czpGpHwJg 4ba/loCsxOaisZ1HO7/FXyriNne2K0HZZz7Lvmqg0jx/B0hqRDCIwVt9GBepRLll EEKemLuCquy0JFi9lp+L4/bTgEWNUXUVap2mR0oUNE2OikbW4zcOga/tQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeejhedgtdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 35350B60089; Wed, 24 May 2023 04:20:21 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-441-ga3ab13cd6d-fm-20230517.001-ga3ab13cd Mime-Version: 1.0 Message-Id: <9dd597c5-1abc-4a25-a1cd-d7488d9d5b33@app.fastmail.com> In-Reply-To: <2e5e627e-9f7e-ae63-05a3-d2b55e0703ba@oracle.com> References: <20230519092905.3828633-1-arnd@kernel.org> <35c82bbd-4c33-05da-1252-6eeec946ea22@oracle.com> <418f75d5-5acb-4eba-96a5-5f9ec7f963a6@app.fastmail.com> <2e5e627e-9f7e-ae63-05a3-d2b55e0703ba@oracle.com> Date: Wed, 24 May 2023 10:20:00 +0200 From: "Arnd Bergmann" To: "Boris Ostrovsky" , "Arnd Bergmann" , "Juergen Gross" , "Thomas Gleixner" , "Ingo Molnar" , "Borislav Petkov" , "Dave Hansen" , x86@kernel.org, "Stefano Stabellini" Cc: "H. Peter Anvin" , "Oleksandr Tyshchenko" , "Peter Zijlstra" , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [v2] x86: xen: add missing prototypes Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 24, 2023, at 01:09, Boris Ostrovsky wrote: > On 5/23/23 4:37 PM, Arnd Bergmann wrote: >> On Sat, May 20, 2023, at 00:24, Boris Ostrovsky wrote: >>> On 5/19/23 5:28 AM, Arnd Bergmann wrote: >> >> Not sure if there is much point for the second one, since >> it's only called from assembler, so the #else path is >> never seen, but I can do that for consistency if you >> like. >> >> I generally prefer to avoid the extra #if checks >> when there is no strict need for an empty stub. > > Do we need the empty stubs? Neither of these should be referenced if > !SMP (or more precisely if !CONFIG_XEN_PV_SMP) We don't need the prototypes at all for building, they are only there to avoid the missing-prototype warning! I added the stubs in v3 because you asked for an #ifdef, and having an #ifdef without an else clause seemed even weirder: that would only add complexity for something that is already unused while making it harder to maintain or use if an actual user comes up. I'll let someone else figure out what you actually want here. Arnd