From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3681DC63777 for ; Fri, 20 Nov 2020 17:27:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B93F62245F for ; Fri, 20 Nov 2020 17:27:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ILm8VrqY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728674AbgKTR1l (ORCPT ); Fri, 20 Nov 2020 12:27:41 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:56601 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728370AbgKTR1l (ORCPT ); Fri, 20 Nov 2020 12:27:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605893259; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nBlEgbLZs7AvDq7L3CpN4OLqF8+f4MmKhyEP6BHda2g=; b=ILm8VrqYokotidFnr3BJ4cNZdt/7RzKiPu56qleh1uV+J8O1NDHfON+ipfNIKOpS6k+qhZ STP2GJvjFlvaaX+rQ397CARipEnoIzLGgZnlCqIr+/cxXHwiRVx2+MTnCE2TEx9iMh36oI CB2z8dxszd6lnl65JqZHWxntW86j0+0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-270-YRnh0r55NoO0Om4HkkJWNg-1; Fri, 20 Nov 2020 12:27:35 -0500 X-MC-Unique: YRnh0r55NoO0Om4HkkJWNg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 931B58145E5; Fri, 20 Nov 2020 17:27:34 +0000 (UTC) Received: from llong.remote.csb (ovpn-118-157.rdu2.redhat.com [10.10.118.157]) by smtp.corp.redhat.com (Postfix) with ESMTP id 56A2C60853; Fri, 20 Nov 2020 17:27:33 +0000 (UTC) Subject: Re: [PATCH 2/5] locking/rwsem: Prevent potential lock starvation To: Peter Zijlstra Cc: Ingo Molnar , Will Deacon , linux-kernel@vger.kernel.org, Davidlohr Bueso , Phil Auld References: <20201118030429.23017-1-longman@redhat.com> <20201118030429.23017-3-longman@redhat.com> <20201120144438.GG3040@hirez.programming.kicks-ass.net> From: Waiman Long Organization: Red Hat Message-ID: <9de07371-b479-8e05-c810-6f7a12918919@redhat.com> Date: Fri, 20 Nov 2020 12:27:32 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201120144438.GG3040@hirez.programming.kicks-ass.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/20/20 9:44 AM, Peter Zijlstra wrote: > On Tue, Nov 17, 2020 at 10:04:26PM -0500, Waiman Long wrote: >> + long rcnt = (count >> RWSEM_READER_SHIFT); /* Reader count */ > I'm thinking you can do without that comment, the variable name is clear > enough. > Sure. Thanks, Longman