From: Markus Elfring <Markus.Elfring@web.de>
To: linux-wireless@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org, Chen Ni <nichen@iscas.ac.cn>,
Kalle Valo <kvalo@kernel.org>
Subject: [PATCH v2] wifi: rsi: Use usb_endpoint_xfer_bulk() rather than duplicating its implementation
Date: Wed, 25 Jun 2025 08:55:17 +0200 [thread overview]
Message-ID: <9de5fb9e-bbe9-4f27-9370-1fff9e3c9fe2@web.de> (raw)
In-Reply-To: <d04019cd-f782-4d81-97ce-3d70946e5c54@web.de>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 25 Jun 2025 08:46:02 +0200
Reuse existing functionality from usb_endpoint_xfer_bulk() instead of
keeping duplicate source code.
The source code was transformed by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
V2:
Another change possibility was taken better into account for the USB API.
drivers/net/wireless/rsi/rsi_91x_usb.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/rsi/rsi_91x_usb.c b/drivers/net/wireless/rsi/rsi_91x_usb.c
index dccc139cabb2..31707b543c19 100644
--- a/drivers/net/wireless/rsi/rsi_91x_usb.c
+++ b/drivers/net/wireless/rsi/rsi_91x_usb.c
@@ -122,8 +122,7 @@ static int rsi_find_bulk_in_and_out_endpoints(struct usb_interface *interface,
if (!dev->bulkin_endpoint_addr[bin_found] &&
(endpoint->bEndpointAddress & USB_DIR_IN) &&
- ((endpoint->bmAttributes & USB_ENDPOINT_XFERTYPE_MASK) ==
- USB_ENDPOINT_XFER_BULK)) {
+ usb_endpoint_xfer_bulk(endpoint)) {
buffer_size = endpoint->wMaxPacketSize;
dev->bulkin_size[bin_found] = buffer_size;
dev->bulkin_endpoint_addr[bin_found] =
@@ -133,8 +132,7 @@ static int rsi_find_bulk_in_and_out_endpoints(struct usb_interface *interface,
if (!dev->bulkout_endpoint_addr[bout_found] &&
!(endpoint->bEndpointAddress & USB_DIR_IN) &&
- ((endpoint->bmAttributes & USB_ENDPOINT_XFERTYPE_MASK) ==
- USB_ENDPOINT_XFER_BULK)) {
+ usb_endpoint_xfer_bulk(endpoint)) {
buffer_size = endpoint->wMaxPacketSize;
dev->bulkout_endpoint_addr[bout_found] =
endpoint->bEndpointAddress;
--
2.50.0
next prev parent reply other threads:[~2025-06-25 6:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-24 16:50 [PATCH] wifi: rsi: Use usb_endpoint_type() " Markus Elfring
2025-06-25 6:55 ` Markus Elfring [this message]
2025-06-25 7:17 ` [PATCH v2] wifi: rsi: Use usb_endpoint_xfer_bulk() " Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9de5fb9e-bbe9-4f27-9370-1fff9e3c9fe2@web.de \
--to=markus.elfring@web.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nichen@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®