From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3824E322B6F for ; Fri, 6 Feb 2026 16:15:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770394517; cv=none; b=ntnx/ns+XictHdGXUOprHzcsAynoxqXtLxpw5REfvAbay2vWiZU+ZTCWGd/QIRyBxc3ezulZkSgrDgFwQ/KK2x99a3F91WUR6RAojkGdhGL5Uc3qHYUMx5gpt27aqAiYXi1RxPWoWdHO7HPifg11oscgIbfLb/ZgvnNtxq58w80= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770394517; c=relaxed/simple; bh=PgHh9sO6g1i1ICu0i5WHmFr2GjxMXiWnxdDbOdqYd2M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=duh+dmABKnWDJHCnJcDpUaz71JMsEvZnkNjC7JWN4T0hqFGI9MXt6ztxcH53dsCRuAsu04dHmKG0/lhd+dzMGUAM2He8Dc9M5SRx7JkvmyWziwK96KYoHab6BPmsm8enu2jn04oG5mNGsbqF9zgvw9lR1GxUXGnnGQ40em5e95Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=y+/mUjRz; arc=none smtp.client-ip=209.85.167.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="y+/mUjRz" Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-59dd34bd84fso251024e87.2 for ; Fri, 06 Feb 2026 08:15:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770394515; x=1770999315; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=j7YltPymBDZDAXQzrrunk/e6Y1HtLsHo+KDRbCcly/E=; b=y+/mUjRzihDm2JixE9p6rIb3fSOUWLS8I9ZP1yfw4volOB7qr/iIg9DcfjpoqVrOOY l493LZzuOq30hGV4lZOTWgXvcSpaDjJq3yKBxzUwu86qPouYsVX1x+CbLaYeAnJ/fvT1 n7IbLT7s6zSuRFCcScHtVOsMXsVu83M0H6vgNqmloSVPN1UpptdM+A3mLN1z3pv8LvMT 7j8rjkw9ECOuHjZaM1FofiNDVgf2iYNs8+pxbs1/9tw3GT6o2b9VKgnKYZChOzbYF97b Pgg3glu5WIT8xCepjlfJPom5TXcldwixBbcWs2YWa6axr8H6EYd4nkTilWBSep+ph0NZ eDng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770394515; x=1770999315; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=j7YltPymBDZDAXQzrrunk/e6Y1HtLsHo+KDRbCcly/E=; b=YgeNQwK685a4fkm4xF2wq4bTulOpOdgtqEtgjkjEoO77GdIkRN9mav8Ss/vZrx0cN7 y+V8nleT4ax7aRl3cywsEHTMubq5wdBLRRQVBA+jV99ZUFfHea8tXseHgX8qSfZVQj2C FsWzYGhjrqym9Y/SDWWaA9GVxQtSmYT087JQeCTmnugpHLDSRXvx9ooifjF01cUQOowa zsP3ONq7J7KRvxmwfvoRSKzTPogGp3IrBrPNefrhqvAFQ/qX3NwmI6bg9A48BwtfCmPr c4EEd3dhBmSqMlJEH7sj2cLIWZzbQ879XQuZFutL4qTeh36rcB0NpW1PcmxLQpZLj53O GFzw== X-Forwarded-Encrypted: i=1; AJvYcCW9Y0r1DUskab213dPnekEPttGIhNie6LkgotB+x/tzI5l1T8x8S1Mn+sVoqsnRwOxj7ijz6XzvQJlgEH0=@vger.kernel.org X-Gm-Message-State: AOJu0YzZjbge8R1gkBUrKUWkjPCkRIl86phuimFNCf70f6VKc8KNPvVn xtkUpvHn7pQ8i/6qgpKYJS1ZzunApOeJNwXDlgLBvo6XggL3P1RPKNnBkyql0gxs9vM= X-Gm-Gg: AZuq6aL0TPqF/2DZ90S8I5wlikXWBaURh4urADhkZruVxxjZ0pSUnccIo+ERgbNnNqC cZelZqA04fdLcS3CjIYOW2whs8cHVICJVlER+pJBLDZCJYZ3M2PdkiiyOXBN+5PgEjf0KCneOof 1FbZP/MpKhgmOwiqdKZr0P69FAsaH2q55zlN7mj5Nss1+esvKD4z9eHotgTFDs1zAXFAK2S4HBv RPjcwS8I91ML10hp0sCL90OXzwlpvZ2VVf7ONKoXkPYKMO3Cpt0atfJvvQYiYk4kj73miHsQ8++ rxyUCvEEqvMzedhi7Vmn58cDA7IHR7siJgEWf6UZGKgFYDrpHswqdI9lr4D77i/l9gZ2pZQXBvG UuLldzIndhAP45zl+k38QNsbvi3wJ1QitFDvUqHRZVDB2hXledH1Sa0hmTbnuMKsHAFW++tPw2s PhprWKxfk7aU31oN0u4QKxyJnuXsUhJ5VROnsJVCf5TnTC+1GxzSoreVBzrVFRusrLNQ== X-Received: by 2002:a05:6512:24d7:10b0:59e:3e87:1a with SMTP id 2adb3069b0e04-59e4518da53mr385299e87.7.1770394515297; Fri, 06 Feb 2026 08:15:15 -0800 (PST) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59e44cf713fsm698812e87.1.2026.02.06.08.15.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Feb 2026 08:15:14 -0800 (PST) Message-ID: <9de74828-85bf-408c-8f64-2a8694f71563@linaro.org> Date: Fri, 6 Feb 2026 18:15:01 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 4/5] arm64: dts: qcom: monaco-evk: Add camera AVDD regulators To: Nihal Kumar Gupta , bryan.odonoghue@linaro.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, hverkuil-cisco@xs4all.nl, loic.poulain@oss.qualcomm.com, rfoss@kernel.org, andi.shyti@kernel.org, linux-i2c@vger.kernel.org, cros-qcom-dts-watchers@chromium.org Cc: quic_svankada@quicinc.com, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio References: <20260121183142.1867199-1-quic_nihalkum@quicinc.com> <20260121183142.1867199-5-quic_nihalkum@quicinc.com> From: Vladimir Zapolskiy In-Reply-To: <20260121183142.1867199-5-quic_nihalkum@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/21/26 20:31, Nihal Kumar Gupta wrote: > Define three fixed regulators for camera AVDD rails, each gpio-controlled > with corresponding pinctrl definitions. > > Signed-off-by: Nihal Kumar Gupta > Signed-off-by: Vikram Sharma > Reviewed-by: Konrad Dybcio > --- > arch/arm64/boot/dts/qcom/monaco-evk.dts | 51 +++++++++++++++++++++++++ > 1 file changed, 51 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/monaco-evk.dts b/arch/arm64/boot/dts/qcom/monaco-evk.dts > index 565418b86b2a..65c1b49c6dfb 100644 > --- a/arch/arm64/boot/dts/qcom/monaco-evk.dts > +++ b/arch/arm64/boot/dts/qcom/monaco-evk.dts > @@ -77,6 +77,36 @@ platform { > }; > }; > }; > + > + vreg_cam0_2p8: vreg-cam0-2p8 { > + compatible = "regulator-fixed"; > + regulator-name = "vreg_cam0_2p8"; > + startup-delay-us = <10000>; > + enable-active-high; > + gpio = <&tlmm 73 GPIO_ACTIVE_HIGH>; > + pinctrl-0 = <&cam0_avdd_2v8_en_default>; > + pinctrl-names = "default"; > + }; > + > + vreg_cam1_2p8: vreg-cam1-2p8 { > + compatible = "regulator-fixed"; > + regulator-name = "vreg_cam1_2p8"; > + startup-delay-us = <10000>; > + enable-active-high; > + gpio = <&tlmm 74 GPIO_ACTIVE_HIGH>; > + pinctrl-0 = <&cam1_avdd_2v8_en_default>; > + pinctrl-names = "default"; > + }; > + > + vreg_cam2_2p8: vreg-cam2-2p8 { > + compatible = "regulator-fixed"; > + regulator-name = "vreg_cam2_2p8"; > + startup-delay-us = <10000>; > + enable-active-high; > + gpio = <&tlmm 75 GPIO_ACTIVE_HIGH>; > + pinctrl-0 = <&cam2_avdd_2v8_en_default>; > + pinctrl-names = "default"; Since voltage level is known for all three regulators, why not to add regulator-min-microvolt = <2800000>; regulator-max-microvolt = <2800000>; properties? > + } > }; > > &apps_rsc { > @@ -564,6 +594,27 @@ perst-pins { > }; > }; > > + cam0_avdd_2v8_en_default: cam0-avdd-2v8-en-state { > + pins = "gpio73"; > + function = "gpio"; > + drive-strength = <2>; > + bias-disable; > + }; > + > + cam1_avdd_2v8_en_default: cam1-avdd-2v8-en-state { > + pins = "gpio74"; > + function = "gpio"; > + drive-strength = <2>; > + bias-disable; > + }; > + > + cam2_avdd_2v8_en_default: cam2-avdd-2v8-en-state { > + pins = "gpio75"; > + function = "gpio"; > + drive-strength = <2>; > + bias-disable; > + }; > + > qup_i2c15_default: qup-i2c15-state { > pins = "gpio91", "gpio92"; > function = "qup1_se7"; -- Best wishes, Vladimir