From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07177C433EF for ; Thu, 21 Jul 2022 23:38:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233456AbiGUXiT (ORCPT ); Thu, 21 Jul 2022 19:38:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229539AbiGUXiS (ORCPT ); Thu, 21 Jul 2022 19:38:18 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84F338EED7 for ; Thu, 21 Jul 2022 16:38:17 -0700 (PDT) Received: from [192.168.1.90] (unknown [188.24.146.105]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by madras.collabora.co.uk (Postfix) with ESMTPSA id 792D16601AB4; Fri, 22 Jul 2022 00:38:15 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1658446696; bh=Wii0X0eT8PnAsozKQztMmBols/zMOZtKguDeQ2nyllY=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=lmyDiMZmBnNmE1DIdTNcLhiap2BBVnK/LiL/y+8317ALyu3DOgNBMDtE+DHzVlHrR 4nZ2wH8nVvvOJ0QO7i07cqQ3eJ9EPiDETz+WHbbLIrVF279hCS/Ejja5x9PFqn1a/p AEJkhX9d4njUZixXpElEN/ma3r3MHfzIsP2MHghHpHQoTl+dNU579kVk8Z6rKwRxa2 VUDkIB+IfkPwFAmz4Y7NCQQHeJJB5916/VKBRR0exsAmkyqy7+f/LsKSlmvOaxtqZB 4I02QD2qzXAx+IcpejgGxSioVcCSjS6RbJjx7up13JbwmGSOf3VzIRq0Q9i62mO9xN DplOSSe68HxSA== Message-ID: <9def537b-81ec-c7d8-1e9e-1eb11fc52142@collabora.com> Date: Fri, 22 Jul 2022 02:38:12 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] ASoC: cs35l41: Set the new legacy DAI naming flag Content-Language: en-US From: Cristian Ciocaltea To: Charles Keepax Cc: James Schulman , David Rhodes , Lucas Tanure , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, kernel@collabora.com References: <20220721121454.1378945-1-cristian.ciocaltea@collabora.com> <20220721131928.GD92394@ediswmail.ad.cirrus.com> <0f413cf5-fadc-6fe8-cadc-2c9526d4a2e2@collabora.com> In-Reply-To: <0f413cf5-fadc-6fe8-cadc-2c9526d4a2e2@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/21/22 17:54, Cristian Ciocaltea wrote: > Hi Charles, > > On 7/21/22 16:19, Charles Keepax wrote: >> On Thu, Jul 21, 2022 at 03:14:54PM +0300, Cristian Ciocaltea wrote: >>> Unlike most CODEC drivers, the CS35L41 driver did not have the >>> non_legacy_dai_naming set, meaning it uses the legacy naming. >>> >>> The recent migration to the new legacy DAI naming style has broken >>> driver functionality because it is now expected to set the new legacy >>> DAI naming flag in order to instruct the core subsystem to use the >>> legacy name format on DAI registration. >>> >>> Let's fix this by setting the legacy_dai_naming flag accordingly. >>> >>> Fixes: bc949a3b4af3 ("ASoC: core: Switch core to new DAI naming flag") >>> Signed-off-by: Cristian Ciocaltea >>> --- >> >> It is really not intended for any CODECs to be using the legacy >> DAI naming, it was only intended for platform side components. >> Would be good if you had some details on the affected system and >> if that could be updated to use the non legacy DAI naming? > > I'm currently testing this on Valve's Steam Deck. Let me also check what > would be the required changes in order to switch to using a non-legacy > DAI naming. I have just submitted a (proper) fix: https://lore.kernel.org/all/20220721233227.1459374-1-cristian.ciocaltea@collabora.com/ Thanks, Cristian >> Thanks, >> Charles >