From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756380AbaCNVIi (ORCPT ); Fri, 14 Mar 2014 17:08:38 -0400 Received: from mail-bl2lp0205.outbound.protection.outlook.com ([207.46.163.205]:9159 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754419AbaCNVIh convert rfc822-to-8bit (ORCPT ); Fri, 14 Mar 2014 17:08:37 -0400 From: "suresh.gupta@freescale.com" To: "balbi@ti.com" CC: "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] usb: gadget: fsl: Set dma_ops for FSL USB Gadget Device Thread-Topic: [PATCH] usb: gadget: fsl: Set dma_ops for FSL USB Gadget Device Thread-Index: AQHPPpdoN1AVhO3tPEyrxC2czsFTNJrfJEyAgAHo8GA= Date: Fri, 14 Mar 2014 20:53:13 +0000 Message-ID: <9df06ff88cb44b48bf2fce71bdf78e03@BN1PR03MB251.namprd03.prod.outlook.com> References: <1394719632-27101-1-git-send-email-suresh.gupta@freescale.com> <20140313152727.GJ4599@saruman.home> In-Reply-To: <20140313152727.GJ4599@saruman.home> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [192.88.169.1] x-forefront-prvs: 0150F3F97D x-forefront-antispam-report: SFV:NSPM;SFS:(10009001)(6009001)(428001)(189002)(199002)(377454003)(51704005)(24454002)(81542001)(19580405001)(83322001)(87266001)(19580395003)(95666003)(74662001)(31966008)(47446002)(74502001)(87936001)(2656002)(94946001)(97336001)(80976001)(97186001)(4396001)(53806001)(46102001)(54356001)(56776001)(50986001)(47976001)(76482001)(54316002)(49866001)(47736001)(51856001)(33646001)(81342001)(74876001)(77982001)(90146001)(56816005)(59766001)(74316001)(66066001)(92566001)(79102001)(83072002)(85852003)(80022001)(93516002)(85306002)(86362001)(69226001)(93136001)(81686001)(95416001)(94316002)(81816001)(74706001)(65816001)(74366001)(63696002)(20776003)(77096001)(76576001)(76786001)(76796001)(24736002)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN1PR03MB023;H:BN1PR03MB251.namprd03.prod.outlook.com;FPR:B45CF15E.26309CA2.E3D8BB27.914E7A79.20245;MLV:sfv;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, -----Original Message----- From: Felipe Balbi [mailto:balbi@ti.com] Sent: Thursday, March 13, 2014 8:57 PM To: Gupta Suresh-B42813 Cc: balbi@ti.com; gregkh@linuxfoundation.org; linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org; Gupta Suresh-B42813 Subject: Re: [PATCH] usb: gadget: fsl: Set dma_ops for FSL USB Gadget Device Hi, On Thu, Mar 13, 2014 at 07:37:12PM +0530, Suresh Gupta wrote: > From: Suresh Gupta return -ENOLOG > Signed-off-by: Suresh Gupta > --- > drivers/usb/gadget/fsl_udc_core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/gadget/fsl_udc_core.c > b/drivers/usb/gadget/fsl_udc_core.c > index 35b20e6..2a43d9d 100644 > --- a/drivers/usb/gadget/fsl_udc_core.c > +++ b/drivers/usb/gadget/fsl_udc_core.c > @@ -2456,6 +2456,7 @@ static int __init fsl_udc_probe(struct platform_device *pdev) > /* Setup gadget.dev and register with kernel */ > dev_set_name(&udc_controller->gadget.dev, "gadget"); > udc_controller->gadget.dev.of_node = pdev->dev.of_node; > + set_dma_ops(&udc_controller->gadget.dev, > +pdev->dev.archdata.dma_ops); why is the driver doing this ? Why is the driver given knowledge about details on archdata ? Why do you need this at all ? [SuresH] This is due to moving mapping virtual address functions to common "udc-core.c" where for example the dma_map_single expect dma_ops of gadget device. Before we call this function from our file with argument dma_map_single(ep->udc->gadget.dev.parent,..... ---- Thanks SuresH