From: Yunfeng Ye <yeyunfeng@huawei.com>
To: David Laight <David.Laight@ACULAB.COM>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"will@kernel.org" <will@kernel.org>,
"kstewart@linuxfoundation.org" <kstewart@linuxfoundation.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>,
"tglx@linutronix.de" <tglx@linutronix.de>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"wuyun.wu@huawei.com" <wuyun.wu@huawei.com>
Subject: [PATCH V2] arm64: psci: Reduce waiting time of cpu_psci_cpu_kill()
Date: Wed, 9 Oct 2019 12:45:16 +0800 [thread overview]
Message-ID: <9df267db-e647-a81d-16bb-b8bfb06c2624@huawei.com> (raw)
In-Reply-To: <18068756-0f39-6388-3290-cf03746e767d@huawei.com>
If psci_ops.affinity_info() fails, it will sleep 10ms, which will not
take so long in the right case. Use usleep_range() instead of msleep(),
reduce the waiting time, and give a chance to busy wait before sleep.
Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>
---
V1->V2:
- use usleep_range() instead of udelay() after waiting for a while
arch/arm64/kernel/psci.c | 17 +++++++++++++----
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/kernel/psci.c b/arch/arm64/kernel/psci.c
index c9f72b2..99b3122 100644
--- a/arch/arm64/kernel/psci.c
+++ b/arch/arm64/kernel/psci.c
@@ -82,6 +82,7 @@ static void cpu_psci_cpu_die(unsigned int cpu)
static int cpu_psci_cpu_kill(unsigned int cpu)
{
int err, i;
+ unsigned long timeout;
if (!psci_ops.affinity_info)
return 0;
@@ -91,16 +92,24 @@ static int cpu_psci_cpu_kill(unsigned int cpu)
* while it is dying. So, try again a few times.
*/
- for (i = 0; i < 10; i++) {
+ i = 0;
+ timeout = jiffies + msecs_to_jiffies(100);
+ do {
err = psci_ops.affinity_info(cpu_logical_map(cpu), 0);
if (err == PSCI_0_2_AFFINITY_LEVEL_OFF) {
pr_info("CPU%d killed.\n", cpu);
return 0;
}
- msleep(10);
- pr_info("Retrying again to check for CPU kill\n");
- }
+ /* busy-wait max 1ms */
+ if (i++ < 100) {
+ cond_resched();
+ udelay(10);
+ continue;
+ }
+
+ usleep_range(100, 1000);
+ } while (time_before(jiffies, timeout));
pr_warn("CPU%d may not have shut down cleanly (AFFINITY_INFO reports %d)\n",
cpu, err);
--
2.7.4.3
next prev parent reply other threads:[~2019-10-09 4:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-21 11:21 Yunfeng Ye
2019-10-09 4:45 ` Yunfeng Ye [this message]
2019-10-16 15:32 ` Sudeep Holla
2019-10-17 13:26 ` Yunfeng Ye
2019-10-17 13:54 ` Sudeep Holla
2019-10-17 14:24 ` Yunfeng Ye
2019-10-17 14:00 ` David Laight
2019-10-17 14:19 ` Yunfeng Ye
2019-10-17 14:25 ` David Laight
2019-10-15 16:23 ` Will Deacon
2019-10-16 3:22 ` Yunfeng Ye
2019-10-16 10:25 ` Sudeep Holla
2019-10-16 11:29 ` Yunfeng Ye
2019-10-16 15:05 ` Sudeep Holla
2019-10-17 14:08 ` Yunfeng Ye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9df267db-e647-a81d-16bb-b8bfb06c2624@huawei.com \
--to=yeyunfeng@huawei.com \
--cc=David.Laight@ACULAB.COM \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=wuyun.wu@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®