From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74E82369988 for ; Tue, 24 Feb 2026 09:37:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771925835; cv=none; b=Wk7ZZlqEE9DnfLzJ6Yj41zrv2+Mrd9uzU0gQ/uWjrEzoW5GwRlegNgOkTt5ugsHVVazoGrUUNwEl8/jFmEVBCssLrXKzChtwHxht3GGw3XC9ZwSu1QNrvYcVSuL8Dx7f1cayYzmzMVwxEAp8KGQRsup0y8evhZJROEuRv2Pi5sU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771925835; c=relaxed/simple; bh=RKL4mzQXz5RLsGfSnAqrl/BEwlcze7M8/xco1f/asKs=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=bhVShdAn8EdOlxE5ziWEmJcGx017tIjB8K3oVHiOtN+33Rdf9caGXJ9G4owGxj5mmm8hOerhdMUGY1BQbH8L6uX0hmSXlBShNWILab6jb0WhWhos7myc8XoC9GczDz1iihFk8Q6Lp2zDQ/LIuyfdOfGd4l7FlMyv4p+wq1o7a5Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=a+txo72u; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=YzPf1o63; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="a+txo72u"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="YzPf1o63" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771925833; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=RKL4mzQXz5RLsGfSnAqrl/BEwlcze7M8/xco1f/asKs=; b=a+txo72uMCNCWQ094lsb+sigp4ovdFW2Ss8p/G13ghQec2vExUQ/fxHx86MR4WsjFQL1Gm np61/F5urA0rUy5wvl+/8h2XRw6Yz3QYpcuF9e+SpwuNDf8iouCAm4khW/3AyLMxqaKXAx trGh70FNCyPJ+2AYKL2+4hSmz5sO+dI= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-621-6gGaOtH9MIm1H2tn6krhrQ-1; Tue, 24 Feb 2026 04:37:08 -0500 X-MC-Unique: 6gGaOtH9MIm1H2tn6krhrQ-1 X-Mimecast-MFC-AGG-ID: 6gGaOtH9MIm1H2tn6krhrQ_1771925827 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-435ab9ed85dso3433031f8f.1 for ; Tue, 24 Feb 2026 01:37:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1771925827; x=1772530627; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=RKL4mzQXz5RLsGfSnAqrl/BEwlcze7M8/xco1f/asKs=; b=YzPf1o63qUYYuhxLAD4LyuiGvhK9lFFeYsenBVr9kYIMIMrj6IqpHttiNN9g2FrQMJ tBwnlmrq6MNl0FGVxppwzkdkq8yo83+ESUOH7OuFTuc8PSngXPBlA3W+khWdNhAjCVCM OhnI0eZvdU1Elrb62IS55pJHEusot4w3GRVuggrmh88Bn5ang5VFDZAY/Qhpbhn5eCJL sXZsz1DBwHd2OfN2mcWfu3HmgfExh3PrcwPyXqeA0dDBcEmnQw+7McqK/EcSxqXN/fRM lEkfBr5EdnXxvmcU7HMKJ6thMtnBEW4vRekexwasa1roS0mQ4Ls4Yh7W94dzMi/58cOd CQLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771925827; x=1772530627; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RKL4mzQXz5RLsGfSnAqrl/BEwlcze7M8/xco1f/asKs=; b=iWYISR7VChGAu8a3YWhiI4dnAzVHZViYdXwnbrusBZpVN0RtC5+gxTUcDYwZvGaDp3 +jL6p662thwrARbWRiaIN4cBYLHhVdDwYp2oga0QTvjhJLH303Y5+TeIm742rq0QI26a k0w12TLTvIAhVarE/kSzY6UFd+fT71tHfV4lYEOPfeAsCMgHrgJnC5+isCRGnfk+S/NK ZNHzdYY//KVNvHtnKHODCD8kLAzwcFkMgu1wL+pebtWuLJjUvmadUEn5hj2v/8HqwB4g XmNIEjnL7rjTwNWzf7o+DTcnahIKj60Dtht4SuqvIBPaGOGg4YbPJnXVEUZohytEj9Mq jujg== X-Forwarded-Encrypted: i=1; AJvYcCUOEbfLduZYOeAOluCOSbjGwgz26RmYpac71FV4Ku1WTXwvSM+iK8pO+Wo85s+L9tRg+q5fkLaCqa5DOug=@vger.kernel.org X-Gm-Message-State: AOJu0YwTHgtfiM1q5kpv/6QPl1k2Wyn5vd9HtZklTlD5r5KwR9j7oo57 MI8vGrRAWn2BtV5+XQPAmPEYQVYNoZZMz2k2Cg4A+p3GXPtShdU9DnuhH2WPM/l81/9IPhZXKuL mS/yw/3uPv70AW+M5JH8SUQIkKmfUVF+/wuHExhZTyQmyTjGmugSA4ckoCSeSj9T5mQ== X-Gm-Gg: ATEYQzxLAU9kMFt1cxilEZxd2aopSGWHYXl8Q7BESuaES8N25wA4zsdIqv3ZQDPGPhP hgM8OdeU/at93ou9f62J/MlVwsvNTkkd0RLwkuvT/K0Dfj1vE6V7Mdc8LWTUQOhr8BHCcNiWCYG sJI8AJLkIebWCE6H7ovkj7JqSIJscimJJZiVaTnaVT35c8i6bUMLgtTTmFgbO4cUzwSyFHySjh1 iresy+dCF3nvfYiyjoDbyXBbI7X9mK+iwf0ZxDAldtHP9dxI1ukTxTsbzlj1wiU2DbYAxLN6zqT Im3R4/UB1f9UsbYfe5pbqe6aWP1WO1FwwYs58DLTZcgmcDL1WkI1Y1FWiSq5L7OD/hXQgPI2TmH iHNGUlD8QiflCL4/NkdTLyjD4E8EJmwwzbEDgx9bKMgvS13zC1jTPmTrZt49skX0UdRRwjgbKuN 4Z0hgtOjfUS4vsXJg= X-Received: by 2002:a05:6000:615:b0:435:9770:9ecb with SMTP id ffacd0b85a97d-4396f18f812mr22531186f8f.56.1771925827465; Tue, 24 Feb 2026 01:37:07 -0800 (PST) X-Received: by 2002:a05:6000:615:b0:435:9770:9ecb with SMTP id ffacd0b85a97d-4396f18f812mr22531150f8f.56.1771925826966; Tue, 24 Feb 2026 01:37:06 -0800 (PST) Received: from gmonaco-thinkpadt14gen3.rmtit.csb (212-8-243-115.hosted-by-worldstream.net. [212.8.243.115]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43970d401aasm24930067f8f.23.2026.02.24.01.37.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Feb 2026 01:37:06 -0800 (PST) Message-ID: <9df2730b1a1611367c95e91247c1b88531f9b952.camel@redhat.com> Subject: Re: [PATCH v3 07/19] rv/rvgen: fix typos in automata and generator docstring and comments From: Gabriele Monaco To: Wander Lairson Costa Cc: Steven Rostedt , Nam Cao , "open list:RUNTIME VERIFICATION (RV)" , open list Date: Tue, 24 Feb 2026 10:37:05 +0100 In-Reply-To: <20260223162407.147003-8-wander@redhat.com> References: <20260223162407.147003-1-wander@redhat.com> <20260223162407.147003-8-wander@redhat.com> Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0BrZXJuZWwub3JnPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmjKX2MCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfIQuAD+JulczTN6l7oJjyroySU55Fbjdvo52xiYYlMjPG7dCTsBAMFI7dSL5zg98I+8 cXY1J7kyNsY6/dcipqBM4RMaxXsOtCRHYWJyaWVsZSBNb25hY28gPGdtb25hY29AcmVkaGF0LmNvb T6InAQTFgoARAIbAwUJBaOagAULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBMrKEfgLgd0WcK eo9u9KbElYeE3yBQJoymCyAhkBAAoJEO9KbElYeE3yjX4BAJ/ETNnlHn8OjZPT77xGmal9kbT1bC1 7DfrYVISWV2Y1AP9HdAMhWNAvtCtN2S1beYjNybuK6IzWYcFfeOV+OBWRDQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-02-23 at 13:17 -0300, Wander Lairson Costa wrote: > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 # when a transition has more than one lables, they are l= ike > this > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 # when a transition has more than one labels, they are l= ike > this > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 # "local_irq_enable\nhw_local_irq_enable_n" > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 # so split them. > =C2=A0 Missing one little thing: s/labels/label/ I'm going to apply it directly on my tree so you don't need to send a V4 ju= st for this. Thanks, Gabriele > diff --git a/tools/verification/rvgen/rvgen/dot2c.py > b/tools/verification/rvgen/rvgen/dot2c.py > index fa44795adef46..9255cc2153a31 100644 > --- a/tools/verification/rvgen/rvgen/dot2c.py > +++ b/tools/verification/rvgen/rvgen/dot2c.py > @@ -3,7 +3,7 @@ > =C2=A0# > =C2=A0# Copyright (C) 2019-2022 Red Hat, Inc. Daniel Bristot de Oliveira > > =C2=A0# > -# dot2c: parse an automata in dot file digraph format into a C > +# dot2c: parse an automaton in dot file digraph format into a C > =C2=A0# > =C2=A0# This program was written in the development of this paper: > =C2=A0#=C2=A0 de Oliveira, D. B. and Cucinotta, T. and de Oliveira, R. S. > diff --git a/tools/verification/rvgen/rvgen/dot2k.py > b/tools/verification/rvgen/rvgen/dot2k.py > index 47af9f104a829..aedc2a7799b32 100644 > --- a/tools/verification/rvgen/rvgen/dot2k.py > +++ b/tools/verification/rvgen/rvgen/dot2k.py > @@ -167,14 +167,14 @@ class da2k(dot2k): > =C2=A0=C2=A0=C2=A0=C2=A0 def __init__(self, *args, **kwargs): > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 super().__init__(*args, = **kwargs) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if self.is_hybrid_automa= ta(): > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 raise= AutomataError("Detected hybrid automata, use the 'ha' > class") > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 raise= AutomataError("Detected hybrid automaton, use the 'ha' > class") > =C2=A0 > =C2=A0class ha2k(dot2k): > =C2=A0=C2=A0=C2=A0=C2=A0 """Hybrid automata only""" > =C2=A0=C2=A0=C2=A0=C2=A0 def __init__(self, *args, **kwargs): > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 super().__init__(*args, = **kwargs) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if not self.is_hybrid_au= tomata(): > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 raise= AutomataError("Detected deterministic automata, use the > 'da' class") > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 raise= AutomataError("Detected deterministic automaton, use the > 'da' class") > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 self.trace_h =3D self._r= ead_template_file("trace_hybrid.h") > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 self.__parse_constraints= () > =C2=A0 > diff --git a/tools/verification/rvgen/rvgen/generator.py > b/tools/verification/rvgen/rvgen/generator.py > index d932e96dd66d3..988ccdc27fa37 100644 > --- a/tools/verification/rvgen/rvgen/generator.py > +++ b/tools/verification/rvgen/rvgen/generator.py > @@ -3,7 +3,7 @@ > =C2=A0# > =C2=A0# Copyright (C) 2019-2022 Red Hat, Inc. Daniel Bristot de Oliveira > > =C2=A0# > -# Abtract class for generating kernel runtime verification monitors from > specification file > +# Abstract class for generating kernel runtime verification monitors fro= m > specification file > =C2=A0 > =C2=A0import platform > =C2=A0import os