From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32319C433F5 for ; Wed, 27 Apr 2022 14:46:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238582AbiD0Otw (ORCPT ); Wed, 27 Apr 2022 10:49:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238526AbiD0Oto (ORCPT ); Wed, 27 Apr 2022 10:49:44 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 249BF39153 for ; Wed, 27 Apr 2022 07:46:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651070792; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YdEl5gFbNnh3pr0/DmoxHJ2wZUi5cPzRQ6e5jHf14Hs=; b=CoDocGMPw+czgBX8fuuL/fHwpGTVjcmFBCb9bxpkeKUQ4HhKRE+b5wxfEtkmX4jEdYUW5D 71ghVS0WYQdZh9iQhJbYjFvz1lJTuyAhivnX69wWwUsIl1vvm/yKoJHUtV5EvQdAxqrSpE v8Q2rN1crwSaZ0CVwWy6oDY9xEBvqMM= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-373-pLbraYebPaO7E-a_LYIxlw-1; Wed, 27 Apr 2022 10:46:29 -0400 X-MC-Unique: pLbraYebPaO7E-a_LYIxlw-1 Received: by mail-ej1-f71.google.com with SMTP id hp17-20020a1709073e1100b006ef69a535c3so1299011ejc.10 for ; Wed, 27 Apr 2022 07:46:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=YdEl5gFbNnh3pr0/DmoxHJ2wZUi5cPzRQ6e5jHf14Hs=; b=d5jLA61bDyUkcO3fPnVCOgTplU941MgpaZTA7lC+9tqcmvJREWpYy3nh9onvOPJ125 Qmi154UV0YkrDemz199Tm99CHIGVtpd8lr1hq5CcXnDMmyWge+0aXy19nQjjOgDUAKee OWjZP2DsfKTFG5voHK8Xx6oKRSh4CvXtqVKujUWraP+MYlZBIp/CGDGxxrc/HwTrOyGQ +UZB56ysYezyUfYILPXaxRYfsLXn6MSFrgJzAgtDebQRqYIVW8pCuQO+xwu5aoQjKxdF uZLDRKq8fyhjeK5fXmplaYLJ32n9oznNIEsA0zLZSiW3dgWlx/gaub1VPWo1apPqHyEK VXbw== X-Gm-Message-State: AOAM5335HfcqOu1QNhzMVZG/A4zPWBwgfmc30IWhazHKPQXfEc+dgtBJ DwKoqATGwI7F49XVdtzxyk7jxOH0jwlLEHGqVmAEEf1OWkMFZ9CNn4s8G0VH3I/YmN60b+8Zuui AbE25jRPzYVoRuNDR/5eIjveW X-Received: by 2002:a17:907:94c9:b0:6e8:ab67:829e with SMTP id dn9-20020a17090794c900b006e8ab67829emr26309668ejc.313.1651070787938; Wed, 27 Apr 2022 07:46:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxjASHi6OBZZvgVZRJZu1gcVmJ/GgM/O5qUp6TeB4OjWCUhJ1CUpRZy/z4MHGkXZfLGS8B2tw== X-Received: by 2002:a17:907:94c9:b0:6e8:ab67:829e with SMTP id dn9-20020a17090794c900b006e8ab67829emr26309647ejc.313.1651070787722; Wed, 27 Apr 2022 07:46:27 -0700 (PDT) Received: from ?IPV6:2001:1c00:c1e:bf00:d69d:5353:dba5:ee81? (2001-1c00-0c1e-bf00-d69d-5353-dba5-ee81.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:d69d:5353:dba5:ee81]) by smtp.gmail.com with ESMTPSA id p5-20020a1709066a8500b006f3bdf3a2f4sm2142221ejr.105.2022.04.27.07.46.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Apr 2022 07:46:27 -0700 (PDT) Message-ID: <9df369cb-db52-d8be-c244-1f3ec04b063b@redhat.com> Date: Wed, 27 Apr 2022 16:46:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] platform/x86: intel-uncore-freq: Prevent driver loading in guests Content-Language: en-US To: Srinivas Pandruvada , markgross@kernel.org Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Borislav Petkov References: <20220421184154.747721-1-srinivas.pandruvada@linux.intel.com> From: Hans de Goede In-Reply-To: <20220421184154.747721-1-srinivas.pandruvada@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 4/21/22 20:41, Srinivas Pandruvada wrote: > Loading this driver in guests results in unchecked MSR access error for > MSR 0x620. > > There is no use of reading and modifying package/die scoped uncore MSRs > in guests. So check for CPU feature X86_FEATURE_HYPERVISOR to prevent > loading of this driver in guests. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=215870 > Suggested-by: Borislav Petkov > Signed-off-by: Srinivas Pandruvada Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/x86/intel/uncore-frequency/uncore-frequency.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/platform/x86/intel/uncore-frequency/uncore-frequency.c b/drivers/platform/x86/intel/uncore-frequency/uncore-frequency.c > index c61f804dd44e..8f9c571d7257 100644 > --- a/drivers/platform/x86/intel/uncore-frequency/uncore-frequency.c > +++ b/drivers/platform/x86/intel/uncore-frequency/uncore-frequency.c > @@ -212,6 +212,9 @@ static int __init intel_uncore_init(void) > const struct x86_cpu_id *id; > int ret; > > + if (cpu_feature_enabled(X86_FEATURE_HYPERVISOR)) > + return -ENODEV; > + > id = x86_match_cpu(intel_uncore_cpu_ids); > if (!id) > return -ENODEV;