From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751761AbdEQFYs (ORCPT ); Wed, 17 May 2017 01:24:48 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:42258 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751104AbdEQFYq (ORCPT ); Wed, 17 May 2017 01:24:46 -0400 Subject: Re: [kbuild-all] [PATCH v4 2/3] hwmon: (adt7475) temperature smoothing To: Ye Xiaolong , Chris Packham References: <201705161614.nmuA5Qiv%fengguang.wu@intel.com> <247018ef273f4af9bedd77e63417daf0@svr-chch-ex1.atlnz.lc> <20170517030640.GD568@yexl-desktop> <20170517043917.GG568@yexl-desktop> Cc: kbuild test robot , "linux-hwmon@vger.kernel.org" , "jdelvare@suse.com" , "linux-doc@vger.kernel.org" , Jonathan Corbet , "linux-kernel@vger.kernel.org" , "kbuild-all@01.org" From: Guenter Roeck Message-ID: <9dfdd004-a2cd-7aae-ada5-28517665c681@roeck-us.net> Date: Tue, 16 May 2017 22:24:39 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170517043917.GG568@yexl-desktop> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/16/2017 09:39 PM, Ye Xiaolong wrote: > On 05/17, Chris Packham wrote: >> On 17/05/17 15:09, Ye Xiaolong wrote: >>> On 05/16, Chris Packham wrote: >>>> On 16/05/17 20:23, kbuild test robot wrote: >>>>> Hi Chris, >>>>> >>>>> [auto build test ERROR on hwmon/hwmon-next] >>>>> [also build test ERROR on v4.12-rc1 next-20170516] >>>>> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] >>>>> >>>>> url: https://github.com/0day-ci/linux/commits/Chris-Packham/hwmon-adt7475-fan-stall-prevention/20170515-093530 >>>>> base: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next >>>>> config: x86_64-rhel (attached as .config) >>>>> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 >>>>> reproduce: >>>>> # save the attached .config to linux build tree >>>>> make ARCH=x86_64 >>>>> >>>>> All errors (new ones prefixed by >>): >>>>> >>>>> drivers/hwmon/adt7475.c: In function 'set_temp_st': >>>>>>> drivers/hwmon/adt7475.c:622:9: error: implicit declaration of function 'find_closest_descending' [-Werror=implicit-function-declaration] >>>>> val = find_closest_descending(val, ad7475_st_map, >>>>> ^~~~~~~~~~~~~~~~~~~~~~~ >>>>> cc1: some warnings being treated as errors >>>>> >>>>> vim +/find_closest_descending +622 drivers/hwmon/adt7475.c >>>>> >>>>> 616 shift = 4; >>>>> 617 idx = 1; >>>>> 618 break; >>>>> 619 } >>>>> 620 >>>>> 621 if (val > 0) { >>>>> > 622 val = find_closest_descending(val, ad7475_st_map, >>>>> 623 ARRAY_SIZE(ad7475_st_map)); >>>>> 624 val |= 0x8; >>>>> 625 } >>>>> >>>>> --- >>>>> 0-DAY kernel test infrastructure Open Source Technology Center >>>>> https://lists.01.org/pipermail/kbuild-all Intel Corporation >>>>> >>>> >>>> I'm not sure how this is failing. find_closest_descending() is a macro >>>> defined in linux/util_macros.h which is explicitly included in >>>> drivers/hwmon/adt7475.c. Aside from the include guards there's nothing >>>> conditional about it. >>> >>> Hi, >>> >>> 0day bot applied your patchset on top of commit 6eaaea1 ("hwmon: (pmbus) Add client driver for IR35221"), >>> is it wrong or you have some prerequisite patches? > > Thanks for the info, seems we need to improve the kbuild bot by pulling the > latest tree before applying new patches. > No worries. I don't mind the occasional false positive. Better a false positive than a missed bug. Guenter > Thanks, > Xiaolong >>> >> >> Looks like it's missing >> https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git/commit/?h=hwmon-next&id=bbb4dd0ff >> which was part of the series but was applied after v3 so I didn't send >> it out with v4. >