From: "Romli, Khairul Anuar" <khairul.anuar.romli@altera.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Dinh Nguyen <dinguyen@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
"Rao, Mahesh" <mahesh.rao@altera.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Ng, Adrian Ho Yin" <adrian.ho.yin.ng@altera.com>,
"Rabara, Niravkumar Laxmidas" <nirav.rabara@altera.com>
Subject: Re: [PATCH v5 1/2] dt-bindings: firmware: svc: Add IOMMU support for Agilex5
Date: Wed, 5 Nov 2025 08:36:30 +0000 [thread overview]
Message-ID: <9e08b398-f785-47f2-b580-424d08f20e8f@altera.com> (raw)
In-Reply-To: <20251105-giga-ostrich-of-prosperity-410d1c@kuoka>
On 5/11/2025 4:23 pm, Krzysztof Kozlowski wrote:
> On Wed, Nov 05, 2025 at 10:28:01AM +0800, Khairul Anuar Romli wrote:
>> In Agilex5, the TBU (Translation Buffer Unit) can now operate in non-secure
>> mode, enabling Linux to utilize it through the IOMMU framework. This allows
>> improved memory management capabilities in non-secure environments. With
>> Agilex5 lifting this restriction, we are now extending the device tree
>> bindings to support IOMMU for the Agilex5 SVC.
>>
>> Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@altera.com>
>> ---
>> Changes in v5:
>> - Use contains enum instead of const
>> Changes in v4:
>> - Fix syntax / style error.
>> - Refactor code not to use AllOf but instead use if directly.
>
> Why? I would expect there allOf, so you won't re-indent when next
> if:then: clause comes.
>
Sure, I will put back the AllOf so that the future changes that require
different property can be added within that block.
> Anyway, slow down with your patches - one posting per 24h. That's like
> three versions within that timeframe...
Sure, I will slow down to send the next version.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
Can I add this in my next version?
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2025-11-05 8:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-05 2:28 [PATCH v5 0/2] Enable Service layer driver " Khairul Anuar Romli
2025-11-05 2:28 ` [PATCH v5 1/2] dt-bindings: firmware: svc: Add IOMMU support " Khairul Anuar Romli
2025-11-05 8:23 ` Krzysztof Kozlowski
2025-11-05 8:36 ` Romli, Khairul Anuar [this message]
2025-11-05 2:28 ` [PATCH v5 2/2] arm64: dts: intel: Add Agilex5 SVC node with memory region Khairul Anuar Romli
2025-11-05 8:25 ` Krzysztof Kozlowski
2025-11-05 8:55 ` Romli, Khairul Anuar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e08b398-f785-47f2-b580-424d08f20e8f@altera.com \
--to=khairul.anuar.romli@altera.com \
--cc=adrian.ho.yin.ng@altera.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mahesh.rao@altera.com \
--cc=nirav.rabara@altera.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®