From: Jens Axboe <axboe@kernel.dk>
To: Liu Song <liusong@linux.alibaba.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] blk-mq: change bio_set_ioprio to inline
Date: Tue, 30 Aug 2022 18:59:12 -0600 [thread overview]
Message-ID: <9e093f5d-f9fb-1ed6-3598-5d4c46838a09@kernel.dk> (raw)
In-Reply-To: <75f53b8f-30cd-23c3-1602-34d858302751@linux.alibaba.com>
On 8/30/22 6:42 PM, Liu Song wrote:
>
> On 2022/8/30 21:59, Jens Axboe wrote:
>> On 8/30/22 3:45 AM, Liu Song wrote:
>>> From: Liu Song <liusong@linux.alibaba.com>
>>>
>>> Change "bio_set_ioprio" to inline to avoid calling overhead.
>> Let's not try to 2nd guess the compiler here. Most things that are
>> marked inline should not be.
> Agree, I think there is something wrong with the commit log written here,
> it should be expected to reduce the call overhead, bio_set_ioprio seems
> to be appropriate to use inline.
I'm sure it's worth inlining, but did you check if it isn't already?
If it's small I'd fully expect the compiler to inline it already,
without needing to add things to do so.
--
Jens Axboe
next prev parent reply other threads:[~2022-08-31 0:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 9:45 Liu Song
2022-08-30 12:48 ` Chaitanya Kulkarni
2022-08-31 0:48 ` Liu Song
2022-08-30 13:59 ` Jens Axboe
2022-08-31 0:42 ` Liu Song
2022-08-31 0:59 ` Jens Axboe [this message]
2022-08-31 1:22 ` Liu Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e093f5d-f9fb-1ed6-3598-5d4c46838a09@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liusong@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®