From: Dan Murphy <dmurphy@ti.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: <robh+dt@kernel.org>, <jacek.anaszewski@gmail.com>,
<tony@atomide.com>, <lee.jones@linaro.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-leds@vger.kernel.org>
Subject: Re: [PATCH 2/4] ARM: dts: omap4-droid4: Update backlight dt properties
Date: Fri, 8 Mar 2019 15:08:16 -0600 [thread overview]
Message-ID: <9e0a5485-d338-e4e8-5333-cac873158a93@ti.com> (raw)
In-Reply-To: <20190308210649.GC17626@amd>
Pavel
On 3/8/19 3:06 PM, Pavel Machek wrote:
>
>>>> + led@1 {
>>>> + reg = <1>;
>>>> + led-sources = <1>;
>>>> + ti,led-mode = <LM3532_BL_MODE_MANUAL>;
>>>> + label = "keypad";
>>>
>>> I guess best variant would be inputX::backlight here, but that might
>>> be tricky to implement.
>>>
>>
>> Yeah because we don't know what input the keyboard would be on.
>> Unless there are APIs to retrieve that info. I have not looked at the input
>> framework in a while.
>
> Lets just make it "platform::kbd_backlight". *:kbd_backlight is
> already used by quite a few drivers.
>
Sounds fine to me. I will update in v3 as I posted v2 with a lot of deltas
Dan
> Pavel
>
--
------------------
Dan Murphy
next prev parent reply other threads:[~2019-03-08 21:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 22:09 [PATCH 1/4] dt: lm3532: Add lm3532 dt doc and update ti_lmu doc Dan Murphy
2019-03-07 22:09 ` [PATCH 2/4] ARM: dts: omap4-droid4: Update backlight dt properties Dan Murphy
2019-03-08 15:14 ` Pavel Machek
2019-03-08 15:45 ` Dan Murphy
2019-03-08 21:06 ` Pavel Machek
2019-03-08 21:08 ` Dan Murphy [this message]
2019-03-07 22:09 ` [PATCH 3/4] mfd: ti-lmu: Remove LM3532 backlight driver references Dan Murphy
2019-03-07 22:09 ` [PATCH 4/4] leds: lm3532: Introduce the lm3532 LED driver Dan Murphy
2019-03-08 13:28 ` Dan Murphy
2019-03-10 19:49 ` Jacek Anaszewski
2019-03-11 11:36 ` Dan Murphy
2019-03-11 17:22 ` Jacek Anaszewski
2019-03-11 17:24 ` Dan Murphy
2019-03-11 17:30 ` Joe Perches
2019-03-11 17:47 ` Dan Murphy
2019-03-13 15:49 ` Joe Perches
2019-03-21 14:28 [PATCH 1/4] dt: lm3532: Add lm3532 dt doc and update ti_lmu doc Dan Murphy
2019-03-21 14:28 ` [PATCH 2/4] ARM: dts: omap4-droid4: Update backlight dt properties Dan Murphy
2019-04-04 0:03 ` Tony Lindgren
2019-04-04 20:12 ` Jacek Anaszewski
2019-04-04 22:00 ` Tony Lindgren
2019-04-07 18:31 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e0a5485-d338-e4e8-5333-cac873158a93@ti.com \
--to=dmurphy@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®