From: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
To: Andrew LaMarche <andrewjlamarche@gmail.com>,
Johannes Berg <johannes@sipsolutions.net>,
Jeff Johnson <jjohnson@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-wireless@vger.kernel.org, devicetree@vger.kernel.org,
ath12k@lists.infradead.org, linux-kernel@vger.kernel.org,
Ernest Van Hoecke <ernestvanhoecke@gmail.com>
Subject: Re: [PATCH v2 1/2] wifi: ath12k: support calibration-variant from device tree
Date: Mon, 31 Aug 2026 13:09:44 -0700 [thread overview]
Message-ID: <9e22e5ec-70b3-4ec9-ae75-295fc13a23a7@oss.qualcomm.com> (raw)
In-Reply-To: <20260630133001.1426824-1-andrewjlamarche@gmail.com>
On 6/30/2026 6:30 AM, Andrew LaMarche wrote:
> +int ath12k_core_check_dt(struct ath12k_base *ab)
> +{
> + size_t max_len = sizeof(ab->qmi.target.bdf_ext);
> + const char *variant = NULL;
> + struct device_node *node;
> +
> + node = ab->dev->of_node;
> + if (!node)
> + return -ENOENT;
> +
> + of_property_read_string(node, "qcom,calibration-variant",
I've fixed the following in the pending branch:
● checkpatch.pl: 126: CHECK: Alignment should match open parenthesis
> + &variant);
> + if (!variant)
> + return -ENODATA;
> +
> + if (strscpy(ab->qmi.target.bdf_ext, variant, max_len) < 0)
> + ath12k_dbg(ab, ATH12K_DBG_BOOT,
> + "bdf variant string is longer than the buffer can accommodate (variant: %s)\n", variant);
Also:
● checkpatch.pl: 132: WARNING: line length of 121 exceeds 100 columns
● checkpatch.pl: 132: CHECK: Alignment should match open parenthesis
https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git/commit/?id=c9d2d0d1c4a0faaba5f57e3c3350707db9f4f3f3
> +
> + return 0;
> +}
> +
next prev parent reply other threads:[~2026-08-31 20:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-30 13:30 Andrew LaMarche
2026-06-30 13:30 ` [PATCH v2 2/2] dt-bindings: wireless: ath12k: drop qcom,ath12k-calibration-variant Andrew LaMarche
2026-07-01 7:05 ` Krzysztof Kozlowski
2026-07-02 9:32 ` [PATCH v2 1/2] wifi: ath12k: support calibration-variant from device tree Baochen Qiang
2026-08-31 19:41 ` Jeff Johnson
2026-08-31 20:09 ` Jeff Johnson [this message]
2026-09-01 1:52 ` Baochen Qiang
2026-09-01 1:52 ` Baochen Qiang
2026-09-01 12:32 ` Rameshkumar Sundaram
2026-09-03 19:02 ` Jeff Johnson
-- strict thread matches above, loose matches on Subject: below --
2026-06-30 1:14 Andrew LaMarche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e22e5ec-70b3-4ec9-ae75-295fc13a23a7@oss.qualcomm.com \
--to=jeff.johnson@oss.qualcomm.com \
--cc=andrewjlamarche@gmail.com \
--cc=ath12k@lists.infradead.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ernestvanhoecke@gmail.com \
--cc=jjohnson@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®