Re: [PATCH net-next v2] net: lantiq: Use devm_platform_get_and_ioremap_resource()

[Hauke Mehrtens <hauke@hauke-m.de>]

[-- Attachment #1.1.1: Type: text/plain, Size: 1420 bytes --]

On 6/5/21 2:21 PM, Yang Yingliang wrote:
> Use devm_platform_get_and_ioremap_resource() to simplify
> code.
> 
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>

Acked-by: Hauke Mehrtens <hauke@hauke-m.de>

> ---
> v2:
>    remove 'res'
> ---
>   drivers/net/ethernet/lantiq_xrx200.c | 9 +--------
>   1 file changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/drivers/net/ethernet/lantiq_xrx200.c b/drivers/net/ethernet/lantiq_xrx200.c
> index 36dc3e5f6218..27df06ed355e 100644
> --- a/drivers/net/ethernet/lantiq_xrx200.c
> +++ b/drivers/net/ethernet/lantiq_xrx200.c
> @@ -436,7 +436,6 @@ static int xrx200_probe(struct platform_device *pdev)
>   {
>   	struct device *dev = &pdev->dev;
>   	struct device_node *np = dev->of_node;
> -	struct resource *res;
>   	struct xrx200_priv *priv;
>   	struct net_device *net_dev;
>   	int err;
> @@ -456,13 +455,7 @@ static int xrx200_probe(struct platform_device *pdev)
>   	net_dev->max_mtu = XRX200_DMA_DATA_LEN;
>   
>   	/* load the memory ranges */
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	if (!res) {
> -		dev_err(dev, "failed to get resources\n");
> -		return -ENOENT;
> -	}
> -
> -	priv->pmac_reg = devm_ioremap_resource(dev, res);
> +	priv->pmac_reg = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
>   	if (IS_ERR(priv->pmac_reg))
>   		return PTR_ERR(priv->pmac_reg);
>   
> 


[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 10027 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]