mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Aswath Govindraju <a-govindraju@ti.com>
To: Nishanth Menon <nm@ti.com>
Cc: "Lokesh Vutla" <lokeshvutla@ti.com>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	"Kishon Vijay Abraham I" <kishon@ti.com>,
	"Grygorii Strashko" <grygorii.strashko@ti.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Benoît Cousson" <bcousson@baylibre.com>,
	"Tony Lindgren" <tony@atomide.com>,
	"Tero Kristo" <kristo@kernel.org>,
	linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/5] arm64: dts: ti: am65: align ti,pindir-d0-out-d1-in property with dt-shema
Date: Mon, 7 Jun 2021 19:18:29 +0530	[thread overview]
Message-ID: <9e27bd14-e16a-4177-bba8-d5d0e5638f04@ti.com> (raw)
In-Reply-To: <20210607134047.isfuedgjxpubpcb5@ungloved>

Hi Nishanth,

On 07/06/21 7:10 pm, Nishanth Menon wrote:
> On 18:04-20210602, Aswath Govindraju wrote:
>> ti,pindir-d0-out-d1-in property is expected to be of type boolean.
>> Therefore, fix the property accordingly.
>>
>> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> No need for Fixes?
> 

Functionality wise this is not a bug as the driver only checks for the
presence of the property. This is the reason why I did not include fixes.

> Also please split up the patches per maintainer so that we are'nt
> confused on who should pick what etc..
> 

okay. Will be aware of this from next time.

Thanks,
Aswath

>> ---
>>  arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi | 2 +-
>>  arch/arm64/boot/dts/ti/k3-am654-base-board.dts     | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
>> index f4ec9ed52939..23d51b6a9cf2 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
>> @@ -575,7 +575,7 @@
>>  
>>  	#address-cells = <1>;
>>  	#size-cells= <0>;
>> -	ti,pindir-d0-out-d1-in = <1>;
>> +	ti,pindir-d0-out-d1-in;
>>  };
>>  
>>  &tscadc0 {
>> diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
>> index eddb2ffb93ca..1b947e2c2e74 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
>> @@ -299,7 +299,7 @@
>>  	pinctrl-0 = <&main_spi0_pins_default>;
>>  	#address-cells = <1>;
>>  	#size-cells= <0>;
>> -	ti,pindir-d0-out-d1-in = <1>;
>> +	ti,pindir-d0-out-d1-in;
>>  
>>  	flash@0{
>>  		compatible = "jedec,spi-nor";
>> -- 
>> 2.17.1
>>
> 
> 


  reply	other threads:[~2021-06-07 13:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-02 12:34 [PATCH 0/5] dt-bindings: spi: omap-spi: Convert to json-schema Aswath Govindraju
2021-06-02 12:34 ` [PATCH 1/5] ARM: dts: am335x: align ti,pindir-d0-out-d1-in property with dt-shema Aswath Govindraju
2021-06-02 12:34 ` [PATCH 2/5] ARM: dts: am437x: " Aswath Govindraju
2021-06-02 12:34 ` [PATCH 3/5] arm64: dts: ti: am65: " Aswath Govindraju
2021-06-07 13:40   ` Nishanth Menon
2021-06-07 13:48     ` Aswath Govindraju [this message]
2021-06-07 20:24       ` Nishanth Menon
2021-06-02 12:34 ` [PATCH 4/5] arm64: dts: ti: k3-am642-evm: " Aswath Govindraju
2021-06-02 12:34 ` [PATCH 5/5] dt-bindings: spi: omap-spi: Convert to json-schema Aswath Govindraju

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9e27bd14-e16a-4177-bba8-d5d0e5638f04@ti.com \
    --to=a-govindraju@ti.com \
    --cc=bcousson@baylibre.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=grygorii.strashko@ti.com \
    --cc=kishon@ti.com \
    --cc=kristo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=lokeshvutla@ti.com \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=tony@atomide.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®