From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21B0D285417; Wed, 18 Jun 2025 14:27:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750256841; cv=none; b=VKMXoKl+vfbknB6hLmOzyEKcGYY64pKKI51sBPmSZqVzLfLaCHnJuBlrCns440UCEergX9Xa7n89C6w2C1Q8eJDBsdhdVZbeno2YKDNtUNWDqMyNuxGpI8oavxgSsRVt8tZNLAlmTHHU0U7mb7AHZmfKw4B4MTjz2pPTmSMzQgY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750256841; c=relaxed/simple; bh=UN4+r4XZNFrvRooGsjjEHC4utAW+tfGxUnWe7E/kEZg=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type; b=ufna0Hn9EP5US8r7dg3DZQCE34gQsBpFBxnunz75SXTdAmN2iYQ9Pti33jZbdKVXdaPkbsZmpYrBJT1hOmnLFLOsrjUQEUnBWyA8ImDC3CsGjuui1YWqOuXs9UpOPYnLz2x0II3rRawpOGQhZ6ECxaLXZNh9JPg9kdDlvmVUsZc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=RYxBhjev; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="RYxBhjev" Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id CDC8925F7A; Wed, 18 Jun 2025 16:27:18 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id UXPabypd1lfz; Wed, 18 Jun 2025 16:27:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1750256837; bh=UN4+r4XZNFrvRooGsjjEHC4utAW+tfGxUnWe7E/kEZg=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=RYxBhjevfThdOLUFRzhLqaoSxQrAAJJX10YFzY/7DTzTuSQuDgSDAGeL5MqVoDyop yZKq3Z+ZQoZWeKSOTFlvOindsxL74TAJWqexbnZF7H5/f23C2c9dNCU3D3i1O1ueFQ AadAn1wP5JOAYtODFq4KaqZrsI4ykYywXaAgQnT+VOJLZONOh/jfxygQ1nKb6ZL7kO XzASPMLAxr+hlektYmjrN6iy0iXhKgUlpqEvOqhiOvpnA4bNCoy59iizB5WhKomoJ4 VwtwaiqCqkR2rMWNJzxXZNHsu12JRz3WNalpMi3Ny/GZO5RUYt+y3DRnKYxQ+3w4gr 92vQACA6z9Eng== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Wed, 18 Jun 2025 14:27:17 +0000 From: Kaustabh Chakraborty To: Krzysztof Kozlowski Cc: Inki Dae , Jagan Teki , Marek Szyprowski , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Seung-Woo Kim , Kyungmin Park , Alim Akhtar , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH 10/12] dt-bindings: samsung,mipi-dsim: document exynos7870 DSIM compatible In-Reply-To: <5672e2ee-a828-4555-bf78-9d75c58840bd@kernel.org> References: <20250612-exynos7870-dsim-v1-0-1a330bca89df@disroot.org> <20250612-exynos7870-dsim-v1-10-1a330bca89df@disroot.org> <5672e2ee-a828-4555-bf78-9d75c58840bd@kernel.org> Message-ID: <9e2f29d3763ea50b30e5a493551627cd@disroot.org> X-Sender: kauschluss@disroot.org Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On 2025-06-18 10:00, Krzysztof Kozlowski wrote: > On 12/06/2025 17:18, Kaustabh Chakraborty wrote: >> Add compatible string for Exynos7870 DSIM bridge controller. The >> devicetree node requires four clock sources, named: >> - bus_clk >> - phyclk_mipidphy0_bitclkdiv8 >> - phyclk_mipidphy0_rxclkesc0 >> - sclk_mipi >> >> Signed-off-by: Kaustabh Chakraborty >> --- >> .../bindings/display/bridge/samsung,mipi-dsim.yaml | 26 ++++++++++++++++++++++ >> 1 file changed, 26 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml >> index 1acad99f396527192b6853f0096cfb8ae5669e6b..887f3ba1edd24a177a766b1b523d0c197ff1123a 100644 >> --- a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml >> +++ b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml >> @@ -24,6 +24,7 @@ properties: >> - samsung,exynos5410-mipi-dsi >> - samsung,exynos5422-mipi-dsi >> - samsung,exynos5433-mipi-dsi >> + - samsung,exynos7870-mipi-dsi >> - fsl,imx8mm-mipi-dsim >> - fsl,imx8mp-mipi-dsim >> - items: >> @@ -144,6 +145,31 @@ required: >> >> allOf: >> - $ref: ../dsi-controller.yaml# >> + - if: >> + properties: >> + compatible: >> + contains: >> + const: samsung,exynos7870-mipi-dsi >> + >> + then: >> + properties: >> + clocks: >> + minItems: 4 > > maxItems: 4 Will replace. maxItems == minItems implicit if maxItems present and minItems absent. > >> + >> + clock-names: >> + items: >> + - const: bus_clk >> + - const: phyclk_mipidphy0_bitclkdiv8 >> + - const: phyclk_mipidphy0_rxclkesc0 >> + - const: sclk_mipi > > Does any existing driver code actually depends on the names? If not, we > switched in Samsung in general to names matching the input or the > function, not the name of provider. bus, bit (or bitdiv?), rx or esc0, sclk Yeah, Exynos5433 uses it. Code is here [1]. Though, I could get around this if you would like to. Would need to add a few more patches. PS: bitdiv8 should actually be byte. bit clock frequency used in data transmission divided by 8 covers a byte. [1] https://elixir.bootlin.com/linux/v6.16-rc2/source/drivers/gpu/drm/bridge/samsung-dsim.c#L227 > > > Best regards, > Krzysztof