From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B57C1BE87C for ; Thu, 10 Oct 2024 08:18:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728548301; cv=none; b=OkLJJgQ2U4zPizRoagt8gfR/TrpZCUPFp5iwtWUi7mVNc/NWuyyiB3QfOpex3BWA4GakjKpZrQ+DirImCzT2BwaTTlWy+18hItLqCzwPQPwxJ5inUlzkq3SCLtuGs2ytY/0ismwFQ0o/3Lie6/HWG+2+pLRQm53HCdaJgvDTxN8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728548301; c=relaxed/simple; bh=TcJ5+2LaQQs9+ImR2/sH4Y2jPimbS3tuvApgYbaH/no=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=r1UeQFzSji3DRHipWU89sidN68XmfyshO6Cl1jMSXIaFErLrdiuLb6/lFUSK2GTOK1r3i4Pp0INo2wFhEGETnU7OkyvODvcBQhcd/cvZ6H3fiM3KEbmGPiwHrUTfnrSTd6tN2XCpp4touMkR8m45cFUeeOnKlH5n693lQzhD1cE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=CimbOIqv; arc=none smtp.client-ip=209.85.167.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CimbOIqv" Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-53993c115cfso814020e87.2 for ; Thu, 10 Oct 2024 01:18:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1728548297; x=1729153097; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=wZzMUO86Zz4fUOgYhmVPC3Kj9INqhNmxL/uh1WoR0Is=; b=CimbOIqv2jLZ9w/spzrS+lbuRGigGS82NlN+HlM95tpglccubJMBlmmDZ/JeYHCFqW xiHW/Xr5avF70rMSNnEe3x46yWN4rW3kOBsDAdJCfDlyw1Amz4V0Pko7MGgkC69rfD80 tke9/3J5O/ngDbd/UG/KIi5DdcczPzVw+VKTXXdmvRhBeVK84H/t3MHR5ikDqkI5nGCP A2Dze20WHX6rOkyW1c3eh7WBCr+/xRks9P6mt07K474t5FjVHt08Lvi1+C7o1BGSqJ7Z 12TgSs1to8HrcWMIDSE9F9UF9EkOeq3m+hQ8T6bqalqEVBap+PY5/wv3hKMWSeIoGu59 y0Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728548297; x=1729153097; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=wZzMUO86Zz4fUOgYhmVPC3Kj9INqhNmxL/uh1WoR0Is=; b=RpNE5mQxhFYkUXr8c+XGh7ISmGfxKMMtcGoQdvtQyZ0bPikuumGwCsjylKgeb38DAn ZfNjBIa7kZ/UlOwfNzBlI2BjGfyMaWO0rKa5S4+4ltR+vGwM4ZzoiFc+pBFPNSaSnNCK DGkHY9HAuP2QfYk6E3NJBF0az9ZvbzNO0RuFel4ZUwN05f3HI/shZLV7q2ZqR3639t1W 1qf3Tyi0Ek+FBsrj0VlxLUm0AKYLjiGtzwOYSDORDHjCsV4pMnuUSonVqEjPs/lHLOWZ q+kMzicv9+WKul6zFQ1EHN4+m8KHNL9RoIv/rmj5j3svjvNlAURBeRHNYs69ioAxM7O1 8++Q== X-Forwarded-Encrypted: i=1; AJvYcCWFqVGcADCvOVxqBprjsVpbayKs6aizh7gyt0guaodQYjSTh/NX4nBkdP3xrIkwPMvjDy7eOJnQsmjPxn4=@vger.kernel.org X-Gm-Message-State: AOJu0Yx6zKUd+DBdHf2sNSUfIIFmUvc+NhVPlC8XfXnUSQ614XDOrXQE B2qKBwmHfQdksEYSPzM+fpXfu6PLQbbcjuiM/Iw2XQoExPbB8iosUvYI1swhSBDZ1M7hix0YRZi nXLI= X-Google-Smtp-Source: AGHT+IGXdHfmbOwGrStXoJgSkAMDQ50vDCsNy5fzTXsxYb5fCw/hrr+pMzPE0BvRi8UgjlYLEFSfkA== X-Received: by 2002:a5d:5e12:0:b0:37d:4527:ba1c with SMTP id ffacd0b85a97d-37d4527bbd6mr1876589f8f.49.1728547903108; Thu, 10 Oct 2024 01:11:43 -0700 (PDT) Received: from [192.168.7.189] ([212.114.21.58]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37d4b79fd90sm791241f8f.79.2024.10.10.01.11.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Oct 2024 01:11:42 -0700 (PDT) Message-ID: <9e36fd62-0511-4d3f-9f18-9c8188b52e07@linaro.org> Date: Thu, 10 Oct 2024 10:11:41 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH v7 1/3] drm/mipi-dsi: add mipi_dsi_compression_mode_multi To: Dzmitry Sankouski , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241009-starqltechn_integration_upstream-v7-0-9967bd15c7c5@gmail.com> <20241009-starqltechn_integration_upstream-v7-1-9967bd15c7c5@gmail.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20241009-starqltechn_integration_upstream-v7-1-9967bd15c7c5@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 09/10/2024 17:09, Dzmitry Sankouski wrote: > mipi_dsi_compression_mode_multi can help with > error handling. > > Reviewed-by: Neil Armstrong > Signed-off-by: Dzmitry Sankouski > --- > Changes in v7: > - fix kernel doc The v6 patch was already merged to drm-misc-next, like the following ones, cold you send a fixup patch to only fix the kernel doc ? Thanks, Neil > --- > drivers/gpu/drm/drm_mipi_dsi.c | 16 ++++++++++++++++ > include/drm/drm_mipi_dsi.h | 2 ++ > 2 files changed, 18 insertions(+) > > diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c > index 2bc3973d35a1..5e5c5f84daac 100644 > --- a/drivers/gpu/drm/drm_mipi_dsi.c > +++ b/drivers/gpu/drm/drm_mipi_dsi.c > @@ -1520,6 +1520,22 @@ void mipi_dsi_compression_mode_ext_multi(struct mipi_dsi_multi_context *ctx, > } > EXPORT_SYMBOL(mipi_dsi_compression_mode_ext_multi); > > +/** > + * mipi_dsi_compression_mode_multi() - enable/disable DSC on the peripheral > + * @ctx: Context for multiple DSI transactions > + * @enable: Whether to enable or disable the DSC > + * > + * Enable or disable Display Stream Compression on the peripheral using the > + * default Picture Parameter Set and VESA DSC 1.1 algorithm. > + */ > +void mipi_dsi_compression_mode_multi(struct mipi_dsi_multi_context *ctx, > + bool enable) > +{ > + return mipi_dsi_compression_mode_ext_multi(ctx, enable, > + MIPI_DSI_COMPRESSION_DSC, 0); > +} > +EXPORT_SYMBOL(mipi_dsi_compression_mode_multi); > + > /** > * mipi_dsi_dcs_nop_multi() - send DCS NOP packet > * @ctx: Context for multiple DSI transactions > diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h > index f725f8654611..94400a78031f 100644 > --- a/include/drm/drm_mipi_dsi.h > +++ b/include/drm/drm_mipi_dsi.h > @@ -280,6 +280,8 @@ void mipi_dsi_compression_mode_ext_multi(struct mipi_dsi_multi_context *ctx, > bool enable, > enum mipi_dsi_compression_algo algo, > unsigned int pps_selector); > +void mipi_dsi_compression_mode_multi(struct mipi_dsi_multi_context *ctx, > + bool enable); > void mipi_dsi_picture_parameter_set_multi(struct mipi_dsi_multi_context *ctx, > const struct drm_dsc_picture_parameter_set *pps); > >