From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCD24346AC5 for ; Thu, 5 Mar 2026 07:59:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772697585; cv=none; b=LtJNplpGcs7bu1Yvc/y8YAfEcX/jH/N1cpMnFUOCPhrA6TWjDQiNhTVJZtnVZflN5AVxIESnpMW3JTKKKb8Lji2MS4j2xDfmKYT7nkvx+v1RcwfT/OrEmZM0yqtt84l0AJha1yx94X7sMDSODpL1fNVmo+R/25CQmaAFYKeKicQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772697585; c=relaxed/simple; bh=acjX8ZRXKxIh1g9U/ctZCZrkLhEdMfO/0JcbCEv+DBQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UGImErRX61KeT82oMMUis/s0uu4g/HBo97WvbaaZg9f9tNPSoWAAPhT2H8INbZ2wGuHTlw7JG72kX8ztZ2WdXCOkyvr9hrLGvdjzBfj41rWQOQG/Zc5Ums/xzrTkd8VN9AScNR4+vVsHac8iYoLt19zW51At4BZfosTykrkQG2k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=fnKUtjZq; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=cjDiFHWp; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fnKUtjZq"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="cjDiFHWp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772697577; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EA7Rrf5P3Aj91zy1UVwm367bOMnz8VCNbYx+ojgcP34=; b=fnKUtjZqRhjdNbeOj5Ke9q/qF37JJ7tBJTXub3LqWeXNJyzqEle/qUQcn/CuBLiH0MTOYj ZUTH+LaNubGQWTQiE1962oIEGZXnGD+PY2ubAEQDo/LACQAm2dB5HpxDfhk0gSKv2ykJdf CT7usl2MLC38WL09VueCwb44Osna2ek= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-599-pJdC7VRLM2WyHUE2GiRm9Q-1; Thu, 05 Mar 2026 02:59:36 -0500 X-MC-Unique: pJdC7VRLM2WyHUE2GiRm9Q-1 X-Mimecast-MFC-AGG-ID: pJdC7VRLM2WyHUE2GiRm9Q_1772697575 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-439c2a0d821so1798228f8f.1 for ; Wed, 04 Mar 2026 23:59:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1772697575; x=1773302375; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EA7Rrf5P3Aj91zy1UVwm367bOMnz8VCNbYx+ojgcP34=; b=cjDiFHWpK7xUFdA6IPsXDW8HE71FEqFjMY52y/Nh6mvtV/cSiIdeja07MSL8/x8IEw LJMMnhMGa/WLwtQEnWSu/w7pakL2ug5R+/EV+CjmAT4XxHNYnr0KcnM2BFnMLGbMrRXp rLLd2Sox0cDqh4K8XA9jPz5GP8S06sg9uyoWgyI26isD9gHBQnAKXg+hd2pMhMbTarSe 99GwQ3qVoFJj7fEjUSZcGuZXOQGk2H7Zh0aZPugIj2sr/aef2+PBgdULWdWCKi+eSftQ KngKwhn7Eqbb2IhNVKar2ZnqUhdAWQLMKKTChaalJIWZo0UBdhbppLw2H1uhg7iyvUol dIlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772697575; x=1773302375; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EA7Rrf5P3Aj91zy1UVwm367bOMnz8VCNbYx+ojgcP34=; b=ARKU0Qo4sZBRoy436fBaUJDkNqGIMtz9EwXhYOqzeEXEBfitQonf7RM69LFsmOYjq4 MkxzF9+uY0H+1kBTsU+9k7qccoaEyts1sdSrqcTL3WAQcF7QOS4rROD7dvznXvFDmgDB II4PtOIaSXKCTe7cuD+qWun8YIJho0jk6IlhaKhyB1nMtYJlVZ/owqn0vyF3KyTPowcn /LV6fpFkhfiEdwtIwPcLYOd5HRfHPKYqSh0tFK5kCdMVPlAruy2Daf6MKg+1950HtR1m SxXEPqBoI55UkUI7j7Z2srfAawxM5QncTzsz+uPaSsvb8zsPpouCAaeJqPkeUjz1teGO gghw== X-Gm-Message-State: AOJu0YyBnGnmMFsmpqLoVdeK/y3ZZui5g+O26u9LDuL6MhKPGMB2O8qZ NZMwOeyLnO1NeTsc8S+K0sPRq9DxA1CePhsfThQ1OOsq8tPiYBOnnYQJN8VqnW1XXcohFNdVkH/ SrkUyXxQn7iBM58g065NadI6BVUMc7iPLe1IHujJLts8pag+DzjvzcjOXFzFFbsSQog== X-Gm-Gg: ATEYQzwaaeKJbH2Higb3WBeybOlv5FMdHIr7TpAaXdh5hT3IfyVOrB+/Ru9HfCZdELe aRsP3Hxw2Vo8pW5/pbxJOQj/lv6MruPb5/sWTX/98o0b2GsEBcpeSRE2sahjDx05sFCOBuXYP+d NkdYMSS5H3Knd5Ld31aO8GCdY9W+8aGoPL8U6EbjlNCB+E8ha6MPIAFOd9Fxjz/hqBHTse4Sln3 JZoMSP0LLVQvCKNGOrlZGllMmQbcQJOfNbjJ9E88SrMDMhT1gmjROiW+026RgwoE4Bb+RqleJkc eq54B058UF5XfB0HdW0rcO1HSy0qSI4jf87fMkXopOazRGNImGHZ+BF8qcpgIQWOPRzgHXKe5dz WoegeXzuAFkP7Y5ZeiOFQ1zRbAA== X-Received: by 2002:a05:6000:24c3:b0:439:ba57:5023 with SMTP id ffacd0b85a97d-439c7fd377cmr8342932f8f.36.1772697575122; Wed, 04 Mar 2026 23:59:35 -0800 (PST) X-Received: by 2002:a05:6000:24c3:b0:439:ba57:5023 with SMTP id ffacd0b85a97d-439c7fd377cmr8342892f8f.36.1772697574661; Wed, 04 Mar 2026 23:59:34 -0800 (PST) Received: from [192.168.88.32] ([212.105.149.216]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439c6129017sm13041122f8f.31.2026.03.04.23.59.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Mar 2026 23:59:34 -0800 (PST) Message-ID: <9e430669-7930-4902-ab7f-ed0b63def827@redhat.com> Date: Thu, 5 Mar 2026 08:59:33 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 net 1/3] amd-xgbe: fix link status handling in xgbe_rx_adaptation To: Raju Rangoju , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kuba@kernel.org, edumazet@google.com, davem@davemloft.net, andrew+netdev@lunn.ch, horms@kernel.org, Shyam-sundar.S-k@amd.com References: <20260305042952.835926-1-Raju.Rangoju@amd.com> <20260305042952.835926-2-Raju.Rangoju@amd.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260305042952.835926-2-Raju.Rangoju@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/5/26 5:29 AM, Raju Rangoju wrote: > diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c b/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c > index 1dbfa9d4360d..457d6049291f 100644 > --- a/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c > +++ b/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c > @@ -1964,11 +1964,20 @@ static void xgbe_rx_adaptation(struct xgbe_prv_data *pdata) > > /* Step 4: Check for Block lock */ > > - /* Link status is latched low, so read once to clear > - * and then read again to get current state > - */ > - reg = XMDIO_READ(pdata, MDIO_MMD_PCS, MDIO_STAT1); > reg = XMDIO_READ(pdata, MDIO_MMD_PCS, MDIO_STAT1); > + if (reg < 0) Coccinelle says: /srv/nipa-builds-contest/testing/wt-cocci/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c:1968:5-8: WARNING: Unsigned expression compared with zero: reg < > + goto set_mode; > + > + /* Link status is latched low so that momentary link drops > + * can be detected. If link was already down read again > + * to get the latest state. > + */ > + if (!pdata->phy.link && !(reg & MDIO_STAT1_LSTATUS)) { > + reg = XMDIO_READ(pdata, MDIO_MMD_PCS, MDIO_STAT1); > + if (reg < 0) Same here. /P