From: Jon Smirl <jonsmirl@gmail.com>
To: Andi Kleen <ak@muc.de>
Cc: linux-kernel@vger.kernel.org,
DRI Devel <dri-devel@lists.sourceforge.net>
Subject: Re: chasing the four level page table
Date: Thu, 6 Jan 2005 15:05:49 -0500 [thread overview]
Message-ID: <9e4733910501061205354c9508@mail.gmail.com> (raw)
In-Reply-To: <20050106193826.GC47320@muc.de>
On 6 Jan 2005 20:38:27 +0100, Andi Kleen <ak@muc.de> wrote:
> You can't use get_user_pages in this case because the AGP aperture
> can be above mem_map. If none of the callers take page_table_lock
> already you would need to add that too. I guess from the context the lock
> is not taken, but better double check.
>
> Perhaps we should add a get_user_phys() or somesuch for this.
No where in DRM is page_table_lock being taken. Also, no other device
driver takes page_table_lock either, so that probably implies that DRM
shouldn't start doing it to. Best solution would probably be add an mm
function for get_user_phys() that takes the lock internally. If you
add the function I'll convert DRM to use it.
--
Jon Smirl
jonsmirl@gmail.com
next prev parent reply other threads:[~2005-01-06 20:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-06 17:17 Jon Smirl
2005-01-06 18:12 ` Andi Kleen
2005-01-06 18:36 ` Jon Smirl
2005-01-06 19:38 ` Andi Kleen
2005-01-06 20:05 ` Jon Smirl [this message]
2005-01-06 21:41 ` Dave Jones
2005-01-08 5:22 ` Jon Smirl
2005-01-15 2:54 ` H. Peter Anvin
2005-01-15 3:37 ` Roland Dreier
2005-01-15 4:24 ` Andi Kleen
2005-01-15 5:59 ` Jon Smirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e4733910501061205354c9508@mail.gmail.com \
--to=jonsmirl@gmail.com \
--cc=ak@muc.de \
--cc=dri-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome