Re: [PATCH] e1000 C style badness

[Jon Smirl <jonsmirl@gmail.com>]

On 1/18/06, Jens Axboe <axboe@suse.de> wrote:
> Hi,
>
> Seems e1000 has even bigger problems than just C style badness in the
> newest -git after the e1000 updates. diff of kernel boot messages from
> e1000:
>
> -Intel(R) PRO/1000 Network Driver - version 6.1.16-k2
> +Intel(R) PRO/1000 Network Driver - version 6.3.9-k2
>  Copyright (c) 1999-2005 Intel Corporation.
>  ACPI: PCI Interrupt 0000:02:00.0[A] -> GSI 16 (level, low) -> IRQ 169
>  PCI: Setting latency timer of device 0000:02:00.0 to 64
> +e1000: 0000:02:00.0: e1000_probe: (PCI Express:2.5Gb/s:Width x1)
> 00:0c:f1:ff:92:b8
>  e1000: eth0: e1000_probe: Intel(R) PRO/1000 Network Connection
>
> It sends/receives 5 packages, but the dhcp request never succeeds. If I
> down the interface, it oopses (nvidia module is loaded, however it bombs
> in the same way without it). If I revert just the e1000 updates, my
> system work fine (typing this message from it).

e1000 is failing the same way for me too. Chip is on the motherboard:
Intel Corporation 82540EM Gigabit Ethernet Controller (rev 02)

Jan 18 10:08:26 jonsmirl kernel: ADDRCONF(NETDEV_UP): eth0: link is not ready
Jan 18 10:08:26 jonsmirl kernel: e1000: eth0: e1000_watchdog_task: NIC
Link is Up 100 Mbps Half Duplex
Jan 18 10:08:26 jonsmirl kernel: ADDRCONF(NETDEV_CHANGE): eth0: link
becomes ready
Jan 18 10:08:26 jonsmirl dhclient: DHCPREQUEST on eth0 to
255.255.255.255 port 67
Jan 18 10:08:31 jonsmirl dhclient: DHCPREQUEST on eth0 to
255.255.255.255 port 67
Jan 18 10:08:38 jonsmirl dhclient: DHCPDISCOVER on eth0 to
255.255.255.255 port 67 interval 8
Jan 18 10:08:46 jonsmirl dhclient: DHCPDISCOVER on eth0 to
255.255.255.255 port 67 interval 10
Jan 18 10:08:56 jonsmirl dhclient: DHCPDISCOVER on eth0 to
255.255.255.255 port 67 interval 11
Jan 18 10:09:07 jonsmirl dhclient: DHCPDISCOVER on eth0 to
255.255.255.255 port 67 interval 20
Jan 18 10:09:27 jonsmirl dhclient: DHCPDISCOVER on eth0 to
255.255.255.255 port 67 interval 9
Jan 18 10:09:36 jonsmirl dhclient: DHCPDISCOVER on eth0 to
255.255.255.255 port 67 interval 3
Jan 18 10:09:39 jonsmirl dhclient: No DHCPOFFERS received.

I am using an old switch so I normally get a half duplex connection:
Jan 18 10:14:25 jonsmirl kernel: e1000: eth0: e1000_watchdog_task: NIC
Link is Up 100 Mbps Half Duplex
I don't normally get the NETDEV up and changed notifications.

--
Jon Smirl
jonsmirl@gmail.com