From: "Jon Smirl" <jonsmirl@gmail.com>
To: "Alan Cox" <alan@lxorguk.ukuu.org.uk>
Cc: "Paul Fulghum" <paulkf@microgate.com>,
lkml <linux-kernel@vger.kernel.org>,
"Theodore Ts'o" <tytso@mit.edu>
Subject: Re: tty_mutex and tty_old_pgrp
Date: Wed, 28 Jun 2006 14:13:13 -0400 [thread overview]
Message-ID: <9e4733910606281113m2c5fc3bfgcdf5b458f3fbc861@mail.gmail.com> (raw)
In-Reply-To: <1151517865.15166.54.camel@localhost.localdomain>
On 6/28/06, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> Ar Mer, 2006-06-28 am 13:36 -0400, ysgrifennodd Jon Smirl:
> > This selinux code is checking to see if the current process still has
> > access rights to it's controlling tty, right? If it doesn't tty and
> > tty_old_pgrp are nulled out. Does this need locking?
>
> Yes that looks like it needs to the tty lock covering it.
I can add the lock.
If the task is the session leader and you null out it's controlling
tty, what about other tasks in the session? I didn't think is was
legal to have some tasks in a session with tty set and some without
it. Should this turn into a disassociate_tty()?
--
Jon Smirl
jonsmirl@gmail.com
next prev parent reply other threads:[~2006-06-28 18:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-26 22:38 Jon Smirl
2006-06-27 22:56 ` Paul Fulghum
2006-06-28 3:29 ` Jon Smirl
2006-06-28 10:24 ` Alan Cox
2006-06-28 17:36 ` Jon Smirl
2006-06-28 18:04 ` Alan Cox
2006-06-28 18:13 ` Jon Smirl [this message]
2006-06-29 5:41 ` Jon Smirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e4733910606281113m2c5fc3bfgcdf5b458f3fbc861@mail.gmail.com \
--to=jonsmirl@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=paulkf@microgate.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®