From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750784AbWGKNq5 (ORCPT ); Tue, 11 Jul 2006 09:46:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750788AbWGKNq5 (ORCPT ); Tue, 11 Jul 2006 09:46:57 -0400 Received: from ug-out-1314.google.com ([66.249.92.169]:1007 "EHLO ug-out-1314.google.com") by vger.kernel.org with ESMTP id S1750784AbWGKNq4 (ORCPT ); Tue, 11 Jul 2006 09:46:56 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=l1wlvnpGYnIklWND3qgIwzm/bLnaKRfTb1EzWn+ZXro88rxBt1ptdBt6rghwJXCILon+BKh8vxAi5E1U0K/W2Ai/qb7ldg4IO+9CYq4SiYUdD+P77V6FvRBgRM2nbMSeFZtgbkZml+G2Ky4X0DPZ/ysBgt6gJfPIzcoV6y+/ppg= Message-ID: <9e4733910607110646m7f95581cl52669daddf5f2fa1@mail.gmail.com> Date: Tue, 11 Jul 2006 09:46:54 -0400 From: "Jon Smirl" To: "Antonino A. Daplas" Subject: Re: [PATCH] fbdev: Statically link the framebuffer notification functions Cc: "Andrew Morton" , rdunlap@xenotime.net, mreuther@umich.edu, linux-kernel@vger.kernel.org, zap@homelink.ru In-Reply-To: <44B3AA51.1040003@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200607100833.00461.mreuther@umich.edu> <20060710113212.5ddn42t40ks44s00@engin.mail.umich.edu> <44B27931.30609@gmail.com> <200607102327.38426.mreuther@umich.edu> <20060710215253.1fcaab57.rdunlap@xenotime.net> <44B34D68.3080602@gmail.com> <20060711032817.94c78ae0.akpm@osdl.org> <44B39D4D.8060209@gmail.com> <9e4733910607110621i720db936sebdd0bcb60fab4ad@mail.gmail.com> <44B3AA51.1040003@gmail.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On 7/11/06, Antonino A. Daplas wrote: > Jon Smirl wrote: > > On 7/11/06, Antonino A. Daplas wrote: > >> The backlight and lcd subsystems can be notified by the framebuffer layer > >> of blanking events. However, these subsystems, as a whole, can function > >> independently from the framebuffer layer. But in order to enable to > >> the lcd and backlight subsystems, the framebuffer has to be compiled > >> also, > >> effectively sucking in a huge amount of unneeded code. Besides, the > >> dependency > >> is introducing a lot of compilation problems. > > > > This code is effectively rebuilding a fb specific version of > > inter_module_get/put., something that was removed earlier. > > Huh? I don't see any semblance of inter_module_* or symbol_* in there. > Read the patch again. You are providing a fixed point to do a rendezvous between modules without refcount tracking. That's what inter_module did. The symbol is being passed implicitly via the entry point names. Just wrap fb_notifier in a module and it will get tracked. > > Tony > > > -- Jon Smirl jonsmirl@gmail.com