From: "Jon Smirl" <jonsmirl@gmail.com>
To: lkml <linux-kernel@vger.kernel.org>, i2c@lm-sensors.org
Subject: [PATCH] Fix i2c module parameter permissions for read/write
Date: Sun, 4 Nov 2007 00:55:15 -0400 [thread overview]
Message-ID: <9e4733910711032155j1649a3b8u56a59e754d77f61b@mail.gmail.com> (raw)
The permissions of i2c module parameters were set to zero making the
parameters invisible and unsettable from the kernel command line. This
patch changes the permissions to the standard 0644 read/write.
Signed-off-by: Jon Smirl <jonsmirl@gmail.com>
---
diff --git a/include/linux/i2c.h b/include/linux/i2c.h
index 8033e6b..395e430 100644
--- a/include/linux/i2c.h
+++ b/include/linux/i2c.h
@@ -588,7 +588,7 @@ union i2c_smbus_data {
#define I2C_CLIENT_MODULE_PARM(var,desc) \
static unsigned short var[I2C_CLIENT_MAX_OPTS] = I2C_CLIENT_DEFAULTS; \
static unsigned int var##_num; \
- module_param_array(var, short, &var##_num, 0); \
+ module_param_array(var, short, &var##_num, 0644); \
MODULE_PARM_DESC(var,desc)
#define I2C_CLIENT_MODULE_PARM_FORCE(name) \
--
Jon Smirl
jonsmirl@gmail.com
next reply other threads:[~2007-11-04 4:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-04 4:55 Jon Smirl [this message]
2007-11-04 9:55 ` [i2c] " Jean Delvare
2007-11-04 13:39 ` Jon Smirl
2007-11-06 16:51 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e4733910711032155j1649a3b8u56a59e754d77f61b@mail.gmail.com \
--to=jonsmirl@gmail.com \
--cc=i2c@lm-sensors.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®