From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0770C77B7F for ; Sat, 6 May 2023 09:04:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231443AbjEFJEC (ORCPT ); Sat, 6 May 2023 05:04:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230218AbjEFJD7 (ORCPT ); Sat, 6 May 2023 05:03:59 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC1274EDB for ; Sat, 6 May 2023 02:03:51 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-4ec8133c59eso3058015e87.0 for ; Sat, 06 May 2023 02:03:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683363830; x=1685955830; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SdVNb9Mn581l8lgASjfW3rki8vUOXzSPLGbYRZ2k+z0=; b=cK8dtzvU8R42XfG8GQqIl6uPRxpjRk/CWexR6Ea7VDCnuKJ9TVcuABB18JH+gS9fjn /Qo4gRPlawkMfRBbVprLtt7kiVvOcrdTTMiu38CQY4ur5teDSHO8Rx7uaxKgCpdru6BN dbww/b+wdDhL/zoEKKoVJ/KZAspG7IDPtT8976R90ISEggs8Eg4BNvsZzZhmT7Z2TwsN ly6jBsB0nNFygAfWc3FqyR4hLUzHaaiPLkADkyW5TrpMpUoxss82H2CfXb+71boGJaDj EEPofInHuvMKcBk0yqQy8QFobjXzcgYmj6TZi/Ruy2wyUBN914IoP+PGutV6OFN1a+8q C1wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683363830; x=1685955830; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SdVNb9Mn581l8lgASjfW3rki8vUOXzSPLGbYRZ2k+z0=; b=hoQIE5mgIolH3rwUqkcNiGqJi5T3LJ/KloQjK8unK6mg3eRORsJBcu0LRT2veSVo83 WAro1D8j/akY84bzNzIntBLHwH3jN6FKdikfL+N+KWQ219ddJAoh92N5UsPSCplJxmcA P7xSFlq59S0hvdtRUpHrKzBD6Tfef613eEHgfOgWsa1jTN7S/YvU/KoPge+v7MGHryeI tvuEkG096zrc2r06NS2AA4lD0ko73FZKt8h8x9O6/g1kom+BspDMHBonW+IdqpMuFcoE IVR0xzBUpglUoJQFQyZhYM+AHOoYI78IJ/KPMFN+6Z1mn6pztC+VH+mSkg4UCz6HuPZy PMXA== X-Gm-Message-State: AC+VfDwmOn33WK3hAxuYKWbm9B2fIp2IU16d2/Hm0LUdpPTcuaR21hBi L8vWnFMyrLiiTkXzF5InvYEMRQ== X-Google-Smtp-Source: ACHHUZ5/9stiAnwRBqLEXpr5GKHp8S43F39twqWRZH3/EqfgoK4aqKgC84D0L794DGLoJRZfGKrS7A== X-Received: by 2002:a19:7512:0:b0:4eb:3fb2:c56d with SMTP id y18-20020a197512000000b004eb3fb2c56dmr1102078lfe.12.1683363830116; Sat, 06 May 2023 02:03:50 -0700 (PDT) Received: from [192.168.1.101] (abyl248.neoplus.adsl.tpnet.pl. [83.9.31.248]) by smtp.gmail.com with ESMTPSA id o15-20020a05651238af00b004eff1163c37sm581352lft.308.2023.05.06.02.03.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 06 May 2023 02:03:49 -0700 (PDT) Message-ID: <9e48a247-1f2c-795d-3991-f820cf66ee05@linaro.org> Date: Sat, 6 May 2023 11:03:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v2 1/2] arm64: dts: qcom: Add Fxtec Pro1X (QX1050) DTS To: Dang Huynh , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230505-fxtec-pro1x-support-v2-0-0ea2378ba9ae@riseup.net> <20230505-fxtec-pro1x-support-v2-1-0ea2378ba9ae@riseup.net> <7894772.GXAFRqVoOG@melttower> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <7894772.GXAFRqVoOG@melttower> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6.05.2023 03:42, Dang Huynh wrote: >>> + qcom,board-id = <34 0>; >> >> Does the bootloader refuse to boot without these? Some newer >> ones don't need it. >> >> In case they are compulsory, you'll have to add the pro1x to the >> relevant allOf:if:then: block in bindings. >> > Tested, nope. > >>> +&usb_dwc3 { >>> + maximum-speed = "high-speed"; >> >> Do you know whether the phone supports usb3? Usually if that's >> the case, you will get usb3 in fastboot. >> >> You'll need an actual usb3 cable to check that though, many claim >> that but then don't have the necessary wires connected. > I asked around, they said yes but without anything to test on hand, I'm not > sure. > > Should I remove it or something? No, you may get weird behavior. Keep it high-speed for now. Konrad > > Other than that, I've fixed the other issues with the series. > > Best regards, > Dang > >