From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F6A02236FC for ; Sat, 10 Jan 2026 09:58:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768039093; cv=none; b=eqSWytSYfvN/h8RpYhIi5RarAfr4vNqHPRt2pG69hisUfTADoTHkb61HCqoVwjlNTh6Ds7/lQ0eDenqHErBznozjvC+l5E3QU3WKQTaKdw/DqZA6gE1dsBKTum1NX8jnsCAtUMh7q2U3lsVnR/rE96m/cuBrhtrBniYPUHOx2N4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768039093; c=relaxed/simple; bh=UVASJL81PowX/kBILLs/GepNKULzc3OT5vcMjYhxSzo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qfKcCGmnQ0wec/MWBJHAnZ1SFj7Q9UxhGf3a1eTq1M9BtmYsHkNsQEsn46boSHaVFu8PnWcjj8wz8EKIhJh2XYWtItoAYgSbc4Ja53SnDew4kvuX4KIk70fZu7SgqIqpKuO3o6LjQDhqbiHbHAzAeMiF6Q+n9L3H+ANQVDSe+H0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=jMo9mU0z; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="jMo9mU0z" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1768039090; bh=UVASJL81PowX/kBILLs/GepNKULzc3OT5vcMjYhxSzo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=jMo9mU0zqWVb95Hbt7Oa3iM2pMSIjazU7WDi0tpFLuPQZha76KQXD/V5PbebaXSXD LQbFoFQO0+yE+YrMxBaUZ9kvDQOP+S6rEcbmfwm36R6TnP97/v3H+72Lpg8i2B0Qjs jgpuhdES3o95D+yfdkBxykdLT09nnpKwcP6wZ6796NrMfibM9LIHL1nXzxP75rJDT5 YQqOMbjm84PR3Vc9wW4/rgx5ybU7nFF2VSgXzpywUUCDOcm6GJ69yKqJATMl+hgMg2 oIDhC15CHF/uuwvdrDoY3kDxAkJdEkEeX65Q08HpMKkT6HIEhUgPLgKc9RFZL5PTr9 ckY76nUwXjpGw== Received: from [192.168.1.90] (unknown [82.79.138.145]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id 754FB17E0CB0; Sat, 10 Jan 2026 10:58:09 +0100 (CET) Message-ID: <9e4c8514-63e9-4ff7-85b1-b5af7dff9a2d@collabora.com> Date: Sat, 10 Jan 2026 11:58:08 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 4/4] drm/rockchip: vop2: Support setting custom background color To: Andy Yan Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Andy Yan , Louis Chauvet , Haneen Mohammed , Melissa Wen , Robert Mader , kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org References: <20251219-rk3588-bgcolor-v4-0-2ff1127ea757@collabora.com> <20251219-rk3588-bgcolor-v4-4-2ff1127ea757@collabora.com> <2750b73.10b0.19ba61052c8.Coremail.andyshrk@163.com> Content-Language: en-US From: Cristian Ciocaltea In-Reply-To: <2750b73.10b0.19ba61052c8.Coremail.andyshrk@163.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi Andy, On 1/10/26 6:00 AM, Andy Yan wrote: > > > Hello Cristian, > At 2025-12-20 05:47:01, "Cristian Ciocaltea" wrote: >> The Rockchip VOP2 display controller allows configuring the background >> color of each video output port. >> >> Since a previous patch introduced the BACKGROUND_COLOR CRTC property, >> which defaults to solid black, make use of it when programming the >> hardware. >> >> Note the maximum precision allowed by the display controller is 10bpc, >> while the alpha component is not supported, hence ignored. >> >> Signed-off-by: Cristian Ciocaltea >> --- >> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 13 ++++++++++++- >> drivers/gpu/drm/rockchip/rockchip_drm_vop2.h | 4 ++++ >> 2 files changed, 16 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c >> index 498df0ce4680..3a232d0d4acb 100644 >> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c >> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c >> @@ -1554,6 +1554,7 @@ static void vop2_post_config(struct drm_crtc *crtc) >> struct vop2_video_port *vp = to_vop2_video_port(crtc); >> struct vop2 *vop2 = vp->vop2; >> struct drm_display_mode *mode = &crtc->state->adjusted_mode; >> + u64 bgcolor = crtc->state->background_color; >> u16 vtotal = mode->crtc_vtotal; >> u16 hdisplay = mode->crtc_hdisplay; >> u16 hact_st = mode->crtc_htotal - mode->crtc_hsync_start; >> @@ -1599,7 +1600,11 @@ static void vop2_post_config(struct drm_crtc *crtc) >> vop2_vp_write(vp, RK3568_VP_POST_DSP_VACT_INFO_F1, val); >> } >> >> - vop2_vp_write(vp, RK3568_VP_DSP_BG, 0); >> + /* Background color is programmed with 10 bits of precision */ >> + val = FIELD_PREP(RK3568_VP_DSP_BG__DSP_BG_RED, DRM_ARGB64_GETR(bgcolor) >> 6); >> + val |= FIELD_PREP(RK3568_VP_DSP_BG__DSP_BG_GREEN, DRM_ARGB64_GETG(bgcolor) >> 6); > >> + val |= FIELD_PREP(RK3568_VP_DSP_BG__DSP_BG_BLUE, DRM_ARGB64_GETB(bgcolor) >> 6); > > > the bit31 of RK3568_VP_DSP_BG is bg_display_en， that means when we set a > background color, we should set this bg_display_en bit. Oh yes, good catch! > The default value of this bit is 1, which explains why the patch currently works > properly even though it doesn't set bit31. For some reason, the RK3588 TRM indicates 0x0 for the reset value. I assume that's a mistake, as RK3576 TRM shows 0x1. Thanks, Cristian