Re: [PATCH] fs/Kconfig: Enable HUGETLBFS only if ARCH_SUPPORTS_HUGETLBFS

[Christophe Leroy <christophe.leroy@csgroup.eu>]

Le 15/07/2025 à 02:31, Andrew Morton a écrit :
> On Mon, 14 Jul 2025 11:49:09 +0200 Borislav Petkov <bp@alien8.de> wrote:
> 
>> On Mon, Jul 14, 2025 at 08:05:31AM +0530, Anshuman Khandual wrote:
>>> The original first commit had added 'BROKEN', although currently there
>>> are no explanations about it in the tree.
>>
>> commit c0dde7404aff064bff46ae1d5f1584d38e30c3bf
>> Author: Linus Torvalds <torvalds@home.osdl.org>
>> Date:   Sun Aug 17 21:23:57 2003 -0700
>>
>>      Add CONFIG_BROKEN (default 'n') to hide known-broken drivers.
> 
> Thanks.  That was unkind of someone.  How's this?
> 
> 
> From: Andrew Morton <akpm@linux-foundation.org>
> Subject: init/Kconfig: restore CONFIG_BROKEN help text
> Date: Mon Jul 14 05:20:02 PM PDT 2025
> 
> Linus added it in 2003, it later was removed.  Put it back.

Was removed by:

commit 3be71ba84f17f39131900f44e8ef513c696a5b11
Author: Linus Torvalds <torvalds@home.osdl.org>
Date:   Mon Sep 1 21:30:14 2003 -0700

     Instead of asking for "broken drivers", ask for a "clean compile".

     This makes "allyesconfig" do a better job.

diff --git a/init/Kconfig b/init/Kconfig
index 3b6e6d580e1d..c296f6bee03c 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -32,16 +32,19 @@ config EXPERIMENTAL
  	  you say Y here, you will be offered the choice of using features or
  	  drivers that are currently considered to be in the alpha-test phase.

-config BROKEN
-	bool "Prompt for old and known-broken drivers"
-	depends on EXPERIMENTAL
-	default n
+config CLEAN_COMPILE
+	bool "Don't select drivers known to be broken" if EXPERIMENTAL
+	default y
  	help
-	  This option allows you to choose whether you want to try to
-	  compile (and fix) old drivers that haven't been updated to
-	  new infrastructure.
+	  Select this option if you don't even want to see the option
+	  to configure known-broken drivers.

-	  If unsure, say N.
+	  If unsure, say Y
+
+config BROKEN
+	bool
+	depends on !CLEAN_COMPILE
+	default y

  config BROKEN_ON_SMP
  	bool



> 
> Cc: Anshuman Khandual <anshuman.khandual@arm.com>
> Cc: Borislav Betkov <bp@alien8.de>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Thomas Gleinxer <tglx@linutronix.de>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 
>   init/Kconfig |    4 ++++
>   1 file changed, 4 insertions(+)
> 
> --- a/init/Kconfig~a
> +++ a/init/Kconfig
> @@ -169,6 +169,10 @@ menu "General setup"
>   
>   config BROKEN
>   	bool
> +	help
> +	  This option allows you to choose whether you want to try to
> +	  compile (and fix) old drivers that haven't been updated to
> +	  new infrastructure.
>   
>   config BROKEN_ON_SMP
>   	bool
> _
> 
>