From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.tuxedocomputers.com (mail.tuxedocomputers.com [157.90.84.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55FF61F584C; Tue, 18 Mar 2025 10:20:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=157.90.84.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742293256; cv=none; b=gdlyr/wGSOh4ge2utvlBWloKNJCW0ShO+63vkKcmED2C8W+m+B6DIOkPT9vk5G96A65Pfhnp2U9XsnjGJhycS3sZ3I32hLeNFV4+PIjOAyBlWMSjnF/6H3QqvYK2v92e0o1GUS5FGDz8maMHUDn7P3wZFj3XmjHTMHMZFiYhL1Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742293256; c=relaxed/simple; bh=Pi8RhHzaAInKtHQqmtMB5vgdlX6UdbsvnzMk99io7tc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=skOtkNQSf0rMNz7XrIjq17aCkJG/pgluYRwcSl9UFhdShkrCMYinMrRv/Kv9Es+QdQRWnrUo0XfgxIZRAMkeaeONGjNARuiE/Ss77JROqslf/fBCvHzyFYWzqKAMf7hYkXCf8t65aKB6rlA4MW6LtvKPxqckDq0RTyCrpHJAEJQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=tuxedocomputers.com; spf=pass smtp.mailfrom=tuxedocomputers.com; dkim=pass (1024-bit key) header.d=tuxedocomputers.com header.i=@tuxedocomputers.com header.b=DIcFBKzJ; arc=none smtp.client-ip=157.90.84.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=tuxedocomputers.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxedocomputers.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=tuxedocomputers.com header.i=@tuxedocomputers.com header.b="DIcFBKzJ" Received: from [192.168.42.116] (p5b164989.dip0.t-ipconnect.de [91.22.73.137]) (Authenticated sender: wse@tuxedocomputers.com) by mail.tuxedocomputers.com (Postfix) with ESMTPSA id 4BA1F2FC0191; Tue, 18 Mar 2025 11:20:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxedocomputers.com; s=default; t=1742293250; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t7DR2W+kQFGdU29YqlrWVHL4jjOkVYCj2LeKBKOkoSw=; b=DIcFBKzJXrPndVkVm/R9MNY/+OoL9TruO2HJP8s/QJqAKn4ruJ0kjB4JHBpJ2na+FDUy1L EojnRaoqv/xMPxs9k5XQtS6p4SmpXB0nwfUKXJq7fNENqORlbx7IbS67C8Tf9DFaoBxPE0 In5i9wPDqwGWan/bmAp75QLx77PFgVo= Authentication-Results: mail.tuxedocomputers.com; auth=pass smtp.auth=wse@tuxedocomputers.com smtp.mailfrom=wse@tuxedocomputers.com Message-ID: <9e53c2e9-3393-463d-915f-d70f3139893f@tuxedocomputers.com> Date: Tue, 18 Mar 2025 11:20:50 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] Input: atkbd - Correctly map F13 - F24 To: Hans de Goede , Dmitry Torokhov Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250311180643.1107430-1-wse@tuxedocomputers.com> <20250311180643.1107430-2-wse@tuxedocomputers.com> <83ea44f6-c0ad-4cb0-a16e-dd4fa17b63c7@tuxedocomputers.com> <45fff318-7925-4328-9dca-999c00e271d2@redhat.com> Content-Language: en-US From: Werner Sembach In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Hans Am 17.03.25 um 23:22 schrieb Hans de Goede: > Hi, > > On 17-Mar-25 5:47 PM, Werner Sembach wrote: >> Hi again, >> >> Am 17.03.25 um 13:06 schrieb Hans de Goede: >>> Hi, >>> >>> On 11-Mar-25 19:10, Werner Sembach wrote: >>>> Hi Hans, Hi Dimitry, >>>> >>>> resending this too on the v2 to not cause confusion: >>>> >>>> Regarding remapping KEY_ZENKAKUHANKAKU to KEY_TOUCHPAD_TOGGLE: >>>> >>>> Am 11.03.25 um 19:06 schrieb Werner Sembach: >>>>> Currently only F23 is correctly mapped for PS/2 keyboards. >>>>> >>>>> Following to this table: >>>>> https://download.microsoft.com/download/1/6/1/161ba512-40e2-4cc9-843a-923143f3456c/translate.pdf >>>>> >>>>> - F24 and Zenkaku/Hankaku share the same scancode, but since in real world >>>>> Zenkaku/Hankaku keys seem to just use the tilde scancode, this patch binds the >>>>> scancode to F24. Note that on userspace side the KEY_ZENKAKUHANKAKU keycode is >>>>> currently not bound in xkeyboard-config, so it is (mostly*) unused anyway. >>>> I think what the firmware vendor actually wanted to do was to send ctrl+super+f24 upon touchpad toggle. This would somewhat fall in line with, for example, the copilot key being implemented as shift+super+f23. >>> I agree that that seems to be the intent. >>> >>>> Following this, my suggestion is to do this remapping and handle the rest in xkeyboard-config >>> xkeyboard config already contains mappings for F13 - F18 and F20-F23 in >>> /usr/share/X11/xkb/symbols/inet >>> >>> So all that needs to happen there is map FK19 -> F19 and FK24 -> F24. >>> >>> And then teach KDE + GNOME that ctrl+super+f24 means touchpad-toggle. >> Alternative suggestion, again following how the copilot key is implemented: >> >> key    {      [ F19 ]       }; >> [...] >> key    {      [ XF86TouchpadOff, XF86Assistant ], type[Group1] = "PC_SHIFT_SUPER_LEVEL2" }; >> key    {      [ F24, XF86TouchpadToggle ], type[Group1] = "PC_CONTROL_SUPER_LEVEL2" }; >> >> Then only xkb has to be touched again, but not KDE and GNOME. > Ah I did not know you could do this. Yes this sounds like a very good > plan wrt the xkbconfig changes and then indeed we can do all the handling > in xkbconfig. > > >>> We could maybe get away with also dropping the weird mappings for FK13 - FK18 >>> and map those straight to F13 - F18, but we need the special mappings >>> for F20 - F23 to stay in place to not break stuff. >> Good question >> >> XF86Tools launches system settings on KDE. > Right, but XF86Tools is also send for KEY_CONFIG which makes more sense, > the question is are there any devices actually sending KEY_F13 in > a case where they really should be sending KEY_CONFIG instead. > > Note this is unrelated to the XF86TouchpadToggle thing though, just > something which I noticed while looking at things. > >> Looking at the links in the git log of xkeyboard-config (commit 1e94d48801bf8cb75741aa308d4cdfb63b03c66c and 01d742bc5cd22543d21edb2101fec6558d4075db) these seems to be device specific bindings that got accepted in the default config because the keys where unbound before. > I see, so it might be worthwhile to try and fix these, but in > a separate pull-request from the: > > key { [ F24, XF86TouchpadToggle ], type[Group1] = "PC_CONTROL_SUPER_LEVEL2" }; ack, I will create a MR as soon as the freedesktop gitlab migration is finished. Best regards, Werner > > addition. > > Regards, > > Hans > >