mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Subhajit Ghosh <subhajit.ghosh@tweaklogic.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Matti Vaittinen <mazziesaccount@gmail.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Paul Gazzillo <paul@pgazz.com>
Cc: Matt Ranostay <matt@ranostay.sg>,
	Stefan Windfeldt-Prytz <stefan.windfeldt-prytz@axis.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] iio: light: Add support for APDS9306 Light Sensor
Date: Fri, 27 Oct 2023 19:12:59 +1030	[thread overview]
Message-ID: <9e55b561-a0ad-4503-9f20-b7c98507afa0@tweaklogic.com> (raw)
In-Reply-To: <d7ba077d-6bcd-4e04-b678-51e4bbc935ca@linaro.org>

On 27/10/23 18:43, Krzysztof Kozlowski wrote:
> On 27/10/2023 09:45, Subhajit Ghosh wrote:
>> Driver support for Avago (Broadcom) APDS9306 Ambient Light Sensor with als
>> and clear channels with i2c interface. Hardware interrupt configuration is
>> optional. It is a low power device with 20 bit resolution and has
>> configurable adaptive interrupt mode and interrupt persistence mode.
>> The device also features inbuilt hardware gain, multiple integration time
>> selection options and sampling frequency selection options.
>>
>> v1 -> v2
>> - Renamed probe_new to probe
>> - Removed module id table
> 
> This is fourth version of this patchset, not second, so v4.
> 
> Best regards,
> Krzysztof
> 
Hi Krzysztof,

1. This patch set adds support for APDS9306 Light sensor,
2. In v0 of this patch series I was told to combine the avago,apds9300.yaml
    and avago,apds9960.yaml as they look similar, then add my apds9306
    support into it.
3. I assumed that the squashing operation of apds9300 and apds9960 schemas
    are a separate operation and submitted a separate patch to do that, please
    follow the link
    Link: https://lore.kernel.org/all/20231019-hurry-eagle-0ffa95b1a026@spud/
4. Conor reviewed the patch and said that it would be better that I handle all
    these operations in apds9306 driver (this) patch series rather than submitting
    a new patch.
    "Ahh apologies then. The best course of action would likely be to include
     the patch merging the two bindings in your series adding the third user."
5. As per this patch series -- RFC->v0->v1-v2

I have formatted the commit messages wrongly which might be the source of all the
confusion. I'll fix it. Please let me know the best course of action, I am not well
versed with this process. Thank you for reviewing.

Regards,
Subhajit Ghosh

  reply	other threads:[~2023-10-27  8:44 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-27  7:45 [PATCH v2 0/2] Support for Avago APDS9306 Ambient " Subhajit Ghosh
2023-10-27  7:45 ` [PATCH v2 1/2] dt-bindings: iio: light: Avago APDS9306 Subhajit Ghosh
2023-10-27  8:11   ` Krzysztof Kozlowski
2023-10-27  8:55     ` Subhajit Ghosh
2023-10-27 11:03       ` Krzysztof Kozlowski
2023-10-28 13:29   ` Jonathan Cameron
2023-10-27  7:45 ` [PATCH v2 2/2] iio: light: Add support for APDS9306 Light Sensor Subhajit Ghosh
2023-10-27  8:13   ` Krzysztof Kozlowski
2023-10-27  8:42     ` Subhajit Ghosh [this message]
2023-10-27 11:04       ` Krzysztof Kozlowski
2023-10-27 11:42         ` Subhajit Ghosh
2023-10-28 13:36           ` Jonathan Cameron
2023-10-27 11:07   ` Andy Shevchenko
2023-10-27 11:36     ` Subhajit Ghosh
2023-10-28  6:29   ` kernel test robot
2023-10-28 15:20   ` Jonathan Cameron
2023-10-29 15:51     ` Matti Vaittinen
2023-10-30 10:21       ` Matti Vaittinen
2023-10-31  7:11         ` Matti Vaittinen
2023-10-31  8:20           ` Subhajit Ghosh
2023-10-31 10:38           ` Andy Shevchenko
2023-10-31 11:39             ` Matti Vaittinen
2023-10-31 12:07             ` Matti Vaittinen
2023-10-31 13:42               ` Andy Shevchenko
2023-11-01  6:16                 ` Matti Vaittinen
2023-11-02 12:50                   ` Andy Shevchenko
2023-10-31  8:38     ` Subhajit Ghosh
2023-11-06 11:13       ` Jonathan Cameron
2023-11-06 12:04         ` Subhajit Ghosh
2023-11-06 12:10           ` Matti Vaittinen
2023-12-04  9:51             ` Jonathan Cameron
2023-11-05 14:22   ` kernel test robot
2023-11-06 10:07     ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9e55b561-a0ad-4503-9f20-b7c98507afa0@tweaklogic.com \
    --to=subhajit.ghosh@tweaklogic.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt@ranostay.sg \
    --cc=mazziesaccount@gmail.com \
    --cc=paul@pgazz.com \
    --cc=robh+dt@kernel.org \
    --cc=stefan.windfeldt-prytz@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®