From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4891037BE63 for ; Mon, 15 Jun 2026 12:00:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781524848; cv=none; b=pcUs98Qoj/N/Jgi2HkUn6GKWb/epdmFZwLTS5t9aOXAEzViFvF5RyhCydeE+ngOMJupAuv0myftCpVAdMAKOkWfK0xxsTFD8sKDfw5VYEGRZ3STuxpdRfpre65RC0ClQpCZ4SPAS7Z7KUmnpwYpeflvp0VJdrL+ZMH3POXIcNIo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781524848; c=relaxed/simple; bh=iNmIvlZ/mcJarand0aXfw4/Zfs15L5lBq3iRXAX/dbs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NbkuwOdZTrqpt6pAgKb+3JBaC9y1JUPMNlo4eotaGx5ZFpSCSvhNFdA0i8xrBwxl0eH9fLBrUKtN1McovxuG+TvtTvSTxoFSxJzYMtZekXY9bIKFNkZ+nXdecJ/bpG5MoEfRcqODOmmq1ofIUwEV1GVwTzQo/Hq8eL5aUSIeqWQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=eJVGbbY7; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=B/gXOI/4; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="eJVGbbY7"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="B/gXOI/4" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65FAoKfE2481144 for ; Mon, 15 Jun 2026 12:00:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /t3nYX2FjsvGv7wJFQitp38xpYZONGghVelaQH9NBq8=; b=eJVGbbY7ZfIqt0kg 1De74m+/NqhstTYBH9LKMxFP7qoFl4O+tKuhe6alJQ/eKc6K7JObj+ZgD5sA4NPK STal55+puYnPBG7KWa8x719AIvBdWLjjItvDPtTQ8m1eLzPv3Jrd66YShsiT2Wdr OC+bMGOxLJZzXNMNSQtBpl1Hd4FVKCoAqsv6QvcPXCXMTelnqjT6Ktk8CkmomfJ4 yv6qChapaUXqHq8/j0uo3w8IeEMFJEBDLtPFm2vakRkn+5RvUvJlHx+2z1zPkKar /mbehEbAeMWJIHENBKuYB9nRQUsVb6YJhkMjm6nHx3a1m6dpdBTP/4hZFbBrAL7k cf71eA== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ete980pws-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 15 Jun 2026 12:00:46 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-517647fbff1so9594491cf.2 for ; Mon, 15 Jun 2026 05:00:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781524845; x=1782129645; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/t3nYX2FjsvGv7wJFQitp38xpYZONGghVelaQH9NBq8=; b=B/gXOI/4GMwMKzBjkwbJRGcvhZXore1lI3QvPa6HabR3daYXaKZhUzi0C8LFPmvnIW xUy+fk8fdb79QPZFUNsBmQdqZos74wQ+hI+1ZKIx6oJmg9ISPJwSF/rwhCarWEDW+2Zs reP8DJcZAby3wmXt5+5M6a3VrMn7Daxp1nNJ7PS1SNF0kg+pij1FfWzf9rL9eQ/iNxAg mnuTkbXvTKr6AoGbIZfia3GlSsCUEdgZ3AU9+SeZCOjnAz0tba4Tcdj99ABE1beQYVAl CLwzbChDZcCgwauXaQ+LxOnhRu4NPYD2wdPLh2nmF+xOLfEMCiVvQWofWypYwwNeh82U 12qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781524845; x=1782129645; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/t3nYX2FjsvGv7wJFQitp38xpYZONGghVelaQH9NBq8=; b=G15a2i+VqQxLbE1VGaf9P6gT7ayEYZx4Mri80kXhbbnQeRjsJ5TT13L2rF3Z6pOq+0 5nUCvqmWlmBLYd6MjkBjZns/hmJ0S47hEc0i90glwpBP04i/FFni+8/4+tU83QFDbUyJ M1LdmkEfLv0AX9Y4Xg7IshZ5/F8Mcqvg9M9+oAvQZnQUtyu0rXIoUMEGB6WOH0c1uzqm qJ2EUIgLcW0jTEnnJevTF1jmgZ462p2iJFVfybHh3PbVf5+gRmsTaC9p1Cd3Yfw/Ne47 ltU96vn551CL6KVG9WreYf7jXq8LUpWj/288ve984bLwXnMntcVBspDoNZPgQfu//0Tp a95w== X-Forwarded-Encrypted: i=1; AFNElJ84XjUR0b8m3BRWarwPS0s5IYqmswlhbYKASQvaDqfxXrQ+tEz2BrnYX2RDZSOAMwnIIKZwx60CsaGQEfE=@vger.kernel.org X-Gm-Message-State: AOJu0Yw08Sq9NhdX4hxjddRns6VTQcIWsORGor51MmCBnQQswE9Z0hNj mC6FYga9BnuC2y/Cc9/KIo0TCXk8iARQ618rChTMu8W/uFi3R9TmT7agMlHOM+zsogO02UQ9+5D PlG2HNhT8yl3+ngXo0iG0S4SBfAU19Gr9GV81DBGBSFBY+ZbhAshyVtT8oU6F6NZWLz8= X-Gm-Gg: Acq92OHEFZZsVu7vKqAfv6rQtRnN1qJ1yuKnDA2EVO6olrHoqbLN4l1gBXor3eHbssR 6EgXGd3omoeumjI42s25bHvvtNSOJDZC5/Kp+Q3sxah3kmuROfTHNy2/CTy+Qf1YAo7JWZLE+y9 DuHLzmAJw/tJMGC8vyxoakeSEIQzu7U08X/9Tn/uKW1CShYAHEQBkD/XWBmrxkiE1EHabfF7vDP gdrJJbT5JzauzNEhI1dF8Py0U9wJS4VIYTDrvYQFS5JJnFhwWe5fM5jkWl44lmMdV7E1k4EwYuX df3tWJdYngY53o8fT0hnmfJz4RV+uwaPwUkgtAQ9CBUykuPWo4zj7bzkyHhPpa7ntiRJ0cmnYqe LvXw2aEbLZNhKKr73gYBLjRQ75cZrseDEELlwY/wSKNlAZw== X-Received: by 2002:a05:622a:6187:b0:517:6d82:9d7b with SMTP id d75a77b69052e-517fe22789dmr126375681cf.4.1781524844854; Mon, 15 Jun 2026 05:00:44 -0700 (PDT) X-Received: by 2002:a05:622a:6187:b0:517:6d82:9d7b with SMTP id d75a77b69052e-517fe22789dmr126374931cf.4.1781524844267; Mon, 15 Jun 2026 05:00:44 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6937919b556sm3319037a12.4.2026.06.15.05.00.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jun 2026 05:00:43 -0700 (PDT) Message-ID: <9e57f91b-8f80-41d4-b50f-31c900cb0fd0@oss.qualcomm.com> Date: Mon, 15 Jun 2026 14:00:40 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] soc: qcom: geni-se: Increase MAX_GENI_CFG_RAMn_CNT to 1020 To: Viken Dadhaniya , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260522-qup-se-increase-ram-cnt-v1-1-71854d0b2ef0@oss.qualcomm.com> <09fb9e91-2585-4cb5-8bfb-92df304e9d6c@oss.qualcomm.com> <5363525f-9440-49bd-83db-242a7ed4e15d@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <5363525f-9440-49bd-83db-242a7ed4e15d@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=V5tNF+ni c=1 sm=1 tr=0 ts=6a2fe96e cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=lBRG9p681Fm1oGsCukcA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-GUID: -IdCr6T8bRWZAfGkPISUptuEkuxFzSb0 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE1MDEyNiBTYWx0ZWRfXyZc3hYRoREIB ni7lnbGgVGw+BkF8EloT9C9H12aR0OmdYi1ImnAF8RITCwJ2vBckLhK+BHLvIZ4QGDGNceDD6Hm sInvAztE9lqJSHxZyLNTvdErgMYxpEY= X-Proofpoint-ORIG-GUID: -IdCr6T8bRWZAfGkPISUptuEkuxFzSb0 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE1MDEyNiBTYWx0ZWRfXzqpH9F7u1SnK Kv32TA+jZjD94ws04jAaP/VKoLPqYtPmPhzwAtwqqGmPwKWpd3dALULxdhHa2lcjg4p956oci3l arM1GzYEG1v+3xRxzo8qiicrOOZVVYacg2KEx4FW6hw6qtaHsvuzGyCh7om48Mj2b+IUIZh4T0o ponhJShyNwbxFMz8561o0c+6BFfOQFzwGec38dkb9QiID2SHo5QzQ1zZP0dK5V++dW7zz/mHz4Z Z3+DJVpN+J9j717VjvK6Z/cG20ggS+7iwmHeGlh0fSN0SSdStW5MZd1zEH6q5sjPkbWc1RgM/zp P0A8CNfdW56WdUqB/BXFzQSuxOq5mjP9/cy5CLkv/FSybWXk3skXuzf8Woq8kQaHIoUpq3i9kaW /9qvMHVIO0LpfimdAm2sYJnQJ6Of/56v1moXNmyjXAstDPVHjyn5iS8sAyjohKxKdBJgBkCEoIi rLfdejJWx+CeitFZ8wg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-15_03,2026-06-15_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 phishscore=0 malwarescore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606150126 On 6/15/26 2:00 PM, Konrad Dybcio wrote: > On 6/15/26 7:28 AM, Viken Dadhaniya wrote: >> >> >> On 6/9/2026 8:40 PM, Konrad Dybcio wrote: >>> On 5/22/26 9:21 AM, Viken Dadhaniya wrote: >>>> The current MAX_GENI_CFG_RAMn_CNT value of 455 is insufficient for >>>> certain Qualcomm SoCs whose GENI firmware requires up to 1020 RAM >>>> entries, causing incorrect bounds checking and preventing firmware >>>> loading on those targets. >>>> >>>> Increase MAX_GENI_CFG_RAMn_CNT to 1020 to match the hardware-supported >>>> limit and ensure correct handling of configuration RAM regions across >>>> GENI-based SE blocks. >>>> >>>> Signed-off-by: Viken Dadhaniya >>>> --- >>>> drivers/soc/qcom/qcom-geni-se.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c >>>> index cd1779b6a91a..d0810960f3da 100644 >>>> --- a/drivers/soc/qcom/qcom-geni-se.c >>>> +++ b/drivers/soc/qcom/qcom-geni-se.c >>>> @@ -152,7 +152,7 @@ struct se_fw_hdr { >>>> /*Magic numbers*/ >>>> #define SE_MAGIC_NUM 0x57464553 >>>> >>>> -#define MAX_GENI_CFG_RAMn_CNT 455 >>>> +#define MAX_GENI_CFG_RAMn_CNT 1020 >>> >>> Is there any SoC where this could overflow the register space >>> (you say "certain Qualcomm SoCs")? >> >> Yes, on Talos (QCS615), the firmware image needs more than 455 CFG RAM >> entries, so the previous limit could overflow. > > What I'm asking is whether the size of the RAM on any of the SoCs > is less than 455 (the previous limit) *Less than 1020 (the new limit), of course.. Konrad