From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 361EEC433B4 for ; Fri, 16 Apr 2021 15:17:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 02B1D611C2 for ; Fri, 16 Apr 2021 15:17:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343607AbhDPPR1 (ORCPT ); Fri, 16 Apr 2021 11:17:27 -0400 Received: from smtprelay0213.hostedemail.com ([216.40.44.213]:48228 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S244671AbhDPPOl (ORCPT ); Fri, 16 Apr 2021 11:14:41 -0400 Received: from omf09.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id 1E7E7182CED5B; Fri, 16 Apr 2021 15:12:05 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf09.hostedemail.com (Postfix) with ESMTPA id 9F81C1E04DB; Fri, 16 Apr 2021 15:12:03 +0000 (UTC) Message-ID: <9e5a552b8b1f65af3eb4d2371a19c33d97f642d0.camel@perches.com> Subject: Re: [PATCH 1/5] scsi: BusLogic: Fix missing `pr_cont' use From: Joe Perches To: "Maciej W. Rozycki" Cc: Khalid Aziz , "James E.J. Bottomley" , "Martin K. Petersen" , Christoph Hellwig , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Date: Fri, 16 Apr 2021 08:12:01 -0700 In-Reply-To: References: <787aae5540612555a8bf92de2083c8fa74e52ce9.camel@perches.com> <86c10671ff86f96004a6d6c3c08aed3e27d58d0a.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 9F81C1E04DB X-Stat-Signature: s9mxuosraujha4i8xyc6wiu14nyngk5u X-Rspamd-Server: rspamout01 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX18h5DhmD5kG2CH6aqwm9teq+oQ9Oz950oY= X-HE-Tag: 1618585923-648852 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2021-04-16 at 16:28 +0200, Maciej W. Rozycki wrote: > On Fri, 16 Apr 2021, Joe Perches wrote: > > > > I'm not sure if that complex message > > > routing via `blogic_msg' is worth having even, rather than calling > > > `printk' or suitable variants directly. > > > > It's to allow the message content to be added to the internal > > &adapter->msgbuf[adapter->msgbuflen] > > with strcpy for later use with blogic_show_info()/seq_write. > >  I know, but it's not clear to me if it's worth it (a potential buffer > overrun there too, BTW). It's seq_ output so it's nominally an ABI. But then again, I don't use this at all so I don't care much either. It's also odd/bad form that one output KERN_ does not match its blogic_ (blogic_info is emitted at KERN_NOTICE)