From: Jacob Keller <jacob.e.keller@intel.com>
To: Jocelyn Falempe <jfalempe@redhat.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Dave Airlie <airlied@redhat.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Simona Vetter <simona@ffwll.ch>
Cc: Pasi Vaananen <pvaanane@redhat.com>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
<stable@vger.kernel.org>
Subject: Re: [PATCH] drm/mgag200: sleep instead of busy wait for BMC
Date: Mon, 2 Feb 2026 15:49:35 -0800 [thread overview]
Message-ID: <9e61174d-f4df-4588-b105-e0c791181917@intel.com> (raw)
In-Reply-To: <85edc1c4-1985-48d0-9ece-50a5c70e1752@redhat.com>
On 1/30/2026 6:22 AM, Jocelyn Falempe wrote:
> On 30/01/2026 15:03, Thomas Zimmermann wrote:
>> This is roughly the time that the CRTC spends in each scanline's blank
>> area and likely the upper bound for the duration of a single polling
>> with that display mode. Otherwise, we might miss the blank.
>>
>> Honestly, I'd just take the proposed patch as it is and not bother any
>> further. I think this is the correct fix unless we can figure out the
>> exact meaning of these bits and the BMC.
>
> I'm fine with that too. At least on my machine, this waits for a random
> amount of time, and that looks to work.
Sounds good. I'll send a v2 with an updated description to explain the
changes to the condition logic and better explaining the problem as a whole.
That should be out later today.
Thanks everyone!
-Jake
prev parent reply other threads:[~2026-02-02 23:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-28 20:41 Jacob Keller
2026-01-29 8:15 ` Thomas Zimmermann
2026-01-29 17:02 ` Jacob Keller
2026-01-29 17:35 ` Jacob Keller
2026-01-29 18:47 ` Jocelyn Falempe
2026-01-29 19:19 ` Jacob Keller
2026-01-30 7:15 ` Thomas Zimmermann
2026-01-30 13:27 ` Jocelyn Falempe
2026-01-30 14:03 ` Thomas Zimmermann
2026-01-30 14:22 ` Jocelyn Falempe
2026-02-02 23:49 ` Jacob Keller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e61174d-f4df-4588-b105-e0c791181917@intel.com \
--to=jacob.e.keller@intel.com \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jfalempe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=pvaanane@redhat.com \
--cc=simona@ffwll.ch \
--cc=stable@vger.kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®