From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932538AbcGDD6y (ORCPT ); Sun, 3 Jul 2016 23:58:54 -0400 Received: from darkcity.gna.ch ([195.226.6.51]:44708 "EHLO mail.gna.ch" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751854AbcGDD6x (ORCPT ); Sun, 3 Jul 2016 23:58:53 -0400 Subject: Re: [PATCH] drm/radeon: Remove deprecated create_singlethread_workqueue To: Tejun Heo , Bhaktipriya Shridhar References: <20160702110350.GA3601@Karyakshetra> <20160702134614.GB17431@htj.duckdns.org> Cc: Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org From: =?UTF-8?Q?Michel_D=c3=a4nzer?= Message-ID: <9e69b1fd-eb93-1fee-15af-c905ee3a202f@daenzer.net> Date: Mon, 4 Jul 2016 12:58:32 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.1.0 MIME-Version: 1.0 In-Reply-To: <20160702134614.GB17431@htj.duckdns.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02.07.2016 22:46, Tejun Heo wrote: > On Sat, Jul 02, 2016 at 04:33:50PM +0530, Bhaktipriya Shridhar wrote: >> alloc_workqueue replaces deprecated create_singlethread_workqueue(). >> >> A dedicated workqueue has been used since work items need to be flushed >> as a group rather than individually. >> >> Since the flip_queue workqueue is involved in page-flipping and is not >> being used on a memory reclaim path, WQ_MEM_RECLAIM has not been set. >> >> Since there are only a fixed number of work items, explicit concurrency >> limit is unnecessary here. > > What are the involved work items? drivers/gpu/drm/radeon/radeon_display.c:radeon_flip_work_func() > Is it safe to run them concurrently? Concurrently with what exactly? -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer