From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] arm64: dts: qcom: sm8450: drop incorrect cells from serial
Date: Mon, 23 Jan 2023 17:29:23 +0100 [thread overview]
Message-ID: <9e69f980-658e-0f06-a2d6-893ad3637d3f@linaro.org> (raw)
In-Reply-To: <20230123125612.154840-3-krzysztof.kozlowski@linaro.org>
On 23.01.2023 13:56, Krzysztof Kozlowski wrote:
> The serial/UART device node does not have children with unit addresses,
> so adderss/size cells are not correct.
>
> Fixes: f5837418479a ("arm64: dts: qcom: sm8450: add uart20 node")
> Fixes: 5188049c9b36 ("arm64: dts: qcom: Add base SM8450 DTSI")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
>
> Changes since v1:
> 1. None
> ---
> arch/arm64/boot/dts/qcom/sm8450.dtsi | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> index d66dcd8fe61f..395a3a156e24 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> @@ -1017,8 +1017,6 @@ uart20: serial@894000 {
> pinctrl-names = "default";
> pinctrl-0 = <&qup_uart20_default>;
> interrupts = <GIC_SPI 587 IRQ_TYPE_LEVEL_HIGH>;
> - #address-cells = <1>;
> - #size-cells = <0>;
> status = "disabled";
> };
>
> @@ -1411,8 +1409,6 @@ uart7: serial@99c000 {
> pinctrl-names = "default";
> pinctrl-0 = <&qup_uart7_tx>, <&qup_uart7_rx>;
> interrupts = <GIC_SPI 608 IRQ_TYPE_LEVEL_HIGH>;
> - #address-cells = <1>;
> - #size-cells = <0>;
> status = "disabled";
> };
> };
next prev parent reply other threads:[~2023-01-23 16:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 12:56 [PATCH v2 1/4] arm64: dts: qcom: use generic node name for Bluetooth Krzysztof Kozlowski
2023-01-23 12:56 ` [PATCH v2 2/4] arm64: dts: qcom: sm8350: drop incorrect cells from serial Krzysztof Kozlowski
2023-01-23 16:29 ` Konrad Dybcio
2023-01-23 12:56 ` [PATCH v2 3/4] arm64: dts: qcom: sm8450: " Krzysztof Kozlowski
2023-01-23 16:29 ` Konrad Dybcio [this message]
2023-01-23 12:56 ` [PATCH v2 4/4] arm64: dts: qcom: sm8550: " Krzysztof Kozlowski
2023-01-23 16:29 ` Konrad Dybcio
2023-01-23 16:27 ` [PATCH v2 1/4] arm64: dts: qcom: use generic node name for Bluetooth Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e69f980-658e-0f06-a2d6-893ad3637d3f@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®