From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98CBC16C86C for ; Mon, 19 Aug 2024 13:22:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724073778; cv=none; b=qyehCQjHsbRTV35c4kMzDPFu+wALKGJOzd43DpsqO/TxbIO0ZkwfNuhshbHZ/TiAhrzNVBcXX6WE5hvpGw0YI7JxXwXuZ6taq18bhRNc8lDpvZOx3dBIC+TdueB50eTk07Vayg3PJSfkggl+KP6mEUileiczMDobuULOCBcwZrc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724073778; c=relaxed/simple; bh=O2MwCfLhtuz3WtZXy/MYatQ0Sno9ksR85Gi+1RqITFU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uWXtz27PDvD7WhFgTNUzlVZ0Q1xs07mAuP/42yspu1N54FhSndF6Lg6w7Mp+vFAsVFLL+0EYhdKAk7vZ7liSAbvE+imYKpaPjJr0YP3I4PLtzRWFRUgkiCdju5KmZeUoTlJBPasoLNR7IvcB87Y5oMjMmimSKdBsLQULXec6Vdo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=yDk/K3A4; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yDk/K3A4" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4281d812d3eso47541525e9.3 for ; Mon, 19 Aug 2024 06:22:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1724073775; x=1724678575; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=GuyNk5fVdyh6epV9U4Iq9p9Lvv3ALtYfwMJQqqgo6Yk=; b=yDk/K3A4AZrayhh2VHwN98Zfi9uulq1lRuePuwUVBT92asa1xO/LJXdVWkOy9XUVle g39Tn/s6mXGRNHIgV6hVoLJOBiHkg16ApaSQEi55x2bg/qAwCmcW9UWHzTi1oiS3gppc HUJominY65l9ehZBFDkXuU9UrEDisBKLAs6A95KOerXO9MVVG0UxchEyGawsd95SsubL v4ho8UremKnbYINTxJmtFjreqmrgvcqlCeHqrEbGrPG/rH2uSolLVE67ac+FnxV7jOlX VQ3fvoEwa/x65Zp0OOX+ht4pQL7Sh2DEXlDUGBbH8ZOGFxAuwOvVt+tpbjY3izEkIXtH 9QQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724073775; x=1724678575; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GuyNk5fVdyh6epV9U4Iq9p9Lvv3ALtYfwMJQqqgo6Yk=; b=nqYApLTMiTC8kRW2ILFbUEW+xC5DB+pl12Z0UIedbZuCYuJKP4rrjjOOeLXxADbAPt yfz/QJHLKUJsRL5uvNLD0wPW3tEvyECI7wDTywaFxEVK8EsQ9W588d1DkdXKF1Q5FT0V TMTfQZzg5C49Hnjpw3iCLpcwx+pVpoaPHdaazSbhiwA3OntepsxVUHgKmLkluex+H8RV WK1bLbApapofckQDXjkP3CoZFa3Fw+qF9B7E+jkexGu6oLFc1lbHjtf3c5YG3NF589mi dgHHq42TusGz2KpTUhMU/6BvVQtpIKwG63jrAMWBbKA+zJ1x9rAuy6djDDYQAhzprfYj iFow== X-Forwarded-Encrypted: i=1; AJvYcCXohKMOh9TCNZ8uAH32DVFCJAB0fMx+QCFqx7GVQl4FdOZ6gbpCdyXRtum7UwFQ6k3zyhu8V5Rt6yorEShuqcJKFVHHRuylj3BBAuDq X-Gm-Message-State: AOJu0YwrWAGctm0ZPBSzNQcfYA9GR5zZ3Xnj9MllRKRDjxxqxcL/67YD 1eOkKKwlzZ1/itWBZrEmUp1E3LrubrmwebXQottpNASgxTNUJSOBer8njp4qugE= X-Google-Smtp-Source: AGHT+IEPz54Ns7DkJpUWWgC/R1C4JWEbFnoSanERwA9Q7te9U+I6z6L41rY0uwvrgLlKgxD0fLi0cg== X-Received: by 2002:a05:600c:4753:b0:426:593c:9359 with SMTP id 5b1f17b1804b1-429ed7ed62fmr88977775e9.32.1724073774440; Mon, 19 Aug 2024 06:22:54 -0700 (PDT) Received: from [192.168.10.46] (146725694.box.freepro.com. [130.180.211.218]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-3718985a6d1sm10654962f8f.57.2024.08.19.06.22.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Aug 2024 06:22:53 -0700 (PDT) Message-ID: <9e6d817f-1fcf-4d31-b0c5-d68753e1f949@linaro.org> Date: Mon, 19 Aug 2024 15:22:53 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] thermal: of: Fix OF node leak in thermal_of_trips_init() error path To: "Rafael J. Wysocki" Cc: Krzysztof Kozlowski , Zhang Rui , Lukasz Luba , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20240814195823.437597-1-krzysztof.kozlowski@linaro.org> Content-Language: en-US From: Daniel Lezcano In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 19/08/2024 15:20, Rafael J. Wysocki wrote: > On Mon, Aug 19, 2024 at 12:12 PM Daniel Lezcano > wrote: >> >> On 14/08/2024 21:58, Krzysztof Kozlowski wrote: >>> Terminating for_each_child_of_node() loop requires dropping OF node >>> reference, so bailing out after thermal_of_populate_trip() error misses >>> this. Solve the OF node reference leak with scoped >>> for_each_child_of_node_scoped(). >>> >>> Fixes: d0c75fa2c17f ("thermal/of: Initialize trip points separately") >>> Cc: >>> Signed-off-by: Krzysztof Kozlowski >>> --- >> >> Applied, thanks for the fixes > > Is there a place from which I can pull these? > > It would be good to include them into 6.11 as they are -stable material. > > Alternatively, I can pick them up from the list. I'll send a PR for fixes only. Let me double check if there are other fixes to go along with those -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog